Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11147

Remove confusing log output in FsDatasetImpl#getInitialVolumeFailureInfos

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha2
    • datanode
    • None
    • Reviewed

    Description

      In FsDatasetImpl the method getInitialVolumeFailureInfos there is

      for (StorageLocation sl: dataLocations) {
            LOG.info("Adding to failedLocationSet " + sl);
            failedLocationSet.add(sl);
          }
          for (Iterator<Storage.StorageDirectory> it = storage.dirIterator();
               it.hasNext(); ) {
            Storage.StorageDirectory sd = it.next();
            failedLocationSet.remove(sd.getStorageLocation());
            LOG.info("Removing from failedLocationSet " + sd.getStorageLocation());
          }
      }
      

      The log messages here can be confusing as it may prints "Adding to failedLocationSet" message, which looks like a failure is happening, but later on removed the storage location from failedLocationSet. We should just remove these two log messages.

      Attachments

        1. HDFS-11147.001.patch
          1 kB
          Chen Liang

        Activity

          People

            vagarychen Chen Liang
            vagarychen Chen Liang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: