Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
In FsDatasetImpl the method getInitialVolumeFailureInfos there is
for (StorageLocation sl: dataLocations) { LOG.info("Adding to failedLocationSet " + sl); failedLocationSet.add(sl); } for (Iterator<Storage.StorageDirectory> it = storage.dirIterator(); it.hasNext(); ) { Storage.StorageDirectory sd = it.next(); failedLocationSet.remove(sd.getStorageLocation()); LOG.info("Removing from failedLocationSet " + sd.getStorageLocation()); } }
The log messages here can be confusing as it may prints "Adding to failedLocationSet" message, which looks like a failure is happening, but later on removed the storage location from failedLocationSet. We should just remove these two log messages.