Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11097

Fix the jenkins warning related to the deprecated method StorageReceivedDeletedBlocks

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After HDFS-6094, it updated the constrcut method of StorageReceivedDeletedBlocks and let it good to use. We can pass not only the storage type and state as well. But this new method isn't updated in some test case and it cause many warnings in each jenkins buildings. The part of warning infos:

      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBrVariations.java:[175,12] [deprecation] StorageReceivedDeletedBlocks(String,ReceivedDeletedBlockInfo[]) in StorageReceivedDeletedBlocks has been deprecated
      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java:[315,14] [deprecation] StorageReceivedDeletedBlocks(String,ReceivedDeletedBlockInfo[]) in StorageReceivedDeletedBlocks has been deprecated
      [WARNING] /testptch/hadoop/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java:[333,14] [deprecation] StorageReceivedDeletedBlocks(String,ReceivedDeletedBlockInfo[]) in StorageReceivedDeletedBlocks has been deprecated
      
      1. warn.txt
        17 kB
        Yiqun Lin
      2. HDFS-11097.001.patch
        9 kB
        Yiqun Lin

        Issue Links

          Activity

          Hide
          linyiqun Yiqun Lin added a comment -

          Attach the full warn logs.

          Show
          linyiqun Yiqun Lin added a comment - Attach the full warn logs.
          Hide
          linyiqun Yiqun Lin added a comment -

          Attach a initial patch to update the method. Hi Arpit Agarwal, could you please have a look for this? I have updated the related codes as you have mentioned in HDFS-6094. Thanks!

          Show
          linyiqun Yiqun Lin added a comment - Attach a initial patch to update the method. Hi Arpit Agarwal , could you please have a look for this? I have updated the related codes as you have mentioned in HDFS-6094 . Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
          +1 mvninstall 7m 38s trunk passed
          +1 compile 0m 46s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 46s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 47s the patch passed
          -1 javac 0m 47s hadoop-hdfs-project_hadoop-hdfs generated 1 new + 28 unchanged - 8 fixed = 29 total (was 36)
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 179 unchanged - 4 fixed = 182 total (was 183)
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 38s the patch passed
          -1 unit 67m 36s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          97m 31s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
            hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-11097
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836765/HDFS-11097.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 99874c784542 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0e75496
          Default Java 1.8.0_111
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17401/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17401/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files. +1 mvninstall 7m 38s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 47s the patch passed -1 javac 0m 47s hadoop-hdfs-project_hadoop-hdfs generated 1 new + 28 unchanged - 8 fixed = 29 total (was 36) -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 179 unchanged - 4 fixed = 182 total (was 183) +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 67m 36s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 97m 31s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11097 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836765/HDFS-11097.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 99874c784542 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0e75496 Default Java 1.8.0_111 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project_hadoop-hdfs.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17401/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17401/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          linyiqun Yiqun Lin added a comment - - edited

          The latest jenkins's warnings related to the new construct method public StorageReceivedDeletedBlocks(final String storageID, final ReceivedDeletedBlockInfo[] blocks) have been all fixed(jenkins infos:https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt). The javadoc warnings is already existed.

          Show
          linyiqun Yiqun Lin added a comment - - edited The latest jenkins's warnings related to the new construct method public StorageReceivedDeletedBlocks(final String storageID, final ReceivedDeletedBlockInfo[] blocks) have been all fixed(jenkins infos: https://builds.apache.org/job/PreCommit-HDFS-Build/17401/artifact/patchprocess/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt ). The javadoc warnings is already existed.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed for 2.8.0. The issues flagged by Jenkins were false-positives.

          Thank you for fixing this Yiqun Lin.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed for 2.8.0. The issues flagged by Jenkins were false-positives. Thank you for fixing this Yiqun Lin .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10764 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10764/)
          HDFS-11097. Fix warnings for deprecated StorageReceivedDeletedBlocks (arp: rev b71907b2ae3d8f05b4332e06d52ec2096681ea6b)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/DatanodeProtocolServerSideTranslatorPB.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBrVariations.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/StorageReceivedDeletedBlocks.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10764 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10764/ ) HDFS-11097 . Fix warnings for deprecated StorageReceivedDeletedBlocks (arp: rev b71907b2ae3d8f05b4332e06d52ec2096681ea6b) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/DatanodeProtocolServerSideTranslatorPB.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestIncrementalBrVariations.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/StorageReceivedDeletedBlocks.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDeadDatanode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReconstruction.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java
          Hide
          andrew.wang Andrew Wang added a comment -

          Reminder to please also set the appropriate 3.x fix version, thanks.

          Show
          andrew.wang Andrew Wang added a comment - Reminder to please also set the appropriate 3.x fix version, thanks.
          Hide
          linyiqun Yiqun Lin added a comment -

          Thanks Arpit Agarwal for the review and commit!

          Show
          linyiqun Yiqun Lin added a comment - Thanks Arpit Agarwal for the review and commit!

            People

            • Assignee:
              linyiqun Yiqun Lin
              Reporter:
              linyiqun Yiqun Lin
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development