Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-11054

Suppress verbose log message in BlockPlacementPolicyDefault

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We saw an instance where this log message was generated millions of times in a short time interval, slowing the NameNode to a crawl. It can probably be changed to log at DEBUG level instead.

            if (cur == null) {
              LOG.warn("No excess replica can be found. excessTypes: "+excessTypes+
                  ". moreThanOne: "+moreThanOne+". exactlyOne: "+exactlyOne+".");
              break;
            }
      
      1. HDFS-11054.001.patch
        1 kB
        Chen Liang
      2. HDFS-11054.002.patch
        1 kB
        Chen Liang

        Activity

        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 pending Jenkins.

        Thanks for the quick fix Chen Liang! cc Tsz Wo Nicholas Sze who reported this.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 pending Jenkins. Thanks for the quick fix Chen Liang ! cc Tsz Wo Nicholas Sze who reported this.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Arpit Agarwal for reporting the issue and Chen Liang for posting the fix. NIT: There is a minor tab/space issue in the 2nd line of the changed log. +1 pending Jenkins.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Arpit Agarwal for reporting the issue and Chen Liang for posting the fix. NIT: There is a minor tab/space issue in the 2nd line of the changed log. +1 pending Jenkins.
        Hide
        vagarychen Chen Liang added a comment -

        Thanks Xiaoyu Yao for pointing out the spacing issue, fixed it in v002 patch.

        Show
        vagarychen Chen Liang added a comment - Thanks Xiaoyu Yao for pointing out the spacing issue, fixed it in v002 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 2s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 46s trunk passed
        +1 javadoc 0m 38s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 52s the patch passed
        +1 javadoc 0m 37s the patch passed
        -1 unit 44m 40s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        63m 33s



        Reason Tests
        Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestHSync
          org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade
          org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter
          org.apache.hadoop.cli.TestCryptoAdminCLI
          org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation
          org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11054
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835211/HDFS-11054.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3ff4424b29b4 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 86c735b
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17283/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17283/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17283/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 2s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 38s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 44m 40s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 63m 33s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestHSync   org.apache.hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade   org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyWriter   org.apache.hadoop.cli.TestCryptoAdminCLI   org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestSpaceReservation   org.apache.hadoop.hdfs.server.datanode.TestFsDatasetCache Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11054 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835211/HDFS-11054.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3ff4424b29b4 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86c735b Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17283/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17283/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17283/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Thanks Chen Liang for the fix. +1 the patch v002.

        Show
        xiaobingo Xiaobing Zhou added a comment - Thanks Chen Liang for the fix. +1 the patch v002.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 57s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 0m 41s trunk passed
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 41s the patch passed
        +1 javac 0m 41s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 39s the patch passed
        -1 unit 65m 2s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        84m 16s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
          hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
          hadoop.hdfs.web.TestWebHDFS
        Timed out junit tests org.apache.hadoop.hdfs.TestSmallBlock
          org.apache.hadoop.hdfs.TestPread
          org.apache.hadoop.hdfs.TestSafeMode
          org.apache.hadoop.hdfs.TestDFSUpgradeFromImage
          org.apache.hadoop.hdfs.server.mover.TestStorageMover
          org.apache.hadoop.hdfs.server.mover.TestMover
          org.apache.hadoop.hdfs.TestLeaseRecoveryStriped



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11054
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835213/HDFS-11054.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e40d78ba2bae 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 86c735b
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17284/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17284/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17284/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 8s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 41s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 65m 2s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 84m 16s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.web.TestWebHDFS Timed out junit tests org.apache.hadoop.hdfs.TestSmallBlock   org.apache.hadoop.hdfs.TestPread   org.apache.hadoop.hdfs.TestSafeMode   org.apache.hadoop.hdfs.TestDFSUpgradeFromImage   org.apache.hadoop.hdfs.server.mover.TestStorageMover   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.hdfs.TestLeaseRecoveryStriped Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11054 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835213/HDFS-11054.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e40d78ba2bae 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86c735b Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17284/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17284/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17284/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Whoa.. that's a lot of test failures and certainly unrelated to this logging change.

        I will commit it shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - Whoa.. that's a lot of test failures and certainly unrelated to this logging change. I will commit it shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Pushed to 2.8.0.

        Thank you for the contribution Chen Liang and thanks for the code review Xiaoyu Yao!

        Show
        arpitagarwal Arpit Agarwal added a comment - Pushed to 2.8.0. Thank you for the contribution Chen Liang and thanks for the code review Xiaoyu Yao !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10680 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10680/)
        HDFS-11054. Suppress verbose log message in BlockPlacementPolicyDefault. (arp: rev 9dce9011ad211bf35fe2538ded0f19d68f5c16d2)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10680 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10680/ ) HDFS-11054 . Suppress verbose log message in BlockPlacementPolicyDefault. (arp: rev 9dce9011ad211bf35fe2538ded0f19d68f5c16d2) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java

          People

          • Assignee:
            vagarychen Chen Liang
            Reporter:
            arpitagarwal Arpit Agarwal
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development