Details

      Description

      hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/dump.c has three minor typos.

      hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/isal_load.h has one badly written comment.

      1. HDFS-11013.1.patch
        2 kB
        László Bence Nagy

        Activity

        Hide
        Lac21 László Bence Nagy added a comment -

        Please review.

        Show
        Lac21 László Bence Nagy added a comment - Please review.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for the contribution, +1 LGTM! I added you as a contributor on JIRA and assigned this to you, let's see what precommit bot thinks.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for the contribution, +1 LGTM! I added you as a contributor on JIRA and assigned this to you, let's see what precommit bot thinks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 31s trunk passed
        +1 compile 6m 48s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 mvninstall 0m 35s the patch passed
        +1 compile 6m 40s the patch passed
        +1 cc 6m 40s the patch passed
        +1 javac 6m 40s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 unit 8m 5s hadoop-common in the patch passed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        31m 37s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-11013
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833333/HDFS-11013.1.patch
        Optional Tests asflicense compile cc mvnsite javac unit
        uname Linux b53c3f20c961 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 76cc84e
        Default Java 1.8.0_101
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17169/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17169/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 31s trunk passed +1 compile 6m 48s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 mvninstall 0m 35s the patch passed +1 compile 6m 40s the patch passed +1 cc 6m 40s the patch passed +1 javac 6m 40s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 unit 8m 5s hadoop-common in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 31m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11013 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833333/HDFS-11013.1.patch Optional Tests asflicense compile cc mvnsite javac unit uname Linux b53c3f20c961 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 76cc84e Default Java 1.8.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17169/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17169/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Lac21 László Bence Nagy added a comment -

        Thank you, Andrew! About the bot's reaction, I believe additional tests are not needed here as these are just some minor bug fixes in dump code.

        Show
        Lac21 László Bence Nagy added a comment - Thank you, Andrew! About the bot's reaction, I believe additional tests are not needed here as these are just some minor bug fixes in dump code.
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to trunk, thanks for the contribution!

        Show
        andrew.wang Andrew Wang added a comment - Committed to trunk, thanks for the contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10627 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10627/)
        HDFS-11013. Correct typos in native erasure coding dump code. (wang: rev b671ee6846b79a6d106efed7cf7e1209b2cc408d)

        • (edit) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/dump.c
        • (edit) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/isal_load.h
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10627 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10627/ ) HDFS-11013 . Correct typos in native erasure coding dump code. (wang: rev b671ee6846b79a6d106efed7cf7e1209b2cc408d) (edit) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/dump.c (edit) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/erasurecode/isal_load.h
        Hide
        Lac21 László Bence Nagy added a comment -

        Great! I'm glad I could help a little bit.

        Show
        Lac21 László Bence Nagy added a comment - Great! I'm glad I could help a little bit.

          People

          • Assignee:
            Lac21 László Bence Nagy
            Reporter:
            Lac21 László Bence Nagy
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development