[HDFS-11002] Fix broken attr/getfattr/setfattr links in ExtendedAttributes.md - ASF JIRA

Details

Type: Bug
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.7.0
Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
Component/s: documentation
Labels:
None

Target Version/s:

2.7.4, 3.0.0-alpha2
Hadoop Flags:

Reviewed

Description

http://www.bestbits.at/acl/man/man5/attr.txt is broken though the website is not. I suggest we use the http://man7.org/linux/man-pages/man5/attr.5.html which is mainted by maintainer of the Linux man-pages project.

The same to http://www.bestbits.at/acl/man/man1/getfattr.txt => http://man7.org/linux/man-pages/man1/getfattr.1.html
and http://www.bestbits.at/acl/man/man1/setfattr.txt => http://man7.org/linux/man-pages/man1/setfattr.1.html

Akira Ajisaka, thoughts? Thanks.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

HDFS-11002.000.patch

13/Oct/16 01:38

3 kB

Mingliang Liu
HDFS-11002.001.patch

13/Oct/16 02:55

3 kB

Mingliang Liu

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Mingliang Liu added a comment - 13/Oct/16 01:38

Kindly review.

Show

Mingliang Liu added a comment - 13/Oct/16 01:38 Kindly review.

Hide

Permalink

Hadoop QA added a comment - 13/Oct/16 01:58

+1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0m 23s	Docker mode activated.
+1	@author	0m 0s	The patch does not contain any @author tags.
+1	mvninstall	7m 36s	trunk passed
+1	mvnsite	0m 54s	trunk passed
+1	mvnsite	0m 50s	the patch passed
+1	whitespace	0m 0s	The patch has no whitespace issues.
+1	asflicense	0m 15s	The patch does not generate ASF License warnings.
		10m 14s

Subsystem	Report/Notes
Docker	Image:yetus/hadoop:9560f25
JIRA Issue	~~HDFS-11002~~
JIRA Patch URL	https://issues.apache.org/jira/secure/attachment/12833012/HDFS-11002.000.patch
Optional Tests	asflicense mvnsite
uname	Linux 6709fea9f912 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision	trunk / 12d739a
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/PreCommit-HDFS-Build/17133/console
Powered by	Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

Show

Hadoop QA added a comment - 13/Oct/16 01:58 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 7m 36s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 10m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11002 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833012/HDFS-11002.000.patch Optional Tests asflicense mvnsite uname Linux 6709fea9f912 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 12d739a modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17133/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Hide

Permalink

Akira Ajisaka added a comment - 13/Oct/16 02:19

Thanks Mingliang Liu for reporting this and providing a patch!

[attr(5)](http://man7.org/linux/man-pages/man5/attr.5.html)

Recently attr(5) was renamed to xattr(7), but I don't think we should update now because many users cannot execute man 7 xattr on their own environment.

and [related documentation](http://www.bestbits.at/acl/)

This page has no document for xattr. Can be removed.

Show

Akira Ajisaka added a comment - 13/Oct/16 02:19 Thanks Mingliang Liu for reporting this and providing a patch! [attr(5)]( http://man7.org/linux/man-pages/man5/attr.5.html ) Recently attr(5) was renamed to xattr(7), but I don't think we should update now because many users cannot execute man 7 xattr on their own environment. and [related documentation]( http://www.bestbits.at/acl/ ) This page has no document for xattr. Can be removed.

Hide

Permalink

Mingliang Liu added a comment - 13/Oct/16 02:55

Thank you Akira Ajisaka for your prompt review!

Recently attr(5) was renamed to xattr(7), but I don't think we should update now because many users cannot execute man 7 xattr on their own environment.

Agreed. Let's update this in the future.

http://www.bestbits.at/acl/
This page has no document for xattr. Can be removed.

V1 patch is to remove this.

Show

Mingliang Liu added a comment - 13/Oct/16 02:55 Thank you Akira Ajisaka for your prompt review! Recently attr(5) was renamed to xattr(7), but I don't think we should update now because many users cannot execute man 7 xattr on their own environment. Agreed. Let's update this in the future. http://www.bestbits.at/acl/ This page has no document for xattr. Can be removed. V1 patch is to remove this.

Hide

Permalink

Hadoop QA added a comment - 13/Oct/16 03:10

+1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	0m 19s	Docker mode activated.
+1	@author	0m 0s	The patch does not contain any @author tags.
+1	mvninstall	9m 24s	trunk passed
+1	mvnsite	1m 0s	trunk passed
+1	mvnsite	0m 50s	the patch passed
+1	whitespace	0m 0s	The patch has no whitespace issues.
+1	asflicense	0m 15s	The patch does not generate ASF License warnings.
		12m 2s

Subsystem	Report/Notes
Docker	Image:yetus/hadoop:9560f25
JIRA Issue	~~HDFS-11002~~
JIRA Patch URL	https://issues.apache.org/jira/secure/attachment/12833024/HDFS-11002.001.patch
Optional Tests	asflicense mvnsite
uname	Linux 5eb11a9144d5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/hadoop/patchprocess/precommit/personality/provided.sh
git revision	trunk / 12d739a
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/PreCommit-HDFS-Build/17134/console
Powered by	Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

This message was automatically generated.

Show

Hadoop QA added a comment - 13/Oct/16 03:10 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 mvninstall 9m 24s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 2s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-11002 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833024/HDFS-11002.001.patch Optional Tests asflicense mvnsite uname Linux 5eb11a9144d5 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 12d739a modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17134/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

Hide

Permalink

Akira Ajisaka added a comment - 13/Oct/16 04:30

LGTM, +1.

Show

Akira Ajisaka added a comment - 13/Oct/16 04:30 LGTM, +1.

Hide

Permalink

Akira Ajisaka added a comment - 13/Oct/16 05:33

Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Mingliang Liu for the contribution!

Show

Akira Ajisaka added a comment - 13/Oct/16 05:33 Committed this to trunk, branch-2, branch-2.8, and branch-2.7. Thanks Mingliang Liu for the contribution!

Hide

Permalink

Mingliang Liu added a comment - 13/Oct/16 05:38

Thank you for your review and commit!

Show

Mingliang Liu added a comment - 13/Oct/16 05:38 Thank you for your review and commit!

Hide

Permalink

Hudson added a comment - 13/Oct/16 06:03

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10599 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10599/)
~~HDFS-11002~~. Fix broken attr/getfattr/setfattr links in (aajisaka: rev 901eca004d0e7e413b109a93128892176c808d61)

(edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/ExtendedAttributes.md

Show

Hudson added a comment - 13/Oct/16 06:03 SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10599 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10599/ ) HDFS-11002 . Fix broken attr/getfattr/setfattr links in (aajisaka: rev 901eca004d0e7e413b109a93128892176c808d61) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/ExtendedAttributes.md

People

Assignee:

Mingliang Liu

Reporter:

Mingliang Liu

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

13/Oct/16 01:36

Updated:

13/Oct/16 06:03

Resolved:

13/Oct/16 05:33

Development

Agile

View on Board