Details

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      This introduced a new erasure coding policy named XOR-2-1-64k using the simple XOR codec, and it can be used to evaluate HDFS erasure coding feature in a small cluster (only 2 + 1 datanodes needed). The policy isn't recommended to be used in a production cluster.
      Show
      This introduced a new erasure coding policy named XOR-2-1-64k using the simple XOR codec, and it can be used to evaluate HDFS erasure coding feature in a small cluster (only 2 + 1 datanodes needed). The policy isn't recommended to be used in a production cluster.

      Description

      So far, "hdfs erasurecode" command supports three policies, RS-DEFAULT-3-2-64k, RS-DEFAULT-6-3-64k and RS-LEGACY-6-3-64k. This task is going to add XOR-2-1-64k policy to this command.

      1. HDFS-10994-v5.patch
        23 kB
        SammiChen
      2. HDFS-10994-v4.patch
        28 kB
        SammiChen
      3. HDFS-10994-v3.patch
        27 kB
        SammiChen
      4. HDFS-10994-v2.patch
        28 kB
        SammiChen
      5. HDFS-10994-v1.patch
        29 kB
        SammiChen

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10913/)
        Revert due to an error "HDFS-10994. Support an XOR policy XOR-2-1-64k in (kai.zheng: rev cfd8076f81930c3ffea8ec2ef42926217b83ab1a)

        • (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java
        • (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        • (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java
        • (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicyForReservedContainers.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java
          HDFS-10994. Support an XOR policy XOR-2-1-64k in HDFS. Contributed by (kai.zheng: rev 51e6c1cc3f66f9908d2e816e7291ac34bee43f52)
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10913 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10913/ ) Revert due to an error " HDFS-10994 . Support an XOR policy XOR-2-1-64k in (kai.zheng: rev cfd8076f81930c3ffea8ec2ef42926217b83ab1a) (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java (delete) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicyForReservedContainers.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java HDFS-10994 . Support an XOR policy XOR-2-1-64k in HDFS. Contributed by (kai.zheng: rev 51e6c1cc3f66f9908d2e816e7291ac34bee43f52) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
        Hide
        drankye Kai Zheng added a comment -

        Note there was a mistake in the previous commit, by wrongly deleting the file TestProportionalCapacityPreemptionPolicyForReservedContainers.java . It was corrected as below.

        commit 51e6c1cc3f66f9908d2e816e7291ac34bee43f52
        Author: Kai Zheng <kai.zheng@intel.com>
        Date: Wed Nov 30 15:52:56 2016 +0800

        HDFS-10994. Support an XOR policy XOR-2-1-64k in HDFS. Contributed by Sammi Chen

        commit cfd8076f81930c3ffea8ec2ef42926217b83ab1a
        Author: Kai Zheng <kai.zheng@intel.com>
        Date: Wed Nov 30 15:44:52 2016 +0800

        Revert due to an error "HDFS-10994. Support an XOR policy XOR-2-1-64k in HDFS. Contributed by Sammi Chen"

        This reverts commit 5614f847b2ef2a5b70bd9a06edc4eba06174c6.

        Show
        drankye Kai Zheng added a comment - Note there was a mistake in the previous commit, by wrongly deleting the file TestProportionalCapacityPreemptionPolicyForReservedContainers.java . It was corrected as below. commit 51e6c1cc3f66f9908d2e816e7291ac34bee43f52 Author: Kai Zheng <kai.zheng@intel.com> Date: Wed Nov 30 15:52:56 2016 +0800 HDFS-10994 . Support an XOR policy XOR-2-1-64k in HDFS. Contributed by Sammi Chen commit cfd8076f81930c3ffea8ec2ef42926217b83ab1a Author: Kai Zheng <kai.zheng@intel.com> Date: Wed Nov 30 15:44:52 2016 +0800 Revert due to an error " HDFS-10994 . Support an XOR policy XOR-2-1-64k in HDFS. Contributed by Sammi Chen" This reverts commit 5614f847b2ef2a5b70bd9a06edc4eba06174c6.
        Hide
        Sammi SammiChen added a comment -

        Thanks Andrew for the remider! I created JIRA HDFS-11183 to track it.

        Show
        Sammi SammiChen added a comment - Thanks Andrew for the remider! I created JIRA HDFS-11183 to track it.
        Hide
        andrew.wang Andrew Wang added a comment -

        Nice work here Sammi! Do we also need a follow on for a documentation update?

        Show
        andrew.wang Andrew Wang added a comment - Nice work here Sammi! Do we also need a follow on for a documentation update?
        Hide
        Sammi SammiChen added a comment -

        Thanks Kai very much for reviewing the patch and commit it !!!

        Show
        Sammi SammiChen added a comment - Thanks Kai very much for reviewing the patch and commit it !!!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10898 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10898/)
        HDFS-10994. Support an XOR policy XOR-2-1-64k in HDFS. Contributed by (kai.zheng: rev 5d5614f847b2ef2a5b70bd9a06edc4eba06174c6)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java
        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicyForReservedContainers.java
        • (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10898 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10898/ ) HDFS-10994 . Support an XOR policy XOR-2-1-64k in HDFS. Contributed by (kai.zheng: rev 5d5614f847b2ef2a5b70bd9a06edc4eba06174c6) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/ErasureCodeConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsConstants.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStream.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedOutputStreamWithFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStreamWithFailure.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedOutputStream.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/monitor/capacity/TestProportionalCapacityPreemptionPolicyForReservedContainers.java (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSXORStripedInputStream.java
        Hide
        drankye Kai Zheng added a comment -

        Added a release note.

        Show
        drankye Kai Zheng added a comment - Added a release note.
        Hide
        drankye Kai Zheng added a comment -

        Committed to trunk. Thanks SammiChen for the contribution!

        Show
        drankye Kai Zheng added a comment - Committed to trunk. Thanks SammiChen for the contribution!
        Hide
        drankye Kai Zheng added a comment -

        Thanks Sammi for the hard work and making it pretty easy to support test of new erasure coding policies.
        +1 on the latest patch.

        Show
        drankye Kai Zheng added a comment - Thanks Sammi for the hard work and making it pretty easy to support test of new erasure coding policies. +1 on the latest patch.
        Hide
        Sammi SammiChen added a comment -

        Double checked two failed test case.
        1. hadoop.fs.TestSymlinkHdfsFileSystem
        First, I run the test locally with latest trunk plus v5 patch, the test case all passed in my local environment. Second, this file is not part of this patch. Also, it doesn't involve striped file.
        2. hadoop.hdfs.server.namenode.TestDecommissioningStatus
        error message is "roblem binding to [localhost:44807] java.net.BindException: Address already in use; "

        With all above observation, I think these 2 test case failure are irrelavent to this patch.

        Show
        Sammi SammiChen added a comment - Double checked two failed test case. 1. hadoop.fs.TestSymlinkHdfsFileSystem First, I run the test locally with latest trunk plus v5 patch, the test case all passed in my local environment. Second, this file is not part of this patch. Also, it doesn't involve striped file. 2. hadoop.hdfs.server.namenode.TestDecommissioningStatus error message is "roblem binding to [localhost:44807] java.net.BindException: Address already in use; " With all above observation, I think these 2 test case failure are irrelavent to this patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        0 mvndep 1m 40s Maven dependency ordering for branch
        +1 mvninstall 6m 54s trunk passed
        +1 compile 9m 45s trunk passed
        +1 checkstyle 1m 35s trunk passed
        +1 mvnsite 2m 43s trunk passed
        +1 mvneclipse 0m 54s trunk passed
        +1 findbugs 5m 58s trunk passed
        +1 javadoc 5m 54s trunk passed
        0 mvndep 0m 40s Maven dependency ordering for patch
        +1 mvninstall 4m 56s the patch passed
        +1 compile 9m 35s the patch passed
        +1 javac 9m 35s the patch passed
        +1 checkstyle 1m 34s root: The patch generated 0 new + 126 unchanged - 6 fixed = 126 total (was 132)
        +1 mvnsite 2m 41s the patch passed
        +1 mvneclipse 0m 51s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 15s the patch passed
        +1 javadoc 2m 0s the patch passed
        +1 unit 7m 43s hadoop-common in the patch passed.
        +1 unit 1m 0s hadoop-hdfs-client in the patch passed.
        -1 unit 75m 8s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        150m 30s



        Reason Tests
        Failed junit tests hadoop.fs.TestSymlinkHdfsFileSystem
          hadoop.hdfs.server.namenode.TestDecommissioningStatus
        Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-10994
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840411/HDFS-10994-v5.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5dfd2a401efb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e15c20e
        Default Java 1.8.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17657/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17657/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17657/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 1m 40s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 9m 45s trunk passed +1 checkstyle 1m 35s trunk passed +1 mvnsite 2m 43s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 5m 58s trunk passed +1 javadoc 5m 54s trunk passed 0 mvndep 0m 40s Maven dependency ordering for patch +1 mvninstall 4m 56s the patch passed +1 compile 9m 35s the patch passed +1 javac 9m 35s the patch passed +1 checkstyle 1m 34s root: The patch generated 0 new + 126 unchanged - 6 fixed = 126 total (was 132) +1 mvnsite 2m 41s the patch passed +1 mvneclipse 0m 51s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 15s the patch passed +1 javadoc 2m 0s the patch passed +1 unit 7m 43s hadoop-common in the patch passed. +1 unit 1m 0s hadoop-hdfs-client in the patch passed. -1 unit 75m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 150m 30s Reason Tests Failed junit tests hadoop.fs.TestSymlinkHdfsFileSystem   hadoop.hdfs.server.namenode.TestDecommissioningStatus Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12840411/HDFS-10994-v5.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5dfd2a401efb 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e15c20e Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17657/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17657/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17657/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sammi SammiChen added a comment -

        Kai offline discussed the path with me, and gave me very good advice. I update the patch per his suggestion.

        Show
        Sammi SammiChen added a comment - Kai offline discussed the path with me, and gave me very good advice. I update the patch per his suggestion.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        0 mvndep 1m 39s Maven dependency ordering for branch
        +1 mvninstall 8m 37s trunk passed
        +1 compile 11m 12s trunk passed
        +1 checkstyle 1m 38s trunk passed
        +1 mvnsite 2m 53s trunk passed
        +1 mvneclipse 0m 56s trunk passed
        +1 findbugs 4m 54s trunk passed
        +1 javadoc 2m 10s trunk passed
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 2m 10s the patch passed
        +1 compile 10m 10s the patch passed
        +1 javac 10m 10s the patch passed
        -0 checkstyle 1m 36s root: The patch generated 33 new + 126 unchanged - 6 fixed = 159 total (was 132)
        +1 mvnsite 2m 57s the patch passed
        +1 mvneclipse 1m 5s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 30s the patch passed
        +1 javadoc 2m 0s the patch passed
        +1 unit 9m 24s hadoop-common in the patch passed.
        +1 unit 1m 6s hadoop-hdfs-client in the patch passed.
        -1 unit 97m 11s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        169m 36s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
          hadoop.hdfs.TestDFSClientRetries



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HDFS-10994
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839954/HDFS-10994-v4.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 46c604c5f479 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6f80742
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17628/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17628/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17628/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17628/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 1m 39s Maven dependency ordering for branch +1 mvninstall 8m 37s trunk passed +1 compile 11m 12s trunk passed +1 checkstyle 1m 38s trunk passed +1 mvnsite 2m 53s trunk passed +1 mvneclipse 0m 56s trunk passed +1 findbugs 4m 54s trunk passed +1 javadoc 2m 10s trunk passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 2m 10s the patch passed +1 compile 10m 10s the patch passed +1 javac 10m 10s the patch passed -0 checkstyle 1m 36s root: The patch generated 33 new + 126 unchanged - 6 fixed = 159 total (was 132) +1 mvnsite 2m 57s the patch passed +1 mvneclipse 1m 5s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 30s the patch passed +1 javadoc 2m 0s the patch passed +1 unit 9m 24s hadoop-common in the patch passed. +1 unit 1m 6s hadoop-hdfs-client in the patch passed. -1 unit 97m 11s hadoop-hdfs in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 169m 36s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR   hadoop.hdfs.TestDFSClientRetries Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HDFS-10994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839954/HDFS-10994-v4.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 46c604c5f479 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6f80742 Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17628/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17628/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17628/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17628/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sammi SammiChen added a comment -

        Rebase patch

        Show
        Sammi SammiChen added a comment - Rebase patch
        Hide
        Sammi SammiChen added a comment -

        Thanks Andrew Wang and Kai Zheng for raising the issue and contributing the thoughts. I have created JIRA HDFS-11152 for it.

        Show
        Sammi SammiChen added a comment - Thanks Andrew Wang and Kai Zheng for raising the issue and contributing the thoughts. I have created JIRA HDFS-11152 for it.
        Hide
        andrew.wang Andrew Wang added a comment -

        SGTM, thanks for raising these issues Kai Zheng. We can add a bunch of Precondition checks for policy == 0 then to validate.

        Show
        andrew.wang Andrew Wang added a comment - SGTM, thanks for raising these issues Kai Zheng . We can add a bunch of Precondition checks for policy == 0 then to validate.
        Hide
        drankye Kai Zheng added a comment -

        Not relevant to the work here, but just raising some questions by the way, looking at the following codes:

           public static final byte RS_6_3_POLICY_ID = 0;
           public static final byte RS_3_2_POLICY_ID = 1;
           public static final byte RS_6_3_LEGACY_POLICY_ID = 2;
        +  public static final byte XOR_2_1_POLICY_ID = 3;
        
        • Suggest we start the POLICY_ID from 1 instead of 0, to avoid some unexpected errors in codes since 0 is default value for integer variables. I had discussed offline with SammiChen about this and the idea sounds good so far.
        • Maybe we can remove related LEGACY_POLICY_ID as Andrew Wang commented elsewhere we don't need to use any legacy policies in HDFS side, though I want to keep the legacy coders in Hadoop side.

        How would you think? Maybe Andrew Wang and Zhe Zhang could also give some comments? Thanks. If sounds good to do these, separate issue would be good.

        Show
        drankye Kai Zheng added a comment - Not relevant to the work here, but just raising some questions by the way, looking at the following codes: public static final byte RS_6_3_POLICY_ID = 0; public static final byte RS_3_2_POLICY_ID = 1; public static final byte RS_6_3_LEGACY_POLICY_ID = 2; + public static final byte XOR_2_1_POLICY_ID = 3; Suggest we start the POLICY_ID from 1 instead of 0, to avoid some unexpected errors in codes since 0 is default value for integer variables. I had discussed offline with SammiChen about this and the idea sounds good so far. Maybe we can remove related LEGACY_POLICY_ID as Andrew Wang commented elsewhere we don't need to use any legacy policies in HDFS side, though I want to keep the legacy coders in Hadoop side. How would you think? Maybe Andrew Wang and Zhe Zhang could also give some comments? Thanks. If sounds good to do these, separate issue would be good.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 49s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 25s Maven dependency ordering for branch
        +1 mvninstall 6m 50s trunk passed
        +1 compile 6m 49s trunk passed
        +1 checkstyle 1m 28s trunk passed
        +1 mvnsite 2m 22s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        +1 findbugs 4m 22s trunk passed
        +1 javadoc 1m 40s trunk passed
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 51s the patch passed
        +1 compile 7m 48s the patch passed
        +1 javac 7m 48s the patch passed
        -0 checkstyle 1m 38s root: The patch generated 27 new + 200 unchanged - 6 fixed = 227 total (was 206)
        +1 mvnsite 2m 41s the patch passed
        +1 mvneclipse 0m 40s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 5m 32s the patch passed
        +1 javadoc 1m 49s the patch passed
        +1 unit 7m 35s hadoop-common in the patch passed.
        +1 unit 0m 57s hadoop-hdfs-client in the patch passed.
        -1 unit 60m 4s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        129m 52s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestMaintenanceState
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.TestRollingUpgrade



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10994
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837051/HDFS-10994-v3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 21fee02a188b 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 69dd5fa
        Default Java 1.8.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17422/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17422/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17422/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17422/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 49s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 25s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 1m 28s trunk passed +1 mvnsite 2m 22s trunk passed +1 mvneclipse 0m 37s trunk passed +1 findbugs 4m 22s trunk passed +1 javadoc 1m 40s trunk passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 51s the patch passed +1 compile 7m 48s the patch passed +1 javac 7m 48s the patch passed -0 checkstyle 1m 38s root: The patch generated 27 new + 200 unchanged - 6 fixed = 227 total (was 206) +1 mvnsite 2m 41s the patch passed +1 mvneclipse 0m 40s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 5m 32s the patch passed +1 javadoc 1m 49s the patch passed +1 unit 7m 35s hadoop-common in the patch passed. +1 unit 0m 57s hadoop-hdfs-client in the patch passed. -1 unit 60m 4s hadoop-hdfs in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 129m 52s Reason Tests Failed junit tests hadoop.hdfs.TestMaintenanceState   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.TestRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837051/HDFS-10994-v3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 21fee02a188b 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 69dd5fa Default Java 1.8.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17422/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17422/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17422/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17422/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sammi SammiChen added a comment -

        1. Rebase the patch against trunk
        2. Fix one style issue

        Show
        Sammi SammiChen added a comment - 1. Rebase the patch against trunk 2. Fix one style issue
        Hide
        Sammi SammiChen added a comment -

        Hi Kai, I have gone through all these check style issues. There are all warning about use "_" in variable name and a private filed must have accessor methods. I think the rule is kind of warning, not the enforcement, given the current existing codes state.

        Show
        Sammi SammiChen added a comment - Hi Kai, I have gone through all these check style issues. There are all warning about use "_" in variable name and a private filed must have accessor methods. I think the rule is kind of warning, not the enforcement, given the current existing codes state.
        Hide
        drankye Kai Zheng added a comment -

        Thanks SammiChen for working on this. Would you fix some of the check styles and rebase the codes?

        Show
        drankye Kai Zheng added a comment - Thanks SammiChen for working on this. Would you fix some of the check styles and rebase the codes?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 15s Maven dependency ordering for branch
        +1 mvninstall 7m 30s trunk passed
        +1 compile 9m 11s trunk passed
        +1 checkstyle 1m 33s trunk passed
        +1 mvnsite 3m 9s trunk passed
        +1 mvneclipse 0m 44s trunk passed
        +1 findbugs 5m 29s trunk passed
        +1 javadoc 1m 42s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 2m 0s the patch passed
        +1 compile 7m 25s the patch passed
        +1 javac 7m 25s the patch passed
        -0 checkstyle 1m 35s root: The patch generated 27 new + 200 unchanged - 9 fixed = 227 total (was 209)
        +1 mvnsite 2m 28s the patch passed
        +1 mvneclipse 0m 43s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 54s the patch passed
        +1 javadoc 1m 49s the patch passed
        +1 unit 8m 29s hadoop-common in the patch passed.
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed.
        +1 unit 80m 4s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        141m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10994
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833356/HDFS-10994-v2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e855ba4682c4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dbe663d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17156/artifact/patchprocess/diff-checkstyle-root.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17156/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17156/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 30s trunk passed +1 compile 9m 11s trunk passed +1 checkstyle 1m 33s trunk passed +1 mvnsite 3m 9s trunk passed +1 mvneclipse 0m 44s trunk passed +1 findbugs 5m 29s trunk passed +1 javadoc 1m 42s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 2m 0s the patch passed +1 compile 7m 25s the patch passed +1 javac 7m 25s the patch passed -0 checkstyle 1m 35s root: The patch generated 27 new + 200 unchanged - 9 fixed = 227 total (was 209) +1 mvnsite 2m 28s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 54s the patch passed +1 javadoc 1m 49s the patch passed +1 unit 8m 29s hadoop-common in the patch passed. +1 unit 0m 58s hadoop-hdfs-client in the patch passed. +1 unit 80m 4s hadoop-hdfs in the patch passed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 141m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833356/HDFS-10994-v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e855ba4682c4 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17156/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17156/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17156/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sammi SammiChen added a comment -

        1. Fixed most of styles issue. The left are filed name pattern violations(can't have '' in filed name while '' in filed name is used everywhere).
        2. Double check the failed test case. They are irrelevant. The failure cause is either port or address already in use.

        Show
        Sammi SammiChen added a comment - 1. Fixed most of styles issue. The left are filed name pattern violations(can't have ' ' in filed name while ' ' in filed name is used everywhere). 2. Double check the failed test case. They are irrelevant. The failure cause is either port or address already in use.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 8 new or modified test files.
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 8m 29s trunk passed
        +1 compile 8m 40s trunk passed
        +1 checkstyle 1m 36s trunk passed
        +1 mvnsite 2m 30s trunk passed
        +1 mvneclipse 0m 40s trunk passed
        +1 findbugs 4m 31s trunk passed
        +1 javadoc 1m 46s trunk passed
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 2m 4s the patch passed
        +1 compile 7m 5s the patch passed
        +1 javac 7m 5s the patch passed
        -0 checkstyle 1m 29s root: The patch generated 39 new + 199 unchanged - 10 fixed = 238 total (was 209)
        +1 mvnsite 2m 19s the patch passed
        +1 mvneclipse 0m 38s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 48s the patch passed
        +1 javadoc 1m 41s the patch passed
        +1 unit 8m 10s hadoop-common in the patch passed.
        +1 unit 0m 56s hadoop-hdfs-client in the patch passed.
        -1 unit 74m 14s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        134m 1s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
          hadoop.hdfs.server.namenode.TestDeleteRace



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10994
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833312/HDFS-10994-v1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 49c2c3eb1b8c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / dbe663d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17151/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17151/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17151/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17151/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 8 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 8m 29s trunk passed +1 compile 8m 40s trunk passed +1 checkstyle 1m 36s trunk passed +1 mvnsite 2m 30s trunk passed +1 mvneclipse 0m 40s trunk passed +1 findbugs 4m 31s trunk passed +1 javadoc 1m 46s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 2m 4s the patch passed +1 compile 7m 5s the patch passed +1 javac 7m 5s the patch passed -0 checkstyle 1m 29s root: The patch generated 39 new + 199 unchanged - 10 fixed = 238 total (was 209) +1 mvnsite 2m 19s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 48s the patch passed +1 javadoc 1m 41s the patch passed +1 unit 8m 10s hadoop-common in the patch passed. +1 unit 0m 56s hadoop-hdfs-client in the patch passed. -1 unit 74m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 134m 1s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.namenode.TestDeleteRace Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10994 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833312/HDFS-10994-v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 49c2c3eb1b8c 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / dbe663d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17151/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17151/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17151/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17151/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sammi SammiChen added a comment -

        Initial patch

        Show
        Sammi SammiChen added a comment - Initial patch

          People

          • Assignee:
            Sammi SammiChen
            Reporter:
            Sammi SammiChen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development