Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10944

Correct the javadoc of dfsadmin#disallowSnapshot

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      in DFSadmin.java ,the javadoc for Disallow snapshot is not proper

       /**
         * Allow snapshot on a directory.
         * Usage: hdfs dfsadmin -disallowSnapshot snapshotDir
         * @param argv List of of command line parameters.
         * @exception IOException
         */
      

      Change the Allow Snapshot to Disallow Snapshot

      1. HDFS-10944_00.patch
        0.8 kB
        Jagadesh Kiran N

        Activity

        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Uploading the patch after modification

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Uploading the patch after modification
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 24s trunk passed
        +1 compile 0m 56s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 0m 57s trunk passed
        +1 mvninstall 0m 55s the patch passed
        +1 compile 0m 50s the patch passed
        +1 javac 0m 50s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 1m 2s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 11s the patch passed
        +1 javadoc 0m 58s the patch passed
        -1 unit 64m 36s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        87m 20s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10944
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831319/HDFS-10944_00.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7274e3bee701 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6e130c3
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16977/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16977/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 24s trunk passed +1 compile 0m 56s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 0m 57s trunk passed +1 mvninstall 0m 55s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 11s the patch passed +1 javadoc 0m 58s the patch passed -1 unit 64m 36s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 87m 20s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10944 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831319/HDFS-10944_00.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7274e3bee701 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6e130c3 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16977/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16977/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16977/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment - - edited

        Unit Test Failures are not related to Patch, please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - - edited Unit Test Failures are not related to Patch, please review
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        +1, will commit shortly.

        Show
        brahmareddy Brahma Reddy Battula added a comment - +1, will commit shortly.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Committed to trunk,branch-2 and branch-2.8. Thanks Jagadesh Kiran N for your contribution.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Committed to trunk,branch-2 and branch-2.8. Thanks Jagadesh Kiran N for your contribution.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10538 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10538/)
        HDFS-10944. Correct the javadoc of dfsadmin#disallowSnapshot. (brahma: rev 5ea0210c7fea1324973e7f69256bc53f31ee4cf7)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10538 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10538/ ) HDFS-10944 . Correct the javadoc of dfsadmin#disallowSnapshot. (brahma: rev 5ea0210c7fea1324973e7f69256bc53f31ee4cf7) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Brahma Reddy Battula for commiting the same .,

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Brahma Reddy Battula for commiting the same .,

          People

          • Assignee:
            jagadesh.kiran Jagadesh Kiran N
            Reporter:
            jagadesh.kiran Jagadesh Kiran N
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development