Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: hdfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The encryption zone APIs should be optimized to extensively use IIPs to eliminate path resolutions. The performance penalties incurred by common operations like creation of file statuses may be reduced by more extensive short-circuiting of EZ lookups when no EZs exist. All file creates should not be subjected to the multi-stage locking performance penalty required only for EDEK generation.

      1. HDFS-10939.patch
        42 kB
        Daryn Sharp
      2. HDFS-10939.1.patch
        47 kB
        Daryn Sharp
      3. HDFS-10939.2.patch
        46 kB
        Daryn Sharp
      4. HDFS-10939.branch-2.patch
        44 kB
        Daryn Sharp

        Activity

        Hide
        kihwal Kihwal Lee added a comment -

        Committed to branch-2 and branch-2.8 as well.

        Show
        kihwal Kihwal Lee added a comment - Committed to branch-2 and branch-2.8 as well.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 21s branch-2 passed
        +1 compile 0m 46s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 48s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 32s branch-2 passed
        +1 mvnsite 0m 52s branch-2 passed
        +1 mvneclipse 0m 15s branch-2 passed
        +1 findbugs 2m 1s branch-2 passed
        +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 53s the patch passed
        +1 compile 0m 57s the patch passed with JDK v1.8.0_101
        +1 javac 0m 57s the patch passed
        +1 compile 0m 43s the patch passed with JDK v1.7.0_111
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 403 unchanged - 10 fixed = 411 total (was 413)
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 13s the patch passed
        +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 35s the patch passed with JDK v1.7.0_111
        +1 unit 48m 54s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        128m 51s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10939
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832140/HDFS-10939.branch-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 75fdfa1b65b3 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 8bee319
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17057/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17057/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17057/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 21s branch-2 passed +1 compile 0m 46s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 48s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 32s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 2m 1s branch-2 passed +1 javadoc 0m 58s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 37s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 53s the patch passed +1 compile 0m 57s the patch passed with JDK v1.8.0_101 +1 javac 0m 57s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_111 +1 javac 0m 43s the patch passed -0 checkstyle 0m 30s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 403 unchanged - 10 fixed = 411 total (was 413) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_111 +1 unit 48m 54s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 128m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10939 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832140/HDFS-10939.branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 75fdfa1b65b3 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 8bee319 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17057/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17057/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17057/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        For branch-2. Just had to resolve lack of EC, and minor indirect changes made by EC on trunk.

        Show
        daryn Daryn Sharp added a comment - For branch-2. Just had to resolve lack of EC, and minor indirect changes made by EC on trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10560 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10560/)
        HDFS-10939. Reduce performance penalty of encryption zones. Contributed (kihwal: rev f32e9fc8f7150f0e889c0774b3ad712af26fbd65)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/XAttrStorage.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionFaultInjector.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10560 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10560/ ) HDFS-10939 . Reduce performance penalty of encryption zones. Contributed (kihwal: rev f32e9fc8f7150f0e889c0774b3ad712af26fbd65) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/XAttrStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirEncryptionZoneOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirWriteFileOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionFaultInjector.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirErasureCodingOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
        Hide
        kihwal Kihwal Lee added a comment -

        Committed it to trunk, but branch-2 merge is not clean. The conflicts are mostly from EC-related context differences, but code moves make some of these beyond simple merge conflict resolution. Please provide a branch-2 patch.

        Show
        kihwal Kihwal Lee added a comment - Committed it to trunk, but branch-2 merge is not clean. The conflicts are mostly from EC-related context differences, but code moves make some of these beyond simple merge conflict resolution. Please provide a branch-2 patch.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 the new patch looks good.

        Show
        kihwal Kihwal Lee added a comment - +1 the new patch looks good.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 49s trunk passed
        +1 compile 0m 47s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 46s trunk passed
        +1 javadoc 1m 0s trunk passed
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 48s the patch passed
        +1 javac 0m 48s the patch passed
        -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 407 unchanged - 9 fixed = 415 total (was 416)
        +1 mvnsite 0m 55s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 58s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 64m 34s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        85m 34s



        Reason Tests
        Failed junit tests hadoop.tracing.TestTracing



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10939
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832003/HDFS-10939.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f043c367c711 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2d46c3f
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17047/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17047/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17047/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17047/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 49s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 1m 0s trunk passed +1 mvninstall 0m 51s the patch passed +1 compile 0m 48s the patch passed +1 javac 0m 48s the patch passed -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 8 new + 407 unchanged - 9 fixed = 415 total (was 416) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 64m 34s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 85m 34s Reason Tests Failed junit tests hadoop.tracing.TestTracing Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10939 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832003/HDFS-10939.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f043c367c711 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2d46c3f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17047/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17047/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17047/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17047/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        Address kihwal's comments. Had to add another fault injector method to keep the implementation details encapsulated in a single method.

        Show
        daryn Daryn Sharp added a comment - Address kihwal's comments. Had to add another fault injector method to keep the implementation details encapsulated in a single method.
        Hide
        daryn Daryn Sharp added a comment -

        Agreed, I wasn't very fond of the locking asymmetry. Original implementation was similar to your suggestion of relock in the finally but didn't like relocking/unlocking on failure. You're right that errors should be a rare case. Will update patch.

        Show
        daryn Daryn Sharp added a comment - Agreed, I wasn't very fond of the locking asymmetry. Original implementation was similar to your suggestion of relock in the finally but didn't like relocking/unlocking on failure. You're right that errors should be a rare case. Will update patch.
        Hide
        kihwal Kihwal Lee added a comment -

        In startFileInt(), unlock() is done in getEncryptionKeyInfo() and it is reacquired in startFileInt(). Is this asymmetry necessary? It looks like getEncryptionKeyInfo() is supposed to be called with the write lock anyway. Wouldn't it make more sense to make it reacquire the lock in its finally block? Sure, it might incur extra lock-unlock if something fails: If generateEncryptedDataEncryptionKey() fails, the lock will be reacquired from getEncryptionKeyInfo(). Then release immediately in the finally block of startFileInt(). Still I think it is better to organize locking this way at the price of extra locking on rare failure cases. Correctness wise, the patch seems fine.

        Show
        kihwal Kihwal Lee added a comment - In startFileInt() , unlock() is done in getEncryptionKeyInfo() and it is reacquired in startFileInt() . Is this asymmetry necessary? It looks like getEncryptionKeyInfo() is supposed to be called with the write lock anyway. Wouldn't it make more sense to make it reacquire the lock in its finally block? Sure, it might incur extra lock-unlock if something fails: If generateEncryptedDataEncryptionKey() fails, the lock will be reacquired from getEncryptionKeyInfo() . Then release immediately in the finally block of startFileInt() . Still I think it is better to organize locking this way at the price of extra locking on rare failure cases. Correctness wise, the patch seems fine.
        Hide
        daryn Daryn Sharp added a comment -

        Test failures unrelated to patch. I know a coworker is working on the race condition in the settimes test.

        Show
        daryn Daryn Sharp added a comment - Test failures unrelated to patch. I know a coworker is working on the race condition in the settimes test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 29s trunk passed
        +1 compile 0m 53s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 0m 56s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 52s trunk passed
        +1 javadoc 0m 59s trunk passed
        +1 mvninstall 0m 57s the patch passed
        +1 compile 0m 53s the patch passed
        +1 javac 0m 53s the patch passed
        -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 408 unchanged - 8 fixed = 418 total (was 416)
        +1 mvnsite 1m 4s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 0m 58s the patch passed
        -1 unit 72m 46s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        95m 43s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSShell
        Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10939
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831408/HDFS-10939.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a0f56aebb3c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 736d33c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16986/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16986/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16986/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16986/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 29s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 52s trunk passed +1 javadoc 0m 59s trunk passed +1 mvninstall 0m 57s the patch passed +1 compile 0m 53s the patch passed +1 javac 0m 53s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 10 new + 408 unchanged - 8 fixed = 418 total (was 416) +1 mvnsite 1m 4s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 9s the patch passed +1 javadoc 0m 58s the patch passed -1 unit 72m 46s hadoop-hdfs in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 95m 43s Reason Tests Failed junit tests hadoop.hdfs.TestDFSShell Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10939 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831408/HDFS-10939.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a0f56aebb3c0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 736d33c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16986/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16986/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16986/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16986/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        Updated due to conflict with getfileinfo changes. Updated tests to verify if lock is held or yielded.

        Show
        daryn Daryn Sharp added a comment - Updated due to conflict with getfileinfo changes. Updated tests to verify if lock is held or yielded.
        Hide
        kihwal Kihwal Lee added a comment -

        Please rebase your patch.

        Show
        kihwal Kihwal Lee added a comment - Please rebase your patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HDFS-10939 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-10939
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831165/HDFS-10939.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16952/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-10939 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-10939 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831165/HDFS-10939.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16952/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        Full use of IIP in EncryptionZoneManager and FsDirEncryptionZoneOp required a few minor IIP xattr api changes with a small ripple into other classes.

        Main changes are:

        1. a few more shorts via hasCreatedEncryptionZone()
        2. moved EZ specific code from FsDirWriteFileOp into FsDirEncryptionZoneOp
        3. significantly cleaned up startFile method
        4. forced multi-stage locking is removed. Instead of read lock, resolve, pre-conditions, read unlock, may generate EDEK, write lock, resolve, pre-conditions, do create; it's now write lock, resolve, pre-conditions, (iff need EDEK: write unlock, generate EDEK, write lock, re-resolve, pre-conditions), do create
        5. don't allocate BlocksMapUpdateInfo until just before needed so failed creates don't waste allocations
        6. tweaked how skipSync is set to avoid nothing to sync logging in some cases
        Show
        daryn Daryn Sharp added a comment - Full use of IIP in EncryptionZoneManager and FsDirEncryptionZoneOp required a few minor IIP xattr api changes with a small ripple into other classes. Main changes are: a few more shorts via hasCreatedEncryptionZone() moved EZ specific code from FsDirWriteFileOp into FsDirEncryptionZoneOp significantly cleaned up startFile method forced multi-stage locking is removed. Instead of read lock, resolve, pre-conditions, read unlock, may generate EDEK, write lock, resolve, pre-conditions, do create; it's now write lock, resolve, pre-conditions, (iff need EDEK: write unlock, generate EDEK, write lock, re-resolve, pre-conditions), do create don't allocate BlocksMapUpdateInfo until just before needed so failed creates don't waste allocations tweaked how skipSync is set to avoid nothing to sync logging in some cases

          People

          • Assignee:
            daryn Daryn Sharp
            Reporter:
            daryn Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development