Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      TestFsck should be refactored.

      • use @Before @After annotations
      • improve loggings
      • fix checkstyle warnings
        etc.
      1. HDFS-10933.WIP.1.patch
        29 kB
        Takanobu Asanuma
      2. HDFS-10933.branch-2.001.patch
        103 kB
        Takanobu Asanuma
      3. HDFS-10933.3.patch
        125 kB
        Takanobu Asanuma
      4. HDFS-10933.2.patch
        123 kB
        Takanobu Asanuma
      5. HDFS-10933.1.patch
        110 kB
        Takanobu Asanuma

        Activity

        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        Thank you for your help and committing, Wei-Chiu Chuang!

        Show
        tasanuma0829 Takanobu Asanuma added a comment - Thank you for your help and committing, Wei-Chiu Chuang !
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed to branch-2 and branch-2.8 (with minor conflict). Thanks again Takanobu Asanuma for your contribution!

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed to branch-2 and branch-2.8 (with minor conflict). Thanks again Takanobu Asanuma for your contribution!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 49s branch-2 passed
        +1 compile 0m 40s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 32s branch-2 passed
        +1 mvnsite 0m 51s branch-2 passed
        +1 mvneclipse 0m 16s branch-2 passed
        +1 findbugs 1m 58s branch-2 passed
        +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 34s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 43s the patch passed
        +1 compile 0m 35s the patch passed with JDK v1.8.0_101
        +1 javac 0m 35s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_111
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 255 fixed = 0 total (was 255)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 5s the patch passed
        +1 javadoc 0m 53s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 32s the patch passed with JDK v1.7.0_111
        -1 unit 73m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        160m 58s



        Reason Tests
        JDK v1.8.0_101 Failed junit tests hadoop.hdfs.tools.TestDFSAdmin
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestFileCreationDelete



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10933
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832621/HDFS-10933.branch-2.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c8d2b3fb7831 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / dc5f7a9
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17098/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17098/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17098/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 49s branch-2 passed +1 compile 0m 40s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 32s branch-2 passed +1 mvnsite 0m 51s branch-2 passed +1 mvneclipse 0m 16s branch-2 passed +1 findbugs 1m 58s branch-2 passed +1 javadoc 0m 54s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 34s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 43s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_101 +1 javac 0m 35s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_111 +1 javac 0m 40s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 255 fixed = 0 total (was 255) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 32s the patch passed with JDK v1.7.0_111 -1 unit 73m 58s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 160m 58s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.tools.TestDFSAdmin JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestFileCreationDelete Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832621/HDFS-10933.branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c8d2b3fb7831 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / dc5f7a9 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17098/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17098/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17098/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        I have just uploaded a new patch for branch-2.

        Show
        tasanuma0829 Takanobu Asanuma added a comment - I have just uploaded a new patch for branch-2.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        Thank you for reviewing and committing, Wei-Chiu Chuang! I will create a branch-2 patch soon.

        Show
        tasanuma0829 Takanobu Asanuma added a comment - Thank you for reviewing and committing, Wei-Chiu Chuang ! I will create a branch-2 patch soon.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10566/)
        HDFS-10933. Refactor TestFsck. Contributed by Takanobu Asanuma. (weichiu: rev 3059b251d8f37456c5761ecaf73fe6c0c5a59067)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10566 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10566/ ) HDFS-10933 . Refactor TestFsck. Contributed by Takanobu Asanuma. (weichiu: rev 3059b251d8f37456c5761ecaf73fe6c0c5a59067) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFsck.java
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committed it to trunk. The branch-2 has quite a number of conflicts. Would you mind to post a branch-2 patch? Takanobu Asanuma thanks very much.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committed it to trunk. The branch-2 has quite a number of conflicts. Would you mind to post a branch-2 patch? Takanobu Asanuma thanks very much.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Committing the 3rd patch.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Committing the 3rd patch.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        +1

        Show
        jojochuang Wei-Chiu Chuang added a comment - +1
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 40s trunk passed
        +1 javadoc 0m 40s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 277 fixed = 0 total (was 277)
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 37s the patch passed
        +1 unit 61m 51s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        80m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10933
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832114/HDFS-10933.3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a222c148f56c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bf37217
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17055/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17055/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 40s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 277 fixed = 0 total (was 277) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 37s the patch passed +1 unit 61m 51s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 80m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832114/HDFS-10933.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a222c148f56c 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf37217 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17055/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17055/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        I updated the patch.

        Show
        tasanuma0829 Takanobu Asanuma added a comment - I updated the patch.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        Wei-Chiu Chuang
        Sorry, I wrote this comment before I read last your comment. Thanks for your review!

        Show
        tasanuma0829 Takanobu Asanuma added a comment - Wei-Chiu Chuang Sorry, I wrote this comment before I read last your comment. Thanks for your review!
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        Perhaps the first patch is better to avoid confusion.

        Show
        tasanuma0829 Takanobu Asanuma added a comment - Perhaps the first patch is better to avoid confusion.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Thanks a lot for working on this, Takanobu Asanuma. I took a quick look and I think it's mostly good. A few nits:

        • I think you can also initialize the conf object in an @Before method.
        • A few methods calls shutdownCluster(); at the end. This is not needed.
        Show
        jojochuang Wei-Chiu Chuang added a comment - Thanks a lot for working on this, Takanobu Asanuma . I took a quick look and I think it's mostly good. A few nits: I think you can also initialize the conf object in an @Before method. A few methods calls shutdownCluster(); at the end. This is not needed.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 0s trunk passed
        +1 compile 0m 59s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 44s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 277 fixed = 0 total (was 277)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 55s the patch passed
        +1 unit 63m 6s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        83m 51s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10933
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831934/HDFS-10933.2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1b74569264f5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 272a217
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17044/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17044/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 0s trunk passed +1 compile 0m 59s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 0 unchanged - 277 fixed = 0 total (was 277) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 55s the patch passed +1 unit 63m 6s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 83m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831934/HDFS-10933.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1b74569264f5 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 272a217 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17044/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17044/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        I updated the patch. It fixes all checkstyle warnings.

        Show
        tasanuma0829 Takanobu Asanuma added a comment - I updated the patch. It fixes all checkstyle warnings.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 55s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 15 new + 66 unchanged - 211 fixed = 81 total (was 277)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 53s the patch passed
        +1 unit 58m 19s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        77m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10933
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831910/HDFS-10933.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2931c3caac30 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 272a217
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17043/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17043/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17043/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 55s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 15 new + 66 unchanged - 211 fixed = 81 total (was 277) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 58m 19s hadoop-hdfs in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 77m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10933 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831910/HDFS-10933.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2931c3caac30 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 272a217 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17043/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17043/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17043/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        tasanuma0829 Takanobu Asanuma added a comment -

        I uploaded initial patches based on Wei-Chiu Chuang's advice in HDFS-10826.

        • make a common variable of MiniDFSCluster and use @After annotation to shutdown it.
        • remove all FileSystem.close since MiniDFSCluster.shutdown closes FileSystem.
        • remove unnecessary try statements.
        • use LogFactory instead of using FSImage.LOG.

        HDFS-10933.WIP.1.patch doesn't arrange indents so that it is easy to be reviewed. HDFS-10933.1.patch fixes them on top of the WIP patch.

        Please review it when you are fee. Thanks!

        Show
        tasanuma0829 Takanobu Asanuma added a comment - I uploaded initial patches based on Wei-Chiu Chuang 's advice in HDFS-10826 . make a common variable of MiniDFSCluster and use @After annotation to shutdown it. remove all FileSystem.close since MiniDFSCluster.shutdown closes FileSystem . remove unnecessary try statements. use LogFactory instead of using FSImage.LOG. HDFS-10933 .WIP.1.patch doesn't arrange indents so that it is easy to be reviewed. HDFS-10933 .1.patch fixes them on top of the WIP patch. Please review it when you are fee. Thanks!

          People

          • Assignee:
            tasanuma0829 Takanobu Asanuma
            Reporter:
            tasanuma0829 Takanobu Asanuma
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development