Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: documentation
    • Labels:
      None

      Description

      Now the documemnts of the command hdfs diskbalancer -report look not completed. Two minors:

      • The usage of hdfs diskbalancer -report is missing in HDFSCommands.md
      • One subcommand of report command hdfs diskbalancer -report -top is missing in HDFSDiskBalancer.md

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a simple patch to make a quick fix.

        Show
        linyiqun Yiqun Lin added a comment - Attach a simple patch to make a quick fix.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        +1 mvninstall 6m 56s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvnsite 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        9m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10900
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830216/HDFS-10900.001.patch
        Optional Tests asflicense mvnsite
        uname Linux 3b741b239829 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 3e37e24
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16857/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. +1 mvninstall 6m 56s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvnsite 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 9m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10900 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830216/HDFS-10900.001.patch Optional Tests asflicense mvnsite uname Linux 3b741b239829 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3e37e24 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16857/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        anu Anu Engineer added a comment -

        I was about to commit this, and I noticed that hadoop documentation rendering is broken in Alpha-2. I will commit this, but after filing another JIRA.

        Show
        anu Anu Engineer added a comment - I was about to commit this, and I noticed that hadoop documentation rendering is broken in Alpha-2. I will commit this, but after filing another JIRA.
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Thanks Anu Engineer for the review. One comment from me:

        I will commit this, but after filing another JIRA.

        What's the meaning of this? Does it means that I should crate another JIRA and upload the same patch in this JIRA? Can make a more concrete explainaton?

        Show
        linyiqun Yiqun Lin added a comment - - edited Thanks Anu Engineer for the review. One comment from me: I will commit this, but after filing another JIRA. What's the meaning of this? Does it means that I should crate another JIRA and upload the same patch in this JIRA? Can make a more concrete explainaton?
        Hide
        anu Anu Engineer added a comment - - edited

        My sincere apologies my comment was so cryptic.

        There was a checkin in the tree that changed the Apache Logo. This has broken the whole site rendering. I applied you patch and was testing it and noticed that it was broken completely. I wanted to file a separate JIRA for that issue before I commit this code.

        Please note: This has nothing to do with your change, that I why I mentioned that I will check that in later. Without being able to render the page correctly, I have no way of verifying your change. So I am holding off on committing this. We will either backout the change in trunk (the logo change) or someone with right CSS skills will fix it. I would like to commit your changes after that.

        To see this issue yourself , you might want to run

        1. mvn site:site
        2. mvn site:stage -DstagingDirectory=/tmp/mysite
        3. open /tmp/mysite/hadoop-project/index.html

        Then browse around the pages – especially the hadoop commands and HDFSDiskBalancer page. Again I am +1 on this change, but I want to commit when the code base is in a better shape.

        Show
        anu Anu Engineer added a comment - - edited My sincere apologies my comment was so cryptic. There was a checkin in the tree that changed the Apache Logo. This has broken the whole site rendering. I applied you patch and was testing it and noticed that it was broken completely. I wanted to file a separate JIRA for that issue before I commit this code. Please note: This has nothing to do with your change, that I why I mentioned that I will check that in later. Without being able to render the page correctly, I have no way of verifying your change. So I am holding off on committing this. We will either backout the change in trunk (the logo change) or someone with right CSS skills will fix it. I would like to commit your changes after that. To see this issue yourself , you might want to run mvn site:site mvn site:stage -DstagingDirectory=/tmp/mysite open /tmp/mysite/hadoop-project/index.html Then browse around the pages – especially the hadoop commands and HDFSDiskBalancer page. Again I am +1 on this change, but I want to commit when the code base is in a better shape.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Anu Engineer for the patient explaination. It seems the hadoop documents rendering has been modified. I just take a look for the hadoop page(http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsSnapshots.html), it seems ok now.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Anu Engineer for the patient explaination. It seems the hadoop documents rendering has been modified. I just take a look for the hadoop page( http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsSnapshots.html ), it seems ok now.
        Hide
        anu Anu Engineer added a comment -

        Yiqun Lin Thank you the contribution. I have committed this to trunk.

        Show
        anu Anu Engineer added a comment - Yiqun Lin Thank you the contribution. I have committed this to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10503 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10503/)
        HDFS-10900. DiskBalancer: Complete the documents for the report command. (aengineer: rev 9c9736463b2b30350c78fce4fa0d56c73280d0ff)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSDiskbalancer.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10503 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10503/ ) HDFS-10900 . DiskBalancer: Complete the documents for the report command. (aengineer: rev 9c9736463b2b30350c78fce4fa0d56c73280d0ff) (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSCommands.md (edit) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSDiskbalancer.md

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            linyiqun Yiqun Lin
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development