Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10475 Adding metrics for long FSNamesystem read and write locks
  3. HDFS-10896

Move lock logging logic from FSNamesystem into FSNamesystemLock

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      There are a number of tickets (HDFS-10742, HDFS-10817, HDFS-10713, this subtask's story HDFS-10475) which are adding/improving logging/metrics around the FSNamesystemLock. All of this is done in FSNamesystem right now, which is polluting the namesystem with ThreadLocal variables, timing counters, etc. which are only relevant to the lock itself and the number of these increases as the logging/metrics become more sophisticated. It would be best to move these all into FSNamesystemLock to keep the metrics/logging tied directly to the item of interest.

      Attachments

        1. HDFS-10896.000.patch
          33 kB
          Erik Krogen
        2. HDFS-10896.001.patch
          32 kB
          Erik Krogen
        3. HDFS-10896.002.patch
          45 kB
          Erik Krogen
        4. HDFS-10896.003.patch
          45 kB
          Erik Krogen
        5. HDFS-10896.004.patch
          43 kB
          Erik Krogen
        6. HDFS-10896-branch-2.7.004.patch
          44 kB
          Erik Krogen

        Issue Links

          Activity

            People

              xkrogen Erik Krogen
              xkrogen Erik Krogen
              Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: