Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10856

Update the comment of BPServiceActor$Scheduler#scheduleNextBlockReport

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Now the interval is 6 hours by default.

      BPServiceActor$Scheduler#scheduleNextBlockReport
              /* say the last block report was at 8:20:14. The current report
               * should have started around 9:20:14 (default 1 hour interval).
               * If current time is :
               *   1) normal like 9:20:18, next report should be at 10:20:14
               *   2) unexpected like 11:35:43, next report should be at 12:20:14
               */
              nextBlockReportTime +=
                    (((monotonicNow() - nextBlockReportTime + blockReportIntervalMs) /
                        blockReportIntervalMs)) * blockReportIntervalMs;
      

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the commit, I will attach a patch for HADOOP-13598 soon.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the commit, I will attach a patch for HADOOP-13598 soon.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        This should be done in a separate jira.

        +1 for this, it will make users avoid these error when they creating patches.

        Filed HADOOP-13598.

        Show
        ajisakaa Akira Ajisaka added a comment - This should be done in a separate jira. +1 for this, it will make users avoid these error when they creating patches. Filed HADOOP-13598 .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10431/)
        HDFS-10856. Update the comment of (aajisaka: rev f0876b8b60c19aa25e0417ac0f419a3a82bf210b)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10431 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10431/ ) HDFS-10856 . Update the comment of (aajisaka: rev f0876b8b60c19aa25e0417ac0f419a3a82bf210b) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1. The test failure is unrelated.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1. The test failure is unrelated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 55s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 45s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 43s the patch passed
        +1 javac 0m 43s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 57s the patch passed
        -1 unit 78m 16s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        99m 2s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10856
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828159/HDFS-10856.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8798f86532bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 72dfb04
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16728/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16728/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 55s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 57s the patch passed -1 unit 78m 16s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 99m 2s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10856 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828159/HDFS-10856.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8798f86532bb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72dfb04 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16728/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16728/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16728/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the suggestions.

        I'm thinking we should add eol=lf in the following lines to avoid such error

        You are right. By default way, I creat a patch in windows, it will print the following warning:

        warning: LF will be replaced by CRLF in .../BPServiceActor.java
        

        This should be done in a separate jira.

        +1 for this, it will make users avoid these error when they creating patches.

        I had make a change *.java text diff=java eof=lf? And then I did the dos2unix command for the output patch file. Hope my latest patch will be successful, .

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the suggestions. I'm thinking we should add eol=lf in the following lines to avoid such error You are right. By default way, I creat a patch in windows, it will print the following warning: warning: LF will be replaced by CRLF in .../BPServiceActor.java This should be done in a separate jira. +1 for this, it will make users avoid these error when they creating patches. I had make a change *.java text diff=java eof=lf ? And then I did the dos2unix command for the output patch file. Hope my latest patch will be successful, .
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm thinking we should add eol=lf in the following lines to avoid such error.

        .gitattributes
        *.cs     text diff=csharp
        *.java   text diff=java
        *.html   text diff=html
        *.py     text diff=python
        *.pl     text diff=perl
        *.pm     text diff=perl
        *.css    text
        *.js     text
        *.sql    text
        

        This should be done in a separate jira.

        Show
        ajisakaa Akira Ajisaka added a comment - I'm thinking we should add eol=lf in the following lines to avoid such error. .gitattributes *.cs text diff=csharp *.java text diff=java *.html text diff=html *.py text diff=python *.pl text diff=perl *.pm text diff=perl *.css text *.js text *.sql text This should be done in a separate jira.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Okay, would you use LF instead of CR+LF in eol?

        Show
        ajisakaa Akira Ajisaka added a comment - Okay, would you use LF instead of CR+LF in eol?
        Hide
        linyiqun Yiqun Lin added a comment - - edited

        Sorry, Akira Ajisaka, it seems that the v001 patch still can't been merged even though I have been updated the codes. I think there was something error when I make a git diff in windows(since that it's my first time to create a patch in windows ). I will post a correct patch soon.

        Show
        linyiqun Yiqun Lin added a comment - - edited Sorry, Akira Ajisaka , it seems that the v001 patch still can't been merged even though I have been updated the codes. I think there was something error when I make a git diff in windows(since that it's my first time to create a patch in windows ). I will post a correct patch soon.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 7s HDFS-10856 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-10856
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828051/HDFS-10856.001.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16708/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HDFS-10856 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-10856 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828051/HDFS-10856.001.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16708/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Reupload the v001 patch.

        Show
        linyiqun Yiqun Lin added a comment - Reupload the v001 patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Your patch looks good. Would you rebase it?

        Show
        ajisakaa Akira Ajisaka added a comment - Your patch looks good. Would you rebase it?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HDFS-10856 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-10856
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828027/HDFS-10856.001.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16707/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-10856 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-10856 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828027/HDFS-10856.001.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16707/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        Attach a simple patch for make a change. Let me know if my change is looks good to you, Akira Ajisaka, thanks.

        Show
        linyiqun Yiqun Lin added a comment - Attach a simple patch for make a change. Let me know if my change is looks good to you, Akira Ajisaka , thanks.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development