Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: hdfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Path strings should be resolved once into INodesInPath. The IIP should be used extensively from that point forward.

      1. HDFS-10851.1.patch
        29 kB
        Daryn Sharp
      2. HDFS-10851.branch-2.patch
        29 kB
        Daryn Sharp
      3. HDFS-10851.patch
        28 kB
        Daryn Sharp

        Activity

        Hide
        daryn Daryn Sharp added a comment -

        Passes IIP around instead of re-resolving or extracting and passing the values in the IIP. Streamlined the file status creation. Pushed down common logic, like inode attr lookup, to a single place.

        Show
        daryn Daryn Sharp added a comment - Passes IIP around instead of re-resolving or extracting and passing the values in the IIP. Streamlined the file status creation. Pushed down common logic, like inode attr lookup, to a single place.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 25s trunk passed
        +1 compile 0m 54s trunk passed
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 18s trunk passed
        +1 javadoc 1m 5s trunk passed
        +1 mvninstall 0m 52s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 16 fixed = 180 total (was 194)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 53s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 59s the patch passed
        +1 unit 76m 20s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        99m 1s



        Reason Tests
        FindBugs module:hadoop-hdfs-project/hadoop-hdfs
          Dead store to src in org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getListingInt(FSDirectory, String, byte[], boolean) At FSDirStatAndListingOp.java:org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getListingInt(FSDirectory, String, byte[], boolean) At FSDirStatAndListingOp.java:[line 62]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10851
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827833/HDFS-10851.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 526824f1af67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cba973f
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16692/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16692/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16692/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16692/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 25s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 18s trunk passed +1 javadoc 1m 5s trunk passed +1 mvninstall 0m 52s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 16 fixed = 180 total (was 194) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 53s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 59s the patch passed +1 unit 76m 20s hadoop-hdfs in the patch passed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 99m 1s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Dead store to src in org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getListingInt(FSDirectory, String, byte[], boolean) At FSDirStatAndListingOp.java:org.apache.hadoop.hdfs.server.namenode.FSDirStatAndListingOp.getListingInt(FSDirectory, String, byte[], boolean) At FSDirStatAndListingOp.java: [line 62] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10851 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827833/HDFS-10851.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 526824f1af67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cba973f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16692/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16692/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16692/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16692/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        Removed dead assignment flagged by findbugs.

        Show
        daryn Daryn Sharp added a comment - Removed dead assignment flagged by findbugs.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 10s trunk passed
        +1 compile 0m 46s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 44s trunk passed
        +1 javadoc 0m 56s trunk passed
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 16 fixed = 180 total (was 194)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 53s the patch passed
        -1 unit 60m 7s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        79m 53s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestMaintenanceState
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10851
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830354/HDFS-10851.1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 964bf56b6f56 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4815d02
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16863/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16863/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16863/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 10s trunk passed +1 compile 0m 46s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 56s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 16 fixed = 180 total (was 194) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed -1 unit 60m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 79m 53s Reason Tests Failed junit tests hadoop.hdfs.TestMaintenanceState   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10851 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12830354/HDFS-10851.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 964bf56b6f56 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4815d02 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16863/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16863/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16863/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16863/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        daryn Daryn Sharp added a comment -

        The tests pass for me. One was address already in use, lazy persist one completely unrelated.

        Show
        daryn Daryn Sharp added a comment - The tests pass for me. One was address already in use, lazy persist one completely unrelated.
        Hide
        kihwal Kihwal Lee added a comment -

        Other than the IIP/src optimizations, I see nice clean-ups and clarifications. Especially the change from isSuperUser to includeStoragePolicy in getListing() is nice. +1.

        Show
        kihwal Kihwal Lee added a comment - Other than the IIP/src optimizations, I see nice clean-ups and clarifications. Especially the change from isSuperUser to includeStoragePolicy in getListing() is nice. +1.
        Hide
        kihwal Kihwal Lee added a comment -

        Committed to trunk, but it does not apply to branch-2.

        Show
        kihwal Kihwal Lee added a comment - Committed to trunk, but it does not apply to branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10519 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10519/)
        HDFS-10851. FSDirStatAndListingOp: stop passing path as string. (kihwal: rev a0730aa5ced7666a8c92f9fb830b615f5f9f477a)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAclOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodesInPath.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributeProvider.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10519 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10519/ ) HDFS-10851 . FSDirStatAndListingOp: stop passing path as string. (kihwal: rev a0730aa5ced7666a8c92f9fb830b615f5f9f477a) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAclOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirStatAndListingOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodesInPath.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeAttributeProvider.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestSnapshotPathINodes.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirXAttrOp.java
        Hide
        daryn Daryn Sharp added a comment -

        Just had to remove a few references to EC policy.

        Show
        daryn Daryn Sharp added a comment - Just had to remove a few references to EC policy.
        Hide
        kihwal Kihwal Lee added a comment -

        The branch-2 patch looks good. The only difference is the ecPolicy parameter that does not exit in branch-2.

        Show
        kihwal Kihwal Lee added a comment - The branch-2 patch looks good. The only difference is the ecPolicy parameter that does not exit in branch-2.
        Hide
        kihwal Kihwal Lee added a comment -

        Committed to trunk, branch-2 and branch-2.8.

        Show
        kihwal Kihwal Lee added a comment - Committed to trunk, branch-2 and branch-2.8.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 6s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 59s branch-2 passed
        +1 compile 0m 43s branch-2 passed with JDK v1.8.0_101
        +1 compile 0m 46s branch-2 passed with JDK v1.7.0_111
        +1 checkstyle 0m 31s branch-2 passed
        +1 mvnsite 0m 54s branch-2 passed
        +1 mvneclipse 0m 17s branch-2 passed
        -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
        +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101
        +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.8.0_101
        +1 javac 0m 39s the patch passed
        +1 compile 0m 42s the patch passed with JDK v1.7.0_111
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 175 unchanged - 15 fixed = 177 total (was 190)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101
        +1 javadoc 1m 35s the patch passed with JDK v1.7.0_111
        -1 unit 54m 9s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        146m 37s



        Reason Tests
        JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:b59b8b7
        JIRA Issue HDFS-10851
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831149/HDFS-10851.branch-2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e07911c21f60 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / 10222cd
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16951/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16951/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 6s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 59s branch-2 passed +1 compile 0m 43s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 46s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 31s branch-2 passed +1 mvnsite 0m 54s branch-2 passed +1 mvneclipse 0m 17s branch-2 passed -1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 0m 55s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 38s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 46s the patch passed +1 compile 0m 39s the patch passed with JDK v1.8.0_101 +1 javac 0m 39s the patch passed +1 compile 0m 42s the patch passed with JDK v1.7.0_111 +1 javac 0m 42s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 175 unchanged - 15 fixed = 177 total (was 190) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 35s the patch passed with JDK v1.7.0_111 -1 unit 54m 9s hadoop-hdfs in the patch failed with JDK v1.7.0_111. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 146m 37s Reason Tests JDK v1.7.0_111 Failed junit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10851 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831149/HDFS-10851.branch-2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e07911c21f60 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 10222cd Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16951/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16951/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16951/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        The failed branch-2 test case passes reliably on my machine.

        -------------------------------------------------------
         T E S T S
        -------------------------------------------------------
        OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
        Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.984 sec - in org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
        
        Results :
        
        Tests run: 11, Failures: 0, Errors: 0, Skipped: 0
        
        Show
        kihwal Kihwal Lee added a comment - The failed branch-2 test case passes reliably on my machine. ------------------------------------------------------- T E S T S ------------------------------------------------------- OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.984 sec - in org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Results : Tests run: 11, Failures: 0, Errors: 0, Skipped: 0

          People

          • Assignee:
            daryn Daryn Sharp
            Reporter:
            daryn Daryn Sharp
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development