Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10843

Update space quota when a UC block is completed rather than committed.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha2
    • Component/s: hdfs, namenode
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Currently when a block has been committed but has not yet been completed, the cached size (used for the quota feature) of the directory containing that block differs from the computed size. This results in log messages of the following form:

      ERROR namenode.NameNode (DirectoryWithQuotaFeature.java:checkStoragespace(141)) - BUG: Inconsistent storagespace for directory /TestQuotaUpdate. Cached = 512 != Computed = 8192

      When a block is initially started under construction, the used space is conservatively set to a full block. When the block is committed, the cached size is updated to the final size of the block. However, the calculation of the computed size uses the full block size until the block is completed, so in the period where the block is committed but not completed they disagree. To fix this we need to decide which is correct and fix the other to match. It seems to me that the cached size is correct since once the block is committed its size will not change.

      This can be reproduced using the following steps:

      • Create a directory with a quota
      • Start writing to a file within this directory
      • Prevent all datanodes to which the file is written from communicating the corresponding BlockReceivedAndDeletedRequestProto to the NN temporarily (i.e. simulate a transient network partition/delay)
      • During this time, call DistributedFileSystem.getContentSummary() on the directory with the quota
      1. HDFS-10843.000.patch
        14 kB
        Erik Krogen
      2. HDFS-10843.001.patch
        14 kB
        Erik Krogen
      3. HDFS-10843.002.patch
        33 kB
        Erik Krogen
      4. HDFS-10843.003.patch
        35 kB
        Erik Krogen
      5. HDFS-10843.004.patch
        38 kB
        Erik Krogen
      6. HDFS-10843.005.patch
        37 kB
        Erik Krogen
      7. HDFS-10843-branch-2.005.patch
        32 kB
        Konstantin Shvachko
      8. HDFS-10843-branch-2.7.005.patch
        33 kB
        Erik Krogen

        Issue Links

          Activity

          Hide
          xkrogen Erik Krogen added a comment -

          I will attach a patch containing a unit test demonstrating the behavior as well as a fix. Konstantin Shvachko, can you comment on the desired behavior?

          Show
          xkrogen Erik Krogen added a comment - I will attach a patch containing a unit test demonstrating the behavior as well as a fix. Konstantin Shvachko , can you comment on the desired behavior?
          Hide
          xkrogen Erik Krogen added a comment -

          I have realized that this bug is more severe than I previously thought. As described above this will only result in a transient state where the cached and computed values briefly disagree. However, if the replication is changed while in this state, or similarly, while the block is under construction but has not yet been committed, the cached value will be updated incorrectly, causing the cached value to be persistently incorrect. All of these issues should be fixed by the same root cause of ensuring that the storagespace values are always computed in a consistent way - right now different spots in the code handle the different states (under construction, committed, completed) in inconsistent ways.

          Show
          xkrogen Erik Krogen added a comment - I have realized that this bug is more severe than I previously thought. As described above this will only result in a transient state where the cached and computed values briefly disagree. However, if the replication is changed while in this state, or similarly, while the block is under construction but has not yet been committed, the cached value will be updated incorrectly, causing the cached value to be persistently incorrect. All of these issues should be fixed by the same root cause of ensuring that the storagespace values are always computed in a consistent way - right now different spots in the code handle the different states (under construction, committed, completed) in inconsistent ways.
          Hide
          xkrogen Erik Krogen added a comment - - edited

          After further consideration it seems that it is probably most appropriate to continue to use the preferred block size as the cached size until the block is actually completed rather than just committed. This is more consistent with how the rest of the code treats the under construction size (see comments on INodeFile.{storagespaceConsumed,computeFileSize} and code in FileWithSnapshotFeature.updateQuotaAndCollectBlocks and FSDirAppendOp.computeQuotaDeltaForUCBlock); it seems that generally the under construction / not under construction distinction is used rather than committed vs. uncommitted.

          Show
          xkrogen Erik Krogen added a comment - - edited After further consideration it seems that it is probably most appropriate to continue to use the preferred block size as the cached size until the block is actually completed rather than just committed. This is more consistent with how the rest of the code treats the under construction size (see comments on INodeFile.{storagespaceConsumed,computeFileSize} and code in FileWithSnapshotFeature.updateQuotaAndCollectBlocks and FSDirAppendOp.computeQuotaDeltaForUCBlock ); it seems that generally the under construction / not under construction distinction is used rather than committed vs. uncommitted.
          Hide
          shv Konstantin Shvachko added a comment -

          Erik Krogen thanks for digging into this.

          When the block is committed, the cached size is updated to the final size of the block. However, the calculation of the computed size uses the full block size until the block is completed

          Looks like computeQuotaUsage() does not use prefered block size to compute file size. And computeFileSize() checks for COMPLETED state.
          So we should correct cached value and update it to final length only when the block is completed.
          I mean whatever is cached should correspond to how the quotas are checked.

          Show
          shv Konstantin Shvachko added a comment - Erik Krogen thanks for digging into this. When the block is committed, the cached size is updated to the final size of the block. However, the calculation of the computed size uses the full block size until the block is completed Looks like computeQuotaUsage() does not use prefered block size to compute file size. And computeFileSize() checks for COMPLETED state. So we should correct cached value and update it to final length only when the block is completed. I mean whatever is cached should correspond to how the quotas are checked.
          Hide
          xkrogen Erik Krogen added a comment -

          I am attaching a patch which includes 6 new tests in TestDiskspaceQuotaUpdate:

          • testComputedCachedSizesAgreeWhileCommitting
          • testIncreaseReplicationWhileCommitting
          • testDecreaseReplicationWhileCommitting
          • testDecreaseReplicationBeforeCommitting
          • testComputedCachedSizesAgreeBeforeCommitting
          • testIncreaseReplicationBeforeCommitting

          The first four all fail on the current build, 2.6 through trunk.

          The patch also includes a fix which moves the logic which updates the cached storagespace consumed by a file to occur when a block is completed, rather than when it is completed, to be consistent with how the rest of the code base considers the situation between commit and completion. Since there are multiple code paths which cause a block to complete and these paths originate from BlockManager, whereas there is only one code path (located in FSNamesystem) which causes a block to commit, this required an entry point from BlockManager back into FSNamesystem via a new public method on the Namesystem interface. I am open to suggestions as to a cleaner way to achieve this.

          The patch doesn't backport cleanly since numerous changes to numerous changes to the namenode have occurred (e.g. EC) but I have tested it back to 2.6 and after fixing compile errors it runs as expected.

          Show
          xkrogen Erik Krogen added a comment - I am attaching a patch which includes 6 new tests in TestDiskspaceQuotaUpdate : testComputedCachedSizesAgreeWhileCommitting testIncreaseReplicationWhileCommitting testDecreaseReplicationWhileCommitting testDecreaseReplicationBeforeCommitting testComputedCachedSizesAgreeBeforeCommitting testIncreaseReplicationBeforeCommitting The first four all fail on the current build, 2.6 through trunk. The patch also includes a fix which moves the logic which updates the cached storagespace consumed by a file to occur when a block is completed, rather than when it is completed, to be consistent with how the rest of the code base considers the situation between commit and completion. Since there are multiple code paths which cause a block to complete and these paths originate from BlockManager, whereas there is only one code path (located in FSNamesystem) which causes a block to commit, this required an entry point from BlockManager back into FSNamesystem via a new public method on the Namesystem interface. I am open to suggestions as to a cleaner way to achieve this. The patch doesn't backport cleanly since numerous changes to numerous changes to the namenode have occurred (e.g. EC) but I have tested it back to 2.6 and after fixing compile errors it runs as expected.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 0m 47s trunk passed
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 48s trunk passed
          +1 javadoc 0m 58s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 361 unchanged - 0 fixed = 363 total (was 361)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 0m 52s the patch passed
          -1 unit 78m 7s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          98m 53s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Dead store to iip in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.closeFileCommitBlocks(String, INodeFile, BlockInfo) At FSNamesystem.java:org.apache.hadoop.hdfs.server.namenode.FSNamesystem.closeFileCommitBlocks(String, INodeFile, BlockInfo) At FSNamesystem.java:[line 3595]
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827626/HDFS-10843.000.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8aecd0d50418 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 401db4f
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16674/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16674/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 0m 47s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 58s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 361 unchanged - 0 fixed = 363 total (was 361) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 52s the patch passed -1 unit 78m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 98m 53s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Dead store to iip in org.apache.hadoop.hdfs.server.namenode.FSNamesystem.closeFileCommitBlocks(String, INodeFile, BlockInfo) At FSNamesystem.java:org.apache.hadoop.hdfs.server.namenode.FSNamesystem.closeFileCommitBlocks(String, INodeFile, BlockInfo) At FSNamesystem.java: [line 3595] Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827626/HDFS-10843.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8aecd0d50418 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 401db4f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/16674/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16674/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16674/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xkrogen Erik Krogen added a comment -

          TestDFSStripedOutputStreamWithFailure appears unrelated and passes locally.

          Attached updated v1 patch fixing Findbugs and Checkstyle.

          Show
          xkrogen Erik Krogen added a comment - TestDFSStripedOutputStreamWithFailure appears unrelated and passes locally. Attached updated v1 patch fixing Findbugs and Checkstyle.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 4s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 31s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 55s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 27s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 51s the patch passed
          +1 unit 60m 50s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          80m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827654/HDFS-10843.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a4df679aeb43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b6d839a
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16681/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16681/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 4s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 51s the patch passed +1 unit 60m 50s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 80m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12827654/HDFS-10843.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a4df679aeb43 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b6d839a Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16681/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16681/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          Hey Erik, looks like you are fixing two issues here. One about updating space cache value after completing the block, and another that setReplication() incorrectly updates space for UC files. Both good finds, great!

          1. Your idea to place space update logic in a single place, inside completeBlock(), is good. I would suggest implementing it a bit differently. I would move the part of FSN.commitOrCompleteLastBlock() related to // Adjust disk space consumption if required to FSDirectory as a new method adjustSpaceConsumed(fileINode, iip, commitBlock). Then you can call it from completeBlock(), which should take FSDirectory as a parameter. Better not to change Namespace interface.
          2. The tests looks good. I see you shutting down 3 DNs in the new test. Which may affect old tests if they are executed after the new ones. I did not check but worth verifying.
          3. Also Answer should be used with a generic parameter Answer<Object>.
          Show
          shv Konstantin Shvachko added a comment - Hey Erik, looks like you are fixing two issues here. One about updating space cache value after completing the block, and another that setReplication() incorrectly updates space for UC files. Both good finds, great! Your idea to place space update logic in a single place, inside completeBlock() , is good. I would suggest implementing it a bit differently. I would move the part of FSN.commitOrCompleteLastBlock() related to // Adjust disk space consumption if required to FSDirectory as a new method adjustSpaceConsumed(fileINode, iip, commitBlock) . Then you can call it from completeBlock() , which should take FSDirectory as a parameter. Better not to change Namespace interface. The tests looks good. I see you shutting down 3 DNs in the new test. Which may affect old tests if they are executed after the new ones. I did not check but worth verifying. Also Answer should be used with a generic parameter Answer<Object> .
          Hide
          shv Konstantin Shvachko added a comment -

          One more thing about iip parameter. Let's keep it where we can. It is an optimization. Because resolving the path is expensive, we should avoid it if possible.

          Show
          shv Konstantin Shvachko added a comment - One more thing about iip parameter. Let's keep it where we can. It is an optimization. Because resolving the path is expensive, we should avoid it if possible.
          Hide
          xkrogen Erik Krogen added a comment -

          1. The problem is that most calls to completeBlock() originate from within BlockManager, which does not maintain a reference to FSDirectory. It only has access to FSDirectory indirectly through FSNamesystem, and maintains its reference to FSNamesystem as the Namesystem interface. This was the only reason I changed the Namespace interface. Maybe it would be better to make BlockManager require FSNamesystem specifically (which exports a getFSDirectory method) rather than a general Namesystem? Are there future plans for other classes implementing Namesystem?
          2. The cluster creation happens in an @Before-annotated method so IIUC the cluster should be fresh before each test.
          3. Got it.

          Thanks for looking! Let me know what you think on #1.

          Show
          xkrogen Erik Krogen added a comment - 1. The problem is that most calls to completeBlock() originate from within BlockManager , which does not maintain a reference to FSDirectory . It only has access to FSDirectory indirectly through FSNamesystem , and maintains its reference to FSNamesystem as the Namesystem interface. This was the only reason I changed the Namespace interface. Maybe it would be better to make BlockManager require FSNamesystem specifically (which exports a getFSDirectory method) rather than a general Namesystem ? Are there future plans for other classes implementing Namesystem ? 2. The cluster creation happens in an @Before -annotated method so IIUC the cluster should be fresh before each test. 3. Got it. Thanks for looking! Let me know what you think on #1.
          Hide
          shv Konstantin Shvachko added a comment -

          You are right completeBlock() calls are too deep inside BlockManager.
          How about we add a new getFSDirectory method to Namesystem. This should be sufficient to resolve this case.

          Historically Namesystem interface was added in HDFS-2266. Not much motivation is given there, but the idea was a better separation between FSNamesystem and BlockManager. Initially Namesystem was very basic essentially accessing FSNamesystem's locks and SafeMode. But since then people were adding rather random methods into it. Mostly in order to allow access to FSDirectory, like getBlockCollection(). So may be we should just add Namesystem.getFSDirectory so that later we could eliminate getBlockCollection() and isInSnapshot() from Namesystem.

          For the tests you should probably combine new test cases into one or even integrate with the existing cases. Starting mini-cluster is time consuming, increases test running time. So optimally we should start the cluster once in @BeforeClass.

          Show
          shv Konstantin Shvachko added a comment - You are right completeBlock() calls are too deep inside BlockManager . How about we add a new getFSDirectory method to Namesystem . This should be sufficient to resolve this case. Historically Namesystem interface was added in HDFS-2266 . Not much motivation is given there, but the idea was a better separation between FSNamesystem and BlockManager . Initially Namesystem was very basic essentially accessing FSNamesystem's locks and SafeMode. But since then people were adding rather random methods into it. Mostly in order to allow access to FSDirectory , like getBlockCollection() . So may be we should just add Namesystem.getFSDirectory so that later we could eliminate getBlockCollection() and isInSnapshot() from Namesystem . For the tests you should probably combine new test cases into one or even integrate with the existing cases. Starting mini-cluster is time consuming, increases test running time. So optimally we should start the cluster once in @BeforeClass .
          Hide
          xkrogen Erik Krogen added a comment - - edited

          v002 patch incorporates your suggestions, Konstantin Shvachko. Tests now only start the minicluster once, and the logic for updating the directory size has been moved to FSDirectory. Also I have persisted iip wherever possible.

          Show
          xkrogen Erik Krogen added a comment - - edited v002 patch incorporates your suggestions, Konstantin Shvachko . Tests now only start the minicluster once, and the logic for updating the directory size has been moved to FSDirectory . Also I have persisted iip wherever possible.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 37s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 0m 54s trunk passed
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 40s the patch passed
          +1 javac 0m 40s the patch passed
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 388 unchanged - 6 fixed = 397 total (was 394)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 45s the patch passed
          +1 javadoc 0m 52s the patch passed
          +1 unit 57m 49s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          76m 25s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828124/HDFS-10843.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 31998cefd804 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 58ed4fa
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16718/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16718/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16718/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 37s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 38s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 40s the patch passed +1 javac 0m 40s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 9 new + 388 unchanged - 6 fixed = 397 total (was 394) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 57m 49s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 76m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828124/HDFS-10843.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 31998cefd804 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 58ed4fa Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16718/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16718/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16718/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xkrogen Erik Krogen added a comment -

          Seems that I accidentally uploaded a slightly out of date patch file for v002. v003 is the correct patch.

          Show
          xkrogen Erik Krogen added a comment - Seems that I accidentally uploaded a slightly out of date patch file for v002. v003 is the correct patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 41s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 53s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 364 unchanged - 7 fixed = 366 total (was 371)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 53s the patch passed
          +1 unit 58m 32s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          77m 17s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828142/HDFS-10843.003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c026c367bdf6 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 72dfb04
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16722/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16722/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16722/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 41s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 53s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 364 unchanged - 7 fixed = 366 total (was 371) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 53s the patch passed +1 unit 58m 32s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 77m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828142/HDFS-10843.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c026c367bdf6 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 72dfb04 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16722/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16722/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16722/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          Nice, Erik. Minor comments on the latest patch

          1. updateSpaceForCompleteBlock(). Traditionally we say "complete" block not "completed". As in convertToCompleteBlock() or getCompleteBlocksTotal().
          2. Organize 2 new imports in FSDirectory.
          3. May be it would make sense to move updateSpaceForCompleteBlock() further inside convertToCompleteBlock(), so that nobody could complete a block without updating spaces.
          4. great refactoring of TestDiskspaceQuotaUpdate. I would only suggest to rename
            • getDirectory() to getParent()
            • getFSDir() to getFSDirectory()
          5. Also according to checkstyle warnings constant baseDir should be all-capital BASE_DIR, and some misplaced white spaces.
          Show
          shv Konstantin Shvachko added a comment - Nice, Erik. Minor comments on the latest patch updateSpaceForCompleteBlock() . Traditionally we say "complete" block not "completed". As in convertToCompleteBlock() or getCompleteBlocksTotal() . Organize 2 new imports in FSDirectory. May be it would make sense to move updateSpaceForCompleteBlock() further inside convertToCompleteBlock() , so that nobody could complete a block without updating spaces. great refactoring of TestDiskspaceQuotaUpdate. I would only suggest to rename getDirectory() to getParent() getFSDir() to getFSDirectory() Also according to checkstyle warnings constant baseDir should be all-capital BASE_DIR , and some misplaced white spaces.
          Hide
          xkrogen Erik Krogen added a comment -

          Thanks for the comments.

          I am a little unsure about point 3. It is definitely advantageous to force the space to be updated whenever a block is completed by placing the method call inside of convertToCompleteBlock. I am a little wary that it creates an awkward control flow given that most BlockInfo operations deal only with the block itself. I included this change in the v004 patch but want to call it out for a second look just to be sure that it is the right move.

          v004 patch also addresses comments 1, 2, 4, 5.

          Show
          xkrogen Erik Krogen added a comment - Thanks for the comments. I am a little unsure about point 3. It is definitely advantageous to force the space to be updated whenever a block is completed by placing the method call inside of convertToCompleteBlock . I am a little wary that it creates an awkward control flow given that most BlockInfo operations deal only with the block itself. I included this change in the v004 patch but want to call it out for a second look just to be sure that it is the right move. v004 patch also addresses comments 1, 2, 4, 5.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 43s trunk passed
          +1 javadoc 0m 54s trunk passed
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          +1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 369 unchanged - 7 fixed = 369 total (was 376)
          +1 mvnsite 0m 48s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 54s the patch passed
          -1 unit 85m 15s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          104m 29s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828348/HDFS-10843.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e1e5eaeedc96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 86c9862
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16736/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16736/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16736/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 54s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 28s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 369 unchanged - 7 fixed = 369 total (was 376) +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 85m 15s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 104m 29s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828348/HDFS-10843.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e1e5eaeedc96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 86c9862 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16736/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16736/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16736/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          You are right, the control flow looks awkward once you see it done.
          Let's leave BlockInfo.convertToCompleteBlock() as is and instead wrap the calls to these 2 methods in a new function BlockManager.convertToCompleteBlock(curBlock, iip) adding all the comments about updating space while completing there.
          Would that look better?

          Show
          shv Konstantin Shvachko added a comment - You are right, the control flow looks awkward once you see it done. Let's leave BlockInfo.convertToCompleteBlock() as is and instead wrap the calls to these 2 methods in a new function BlockManager.convertToCompleteBlock(curBlock, iip) adding all the comments about updating space while completing there. Would that look better?
          Hide
          xkrogen Erik Krogen added a comment - - edited

          What advantage is there to wrapping those two specific calls in a new method BlockManager.convertToCompleteBlock rather than just calling both from within BlockManager.completeBlock as in patch v003? I think the distinction between the two methods would be a little confusing.

          Show
          xkrogen Erik Krogen added a comment - - edited What advantage is there to wrapping those two specific calls in a new method BlockManager.convertToCompleteBlock rather than just calling both from within BlockManager.completeBlock as in patch v003? I think the distinction between the two methods would be a little confusing.
          Hide
          shv Konstantin Shvachko added a comment -

          I am just trying to make the coupling of completing a block and changing space consumed more explicit.
          With current patch one should remember to updateSpaceForCompleteBlock( whenever the block is completed BlockInfo.convertToCompleteBlock(). If we wrap them together you don't need to remember, just call the new method. Minimizing chances to make a mistake for others.

          Show
          shv Konstantin Shvachko added a comment - I am just trying to make the coupling of completing a block and changing space consumed more explicit. With current patch one should remember to updateSpaceForCompleteBlock( whenever the block is completed BlockInfo.convertToCompleteBlock() . If we wrap them together you don't need to remember, just call the new method. Minimizing chances to make a mistake for others.
          Hide
          xkrogen Erik Krogen added a comment -

          But you shouldn't be calling BlockInfo.convertToCompleteBlock anyway, you should be calling BlockManager.completeBlock. completeBlock has other operations, e.g. checking for minimum replication and updating the block totals, that must be completed every time a block is completed. A separate BlockManager.convertToCompleteBlock method may imply that convertToCompleteBlock is an acceptable way to complete a block (bypassing the other code in completeBlock) when really the only acceptable way is through BlockManager.completeBlock.

          Show
          xkrogen Erik Krogen added a comment - But you shouldn't be calling BlockInfo.convertToCompleteBlock anyway, you should be calling BlockManager.completeBlock . completeBlock has other operations, e.g. checking for minimum replication and updating the block totals, that must be completed every time a block is completed. A separate BlockManager.convertToCompleteBlock method may imply that convertToCompleteBlock is an acceptable way to complete a block (bypassing the other code in completeBlock ) when really the only acceptable way is through BlockManager.completeBlock .
          Hide
          xkrogen Erik Krogen added a comment -

          After offline discussion with Konstantin, attaching v005 patch with a new BlockManager.convertToCompleteBlock method wrapping the two related method calls.

          Show
          xkrogen Erik Krogen added a comment - After offline discussion with Konstantin, attaching v005 patch with a new BlockManager.convertToCompleteBlock method wrapping the two related method calls.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 44s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 19s trunk passed
          +1 compile 0m 54s trunk passed
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 0m 55s trunk passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 43s the patch passed
          +1 javac 0m 43s the patch passed
          +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 364 unchanged - 7 fixed = 364 total (was 371)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 51s the patch passed
          +1 javadoc 1m 1s the patch passed
          -1 unit 63m 6s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          97m 53s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829264/HDFS-10843.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 38a1a67214c7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / c54f6ef
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16796/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16796/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16796/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 44s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 19s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 43s the patch passed +1 javac 0m 43s the patch passed +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 364 unchanged - 7 fixed = 364 total (was 371) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 51s the patch passed +1 javadoc 1m 1s the patch passed -1 unit 63m 6s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 97m 53s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeRollingUpgrade Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829264/HDFS-10843.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 38a1a67214c7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c54f6ef Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16796/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16796/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16796/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xkrogen Erik Krogen added a comment -

          Test failure does not appear to be related and runs successfully locally.

          Show
          xkrogen Erik Krogen added a comment - Test failure does not appear to be related and runs successfully locally.
          Hide
          shv Konstantin Shvachko added a comment -

          +1. Will commit in a bit.

          Show
          shv Konstantin Shvachko added a comment - +1. Will commit in a bit.
          Hide
          shv Konstantin Shvachko added a comment -

          Erik Krogen could you please attach a patch for branch-2.7. I managed to merge this to branch-2 and branch-2.8.

          Show
          shv Konstantin Shvachko added a comment - Erik Krogen could you please attach a patch for branch-2.7. I managed to merge this to branch-2 and branch-2.8.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 53s branch-2 passed
          +1 compile 0m 39s branch-2 passed with JDK v1.8.0_101
          +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 0m 33s branch-2 passed
          +1 mvnsite 0m 56s branch-2 passed
          +1 mvneclipse 0m 15s branch-2 passed
          +1 findbugs 2m 4s branch-2 passed
          +1 javadoc 1m 1s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 40s branch-2 passed with JDK v1.7.0_111
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_101
          +1 javac 0m 44s the patch passed
          +1 compile 0m 45s the patch passed with JDK v1.7.0_111
          +1 javac 0m 45s the patch passed
          +1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 397 unchanged - 8 fixed = 397 total (was 405)
          +1 mvnsite 0m 54s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 15s the patch passed
          +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_111
          +1 unit 48m 4s hadoop-hdfs in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          138m 7s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.TestEncryptionZones



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829938/HDFS-10843-branch-2.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 946942dfaae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / d733593
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16835/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16835/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 53s branch-2 passed +1 compile 0m 39s branch-2 passed with JDK v1.8.0_101 +1 compile 0m 43s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 0m 33s branch-2 passed +1 mvnsite 0m 56s branch-2 passed +1 mvneclipse 0m 15s branch-2 passed +1 findbugs 2m 4s branch-2 passed +1 javadoc 1m 1s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 40s branch-2 passed with JDK v1.7.0_111 +1 mvninstall 0m 49s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_101 +1 javac 0m 44s the patch passed +1 compile 0m 45s the patch passed with JDK v1.7.0_111 +1 javac 0m 45s the patch passed +1 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 397 unchanged - 8 fixed = 397 total (was 405) +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 15s the patch passed +1 javadoc 0m 55s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_111 +1 unit 48m 4s hadoop-hdfs in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 138m 7s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.TestEncryptionZones Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829938/HDFS-10843-branch-2.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 946942dfaae1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / d733593 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16835/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16835/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xkrogen Erik Krogen added a comment -

          Attaching patch for branch-2.7

          Show
          xkrogen Erik Krogen added a comment - Attaching patch for branch-2.7
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 6m 42s branch-2.7 passed
          +1 compile 5m 56s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 6m 17s branch-2.7 passed with JDK v1.7.0_111
          +1 checkstyle 1m 28s branch-2.7 passed
          +1 mvnsite 1m 45s branch-2.7 passed
          +1 mvneclipse 0m 28s branch-2.7 passed
          -1 findbugs 1m 34s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings.
          +1 javadoc 1m 45s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 2m 38s branch-2.7 passed with JDK v1.7.0_111
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 32s the patch passed
          +1 compile 5m 29s the patch passed with JDK v1.8.0_101
          +1 javac 5m 29s the patch passed
          +1 compile 6m 16s the patch passed with JDK v1.7.0_111
          +1 javac 6m 16s the patch passed
          -0 checkstyle 1m 24s root: The patch generated 3 new + 653 unchanged - 3 fixed = 656 total (was 656)
          +1 mvnsite 1m 46s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          -1 whitespace 0m 0s The patch has 4750 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 2m 27s The patch 166 line(s) with tabs.
          +1 findbugs 5m 0s the patch passed
          +1 javadoc 1m 42s the patch passed with JDK v1.8.0_101
          +1 javadoc 2m 35s the patch passed with JDK v1.7.0_111
          -1 unit 21m 34s hadoop-common in the patch failed with JDK v1.7.0_111.
          -1 unit 63m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_111.
          -1 asflicense 0m 26s The patch generated 4 ASF License warnings.
          219m 19s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters
            hadoop.io.TestBloomMapFile
            hadoop.ha.TestZKFailoverControllerStress
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration
          JDK v1.7.0_111 Failed junit tests hadoop.util.bloom.TestBloomFilters
            hadoop.io.TestBloomMapFile
            hadoop.ha.TestZKFailoverControllerStress
            hadoop.io.TestMapFile
            hadoop.hdfs.server.namenode.TestDecommissioningStatus
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.hdfs.web.TestWebHdfsTokens
            hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
          JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Issue HDFS-10843
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829970/HDFS-10843-branch-2.7.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 108a460d33a7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 2a1e48b
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16837/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16837/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 6m 42s branch-2.7 passed +1 compile 5m 56s branch-2.7 passed with JDK v1.8.0_101 +1 compile 6m 17s branch-2.7 passed with JDK v1.7.0_111 +1 checkstyle 1m 28s branch-2.7 passed +1 mvnsite 1m 45s branch-2.7 passed +1 mvneclipse 0m 28s branch-2.7 passed -1 findbugs 1m 34s hadoop-common-project/hadoop-common in branch-2.7 has 3 extant Findbugs warnings. +1 javadoc 1m 45s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 2m 38s branch-2.7 passed with JDK v1.7.0_111 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 5m 29s the patch passed with JDK v1.8.0_101 +1 javac 5m 29s the patch passed +1 compile 6m 16s the patch passed with JDK v1.7.0_111 +1 javac 6m 16s the patch passed -0 checkstyle 1m 24s root: The patch generated 3 new + 653 unchanged - 3 fixed = 656 total (was 656) +1 mvnsite 1m 46s the patch passed +1 mvneclipse 0m 29s the patch passed -1 whitespace 0m 0s The patch has 4750 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 2m 27s The patch 166 line(s) with tabs. +1 findbugs 5m 0s the patch passed +1 javadoc 1m 42s the patch passed with JDK v1.8.0_101 +1 javadoc 2m 35s the patch passed with JDK v1.7.0_111 -1 unit 21m 34s hadoop-common in the patch failed with JDK v1.7.0_111. -1 unit 63m 22s hadoop-hdfs in the patch failed with JDK v1.7.0_111. -1 asflicense 0m 26s The patch generated 4 ASF License warnings. 219m 19s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.util.bloom.TestBloomFilters   hadoop.io.TestBloomMapFile   hadoop.ha.TestZKFailoverControllerStress   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.8.0_101 Timed out junit tests org.apache.hadoop.conf.TestConfiguration JDK v1.7.0_111 Failed junit tests hadoop.util.bloom.TestBloomFilters   hadoop.io.TestBloomMapFile   hadoop.ha.TestZKFailoverControllerStress   hadoop.io.TestMapFile   hadoop.hdfs.server.namenode.TestDecommissioningStatus   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.hdfs.web.TestWebHdfsTokens   hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes JDK v1.7.0_111 Timed out junit tests org.apache.hadoop.conf.TestConfiguration Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Issue HDFS-10843 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829970/HDFS-10843-branch-2.7.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 108a460d33a7 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 2a1e48b Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_111.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_111.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16837/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/16837/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16837/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xkrogen Erik Krogen added a comment -

          findbugs - all unrelated to this patch
          whitespace - all unrelated to this patch
          asflicense - all unrelated to this patch

          unit test failures:

          • hadoop-common-project: all are certainly unrelated; only change was to add one new static method to help with capturing logs since the current LogCapturer refused to handle NameNode.LOG despite being compatible.
          • hadoop-hdfs-project: Some of the Jenkins failures were due to OOM. All of them pass locally except for TestDataNodeHotSwapVolumes which intermittently fails, but it did so before this patch as well.
          Show
          xkrogen Erik Krogen added a comment - findbugs - all unrelated to this patch whitespace - all unrelated to this patch asflicense - all unrelated to this patch unit test failures: hadoop-common-project: all are certainly unrelated; only change was to add one new static method to help with capturing logs since the current LogCapturer refused to handle NameNode.LOG despite being compatible. hadoop-hdfs-project: Some of the Jenkins failures were due to OOM. All of them pass locally except for TestDataNodeHotSwapVolumes which intermittently fails, but it did so before this patch as well.
          Hide
          shv Konstantin Shvachko added a comment -

          I just committed this up to branch-2.7. Thank you Erik.

          Show
          shv Konstantin Shvachko added a comment - I just committed this up to branch-2.7. Thank you Erik.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10480 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10480/)
          HDFS-10843. Update space quota when a UC block is completed rather than (shv: rev a5bb88c8e0fd4bd19b6d377fecbe1d2d441514f6)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDiskspaceQuotaUpdate.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10480 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10480/ ) HDFS-10843 . Update space quota when a UC block is completed rather than (shv: rev a5bb88c8e0fd4bd19b6d377fecbe1d2d441514f6) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirAttrOp.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestDiskspaceQuotaUpdate.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

            People

            • Assignee:
              xkrogen Erik Krogen
              Reporter:
              xkrogen Erik Krogen
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development