[HDFS-10816] TestComputeInvalidateWork#testDatanodeReRegistration fails due to race between test and replication monitor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
• Hadoop Flags: Reviewed
• Assignee: Eric Badger
• Reporter: Eric Badger
• Created: 30/Aug/16 15:50
• Updated: 02/Oct/19 17:14
• Resolved: 05/Jun/17 20:29

Description

java.lang.AssertionError: Expected invalidate blocks to be the number of DNs expected:<3> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.apache.hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork.testDatanodeReRegistration(TestComputeInvalidateWork.java:160)

The test fails because of a race condition between the test and the replication monitor. The default replication monitor interval is 3 seconds, which is just about how long the test normally takes to run. The test deletes a file and then subsequently gets the namesystem writelock. However, if the replication monitor fires in between those two instructions, the test will fail as it will itself invalidate one of the blocks. This can be easily reproduced by removing the sleep() in the ReplicationMonitor's run() method in BlockManager.java, so that the replication monitor executes as quickly as possible and exacerbates the race.

To fix the test all that needs to be done is to turn off the replication monitor.

Issue Links

• relates to: HDFS-9580 TestComputeInvalidateWork#testDatanodeReRegistration failed due to unexpected number of invalidate blocks.