Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10814

Add assertion for getNumEncryptionZones when no EZ is created

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-10809 adds an additional assertion to TestEncryptionZones to validate that getNumEncryptionZones returns 0 if there is no EZ. This is a useful check to add to trunk as well.

      1. HDFS-10814.001.patch
        0.9 kB
        Vinitha Reddy Gankidi

        Activity

        Hide
        zhz Zhe Zhang added a comment -

        Thanks Vinitha for the fix. This will catch future potential NPE issues.

        +1 on the patch pending Jenkins.

        Show
        zhz Zhe Zhang added a comment - Thanks Vinitha for the fix. This will catch future potential NPE issues. +1 on the patch pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 2s trunk passed
        +1 compile 0m 44s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 50s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 41s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 46s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 45 unchanged - 1 fixed = 46 total (was 46)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 52s the patch passed
        -1 unit 73m 7s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        92m 55s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10814
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826113/HDFS-10814.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5e2540238470 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / cd5e10c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16572/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16572/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16572/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16572/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 2s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 41s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 46s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 45 unchanged - 1 fixed = 46 total (was 46) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 73m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 92m 55s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestReconstructStripedBlocksWithRackAwareness Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10814 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12826113/HDFS-10814.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5e2540238470 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cd5e10c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/16572/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/16572/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16572/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16572/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment - - edited

        Thanks Vinitha. I just committed the patch to trunk, branch-3.0.0-alpha1, branch-2, and branch-2.8.

        Show
        zhz Zhe Zhang added a comment - - edited Thanks Vinitha. I just committed the patch to trunk, branch-3.0.0-alpha1, branch-2, and branch-2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10373 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10373/)
        HDFS-10814. Add assertion for getNumEncryptionZones when no EZ is (zhz: rev 4bd45f54eedd449a98a90540698c6ceb47454fec)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10373 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10373/ ) HDFS-10814 . Add assertion for getNumEncryptionZones when no EZ is (zhz: rev 4bd45f54eedd449a98a90540698c6ceb47454fec) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
        Hide
        andrew.wang Andrew Wang added a comment -

        I'm bumping this to 3.0.0-alpha2 fixVersion since I just sent out the 3.0.0-alpha1 RC0, but we can pull it in if there's another RC. Thanks folks!

        Show
        andrew.wang Andrew Wang added a comment - I'm bumping this to 3.0.0-alpha2 fixVersion since I just sent out the 3.0.0-alpha1 RC0, but we can pull it in if there's another RC. Thanks folks!
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Andrew for taking care of this.

        Show
        zhz Zhe Zhang added a comment - Thanks Andrew for taking care of this.
        Hide
        redvine Vinitha Reddy Gankidi added a comment -

        Thanks Zhe and Andrew!

        Show
        redvine Vinitha Reddy Gankidi added a comment - Thanks Zhe and Andrew!

          People

          • Assignee:
            redvine Vinitha Reddy Gankidi
            Reporter:
            redvine Vinitha Reddy Gankidi
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development