Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1078

update libhdfs build process to produce static libraries

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.21.0
    • Component/s: libhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      it would be useful if the build of libhdfs produced the static version (.a) in addition to the existing shared (.so*) version. This can be accomplished by removing the -shared option to the linker (in configure.ac/configure files)

        Activity

        Hide
        dhruba borthakur added a comment -

        I just committed this. Thanks Sam.

        Show
        dhruba borthakur added a comment - I just committed this. Thanks Sam.
        Hide
        sam rash added a comment -

        fixed patch to not have prefix

        Show
        sam rash added a comment - fixed patch to not have prefix
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12440716/HDFS-1078-patch-1.txt
        against trunk revision 934196.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/156/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12440716/HDFS-1078-patch-1.txt against trunk revision 934196. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/156/console This message is automatically generated.
        Hide
        sam rash added a comment -

        also ran fine for me

        Show
        sam rash added a comment - also ran fine for me
        Hide
        dhruba borthakur added a comment -

        Looks good to me. I ran ant compile -Dcompile.c++=true -Dlibhdfs=true, looks good. I will like to commit this unless you have any other concerns.

        Show
        dhruba borthakur added a comment - Looks good to me. I ran ant compile -Dcompile.c++=true -Dlibhdfs=true, looks good. I will like to commit this unless you have any other concerns.
        Hide
        Eli Collins added a comment -

        Looks good to me. Testing? I verified the generated shared obj is the same w and w/o your patch. Would be good to run the unit tests (ant -Dcompile.c++=true -Dlibhdfs=true test) as well. Btw good to generate your patches with --no-prefix.

        Show
        Eli Collins added a comment - Looks good to me. Testing? I verified the generated shared obj is the same w and w/o your patch. Would be good to run the unit tests ( ant -Dcompile.c++=true -Dlibhdfs=true test ) as well. Btw good to generate your patches with --no-prefix.
        Hide
        sam rash added a comment -

        changes to configure/configure.ac to build both static and shared versions of libhdfs

        Show
        sam rash added a comment - changes to configure/configure.ac to build both static and shared versions of libhdfs

          People

          • Assignee:
            sam rash
            Reporter:
            sam rash
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development