Details
-
Type:
Sub-task
-
Status: Resolved
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.8.0, 3.0.0-alpha2
-
Component/s: hdfs
-
Labels:None
-
Hadoop Flags:Reviewed
Description
Rename uses FSDirectory.isDir(String) to determine if the destination is a directory. This dissect the path, creates an IIP, checks if the last inode is a directory. The rename operations already have the IIP and can check it directly.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 16s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| +1 | mvninstall | 6m 56s | trunk passed |
| +1 | compile | 0m 44s | trunk passed |
| +1 | checkstyle | 0m 29s | trunk passed |
| +1 | mvnsite | 0m 50s | trunk passed |
| +1 | mvneclipse | 0m 11s | trunk passed |
| +1 | findbugs | 1m 40s | trunk passed |
| +1 | javadoc | 0m 54s | trunk passed |
| +1 | mvninstall | 0m 48s | the patch passed |
| +1 | compile | 0m 43s | the patch passed |
| +1 | javac | 0m 43s | the patch passed |
| -0 | checkstyle | 0m 26s | hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 227 unchanged - 2 fixed = 230 total (was 229) |
| +1 | mvnsite | 0m 48s | the patch passed |
| +1 | mvneclipse | 0m 10s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 47s | the patch passed |
| +1 | javadoc | 0m 53s | the patch passed |
| -1 | unit | 59m 27s | hadoop-hdfs in the patch failed. |
| +1 | asflicense | 0m 18s | The patch does not generate ASF License warnings. |
| 78m 33s |
| Reason | Tests |
|---|---|
| Failed junit tests | hadoop.hdfs.qjournal.client.TestQuorumJournalManager |
| hadoop.hdfs.TestCrcCorruption |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12830546/HDFS-10779.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 0bd9a9575615 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 1831be8 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| checkstyle | https://builds.apache.org/job/PreCommit-HDFS-Build/16884/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt |
| unit | https://builds.apache.org/job/PreCommit-HDFS-Build/16884/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/16884/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/16884/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
+1 nice improvement to not re-resolve the same thing multiple times.
Committed this to trunk through branch-2.8.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10509 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10509/)
HDFS-10779. Rename does not need to re-solve destination. Contributed by (kihwal: rev 5f34402adae191232fe78e62990396ca07f314bb)
- (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
- (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java
- (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
Stopped calling FSDirectory#isDir and completely removed the method. Extensively use IIP instead of passing around string paths. Modified rename txns and return result to remove need to re-resolve path again just to audit log.