[HDFS-10764] Fix INodeFile#getBlocks to not return null

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 15/Aug/16 22:52
• Updated: 30/Aug/16 01:13
• Resolved: 20/Aug/16 05:30

Description

Not all callers of INodeFile#getBlocks check for null. e.g.

  public final QuotaCounts storagespaceConsumedContiguous(
      BlockStoragePolicy bsp) {
...
      // Collect all distinct blocks
      Set<BlockInfo> allBlocks = new HashSet<>(Arrays.asList(getBlocks()));

We can either fix each caller or alternatively fix getBlocks to never return null.