[HDFS-10753] Method invocation in log can be replaced by variable because the variable's toString method contains more info

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7.2
• Labels: easyfix easytest
• Assignee: Unassigned
• Reporter: Nemo Chen
• Created: 11/Aug/16 18:34
• Updated: 26/Jul/19 11:44
• Resolved: 26/Jul/19 11:43

Description

Similar to the fix in HADOOP-6419, in file:

hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/CorruptReplicasMap.java

in line 76, the blk.getBlockName() method invocation is invoked on variable blk. "blk" is the class instance of Block.

void addToCorruptReplicasMap(Block blk, DatanodeDescriptor dn,
      String reason, Reason reasonCode) {
...
NameNode.blockStateChangeLog.info(
          "BLOCK NameSystem.addToCorruptReplicasMap: {} added as corrupt on "
              + "{} by {} {}", blk.getBlockName(), dn, Server.getRemoteIp(),
          reasonText);

In file: hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/Block.java

  @Override
  public String toString() {
    return getBlockName() + "_" + getGenerationStamp();
  }

The toString() method contain not only getBlockName() but also getGenerationStamp which may be helpful for debugging purpose. Therefore blk.getBlockName() can be replaced by blk

Issue Links

• is superceded by: HDFS-10752 Several log refactoring/improvement suggestion in HDFS
• links to: GitHub Pull Request #122
• links to: GitHub Pull Request #122