[HDFS-10750] Log refactoring: method invocation should be replaced by a shorter method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 2.7.2
• Labels: easyfix easytest
• Assignee: Unassigned
• Reporter: Nemo Chen
• Created: 11/Aug/16 17:39
• Updated: 26/Jul/19 12:11
• Resolved: 26/Jul/19 12:11

Description

Similar to the fix for AVRO-115. In file:

hadoop-rel-release-2.7.2/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java

in line 695, the logging code:

LOG.info(getRole() + " RPC up at: " + rpcServer.getRpcAddress());

In the same class, there is a method in line 907:

  /**
   * @return NameNode RPC address
   */
  public InetSocketAddress getNameNodeAddress() {
    return rpcServer.getRpcAddress();
  }

We can tell that rpcServer.getRpcAddress() could be replaced by method getNameNodeAddress() for the case of readability and simplicity

Issue Links

• is superceded by: HDFS-10752 Several log refactoring/improvement suggestion in HDFS