Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9809 Abstract implementation-specific details from the datanode
  3. HDFS-10638

Modifications to remove the assumption that StorageLocation is associated with java.io.File in Datanode.

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: datanode, fs
    • Labels:
      None

      Description

      Changes to ensure that StorageLocation need not be associated with a java.io.File.

      1. HDFS-10638.005.patch
        46 kB
        Virajith Jalaparti
      2. HDFS-10638.004.patch
        27 kB
        Virajith Jalaparti
      3. HDFS-10638.003.patch
        23 kB
        Virajith Jalaparti
      4. HDFS-10638.002.patch
        23 kB
        Virajith Jalaparti
      5. HDFS-10638.001.patch
        23 kB
        Virajith Jalaparti

        Issue Links

          Activity

          Hide
          virajith Virajith Jalaparti added a comment -

          The patch aims to

          1. associate StorageDirectory with StorageLocation, instead of java.io.File (replacing calls to StorageDirectory#getRoot by StorageDirectory#getStorageLocation)
          2. remove references to StorageLocation#getFile

          so that StorageLocation need not be associated with a java.io.File.

          Show
          virajith Virajith Jalaparti added a comment - The patch aims to associate StorageDirectory with StorageLocation , instead of java.io.File (replacing calls to StorageDirectory#getRoot by StorageDirectory#getStorageLocation ) remove references to StorageLocation#getFile so that StorageLocation need not be associated with a java.io.File .
          Hide
          virajith Virajith Jalaparti added a comment -

          Updated patch to work with the new patches of HDFS-10636 and HDFS-10637.

          Show
          virajith Virajith Jalaparti added a comment - Updated patch to work with the new patches of HDFS-10636 and HDFS-10637 .
          Hide
          virajith Virajith Jalaparti added a comment -

          Posting an updated patch to work with the most recent patch for HDFS-10637.

          Show
          virajith Virajith Jalaparti added a comment - Posting an updated patch to work with the most recent patch for HDFS-10637 .
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Virajith Jalaparti

             try {
             File file = new File(uri.toString());
            String absPath = file.getAbsolutePath();
            uri = new URI("file", uri.getAuthority(), absPath, uri.getQuery(), uri.getFragment());
          } catch (URISyntaxException e) {
             e.printStackTrace();
          }
          

          It should not swallow the exception. It can throw IOE.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Virajith Jalaparti try { File file = new File(uri.toString()); String absPath = file.getAbsolutePath(); uri = new URI( "file" , uri.getAuthority(), absPath, uri.getQuery(), uri.getFragment()); } catch (URISyntaxException e) { e.printStackTrace(); } It should not swallow the exception. It can throw IOE .
          Hide
          virajith Virajith Jalaparti added a comment -

          Modified patch based on the final patch for HDFS-10637.

          Show
          virajith Virajith Jalaparti added a comment - Modified patch based on the final patch for HDFS-10637 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 0m 43s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 52s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 40s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 51s the patch passed
          +1 javac 0m 51s the patch passed
          -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 397 unchanged - 4 fixed = 399 total (was 401)
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 64m 31s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          83m 48s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.TestDatanodeConfig



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10638
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832751/HDFS-10638.004.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9d763088c512 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8a09bf7
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17109/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17109/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17109/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17109/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 47s trunk passed +1 compile 0m 43s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 40s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 51s the patch passed +1 javac 0m 51s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 397 unchanged - 4 fixed = 399 total (was 401) +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 64m 31s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 83m 48s Reason Tests Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestDatanodeConfig Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10638 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832751/HDFS-10638.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9d763088c512 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8a09bf7 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17109/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17109/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17109/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17109/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          virajith Virajith Jalaparti added a comment -

          The checkstyle warnings are due to moving (existing) code.

          The failing test cases are not related to the patch, and seem spurious. Both run successfully, locally.

          No new tests were added as the patch (1) mainly replaces usage of StorageLocation::getFile with StorageLocation::getURI, and StorageLocation, and (2) moves code (makeBlockPoolDataDir) to a new location. Existing tests (e.g., TestDataNodeHotSwapVolumes) already test these code paths.

          Show
          virajith Virajith Jalaparti added a comment - The checkstyle warnings are due to moving (existing) code. The failing test cases are not related to the patch, and seem spurious. Both run successfully, locally. No new tests were added as the patch (1) mainly replaces usage of StorageLocation::getFile with StorageLocation::getURI , and StorageLocation , and (2) moves code ( makeBlockPoolDataDir ) to a new location. Existing tests (e.g., TestDataNodeHotSwapVolumes ) already test these code paths.
          Hide
          virajith Virajith Jalaparti added a comment -

          Hi Lei (Eddy) Xu, I have fixed this in the new patch (004). Please take a look when you get a chance. Thanks!

          Show
          virajith Virajith Jalaparti added a comment - Hi Lei (Eddy) Xu , I have fixed this in the new patch (004). Please take a look when you get a chance. Thanks!
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Virajith Jalaparti

          Thanks for addressing my comments.

              // for local replicas, the replica location is assumed to be a file.
              File diskFile = null;
              try {
                diskFile = new File(replicaLocation.getUri());
              } catch (NullPointerException | IllegalArgumentException e) {
                diskFile = null;
              }
          
          • Catching NullPointerException here seems suspicious to me. Could you tell which one is potentially null? replicaLocation or getUrl() -> baseUrl?
          • For StorageLocation#toString(), it might be good to just print URI itself instead of its path to be more verbose.
          • public File getBpFile(String bpid, String currentStorageDir) }}, renamed to {{getBpDir(...)?
          • Should we mark StorageLocation#getFile as deprecated?

          One more question, as we are going to remove File from StorageLocation. Should we just remove StorageLocation#file and StorageLocation#getFile() once for all? I took a simple scan of the code base, getFile() is used 35 times, while 10 usages are in the scope of StorageLocation and StorageDirectory, while rest of them are all in the tests. So I think it'd be rather safe to remove them in hadoop 3. What do you think?

          • Should StorageLocation#matchesStorageDirectory()}}s be moved to {{StorageDirectory class?
          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Virajith Jalaparti Thanks for addressing my comments. // for local replicas, the replica location is assumed to be a file. File diskFile = null ; try { diskFile = new File(replicaLocation.getUri()); } catch (NullPointerException | IllegalArgumentException e) { diskFile = null ; } Catching NullPointerException here seems suspicious to me. Could you tell which one is potentially null ? replicaLocation or getUrl() -> baseUrl ? For StorageLocation#toString() , it might be good to just print URI itself instead of its path to be more verbose. public File getBpFile(String bpid, String currentStorageDir) }}, renamed to {{getBpDir(...) ? Should we mark StorageLocation#getFile as deprecated? One more question, as we are going to remove File from StorageLocation . Should we just remove StorageLocation#file and StorageLocation#getFile() once for all? I took a simple scan of the code base, getFile() is used 35 times, while 10 usages are in the scope of StorageLocation and StorageDirectory , while rest of them are all in the tests. So I think it'd be rather safe to remove them in hadoop 3. What do you think? Should StorageLocation#matchesStorageDirectory()}}s be moved to {{StorageDirectory class?
          Hide
          virajith Virajith Jalaparti added a comment -

          Hi Lei (Eddy) Xu, Thank you for the comments!

          Should we mark StorageLocation#getFile as deprecated?

          Should we just remove StorageLocation#file and StorageLocation#getFile() once for all?

          So, are you proposing to replace all invocations of StorageLocation#getFile() with, say, StorageLocation#getURI()? I think this makes sense. The reason I didn't do this was because some of the tests use File#getCanonicalPath to compare File objects. I don't think an equivalent exists for URIs unless we explicitly add a StorageLocation#getCanonicalURI. However, as an equivalent call does not exist in java.net.URI, this would be a non-standard way of doing it.

          One solution for this would be to modify the tests to replace calls to File#getCanonicalPath to use normalized URIs.

          In StorageDirectory, we can replace StorageLocation#getFile() with StorageLocation#getURI(), and try to resolve it as a File internally.

          Does this solution make sense?

          Should StorageLocation#matchesStorageDirectory()}}s be moved to {{StorageDirectory class?

          Any particular reason for this? If we move it to StorageDirectory, we would have a StorageDirectory#matchesStorageLocation function, which seems equivalent to what we have currently.

          Catching NullPointerException here seems suspicious to me.

          I added this to address the case where replicaLocation.getUri() might return null. However, if replicaLocation is constructed correctly, that should not be the case. I will remove this.

          I agree with the others, and will address them in the next patch.

          Show
          virajith Virajith Jalaparti added a comment - Hi Lei (Eddy) Xu , Thank you for the comments! Should we mark StorageLocation#getFile as deprecated? Should we just remove StorageLocation#file and StorageLocation#getFile() once for all? So, are you proposing to replace all invocations of StorageLocation#getFile() with, say, StorageLocation#getURI() ? I think this makes sense. The reason I didn't do this was because some of the tests use File#getCanonicalPath to compare File objects. I don't think an equivalent exists for URIs unless we explicitly add a StorageLocation#getCanonicalURI . However, as an equivalent call does not exist in java.net.URI , this would be a non-standard way of doing it. One solution for this would be to modify the tests to replace calls to File#getCanonicalPath to use normalized URIs. In StorageDirectory , we can replace StorageLocation#getFile() with StorageLocation#getURI() , and try to resolve it as a File internally. Does this solution make sense? Should StorageLocation#matchesStorageDirectory()}}s be moved to {{StorageDirectory class? Any particular reason for this? If we move it to StorageDirectory , we would have a StorageDirectory#matchesStorageLocation function, which seems equivalent to what we have currently. Catching NullPointerException here seems suspicious to me. I added this to address the case where replicaLocation.getUri() might return null . However, if replicaLocation is constructed correctly, that should not be the case. I will remove this. I agree with the others, and will address them in the next patch.
          Hide
          virajith Virajith Jalaparti added a comment -

          Attaching a new patch based on Lei (Eddy) Xu's comments. It completely removes File from StorageLocation, and uses an URI instead. One of the results of this is that VolumeFailureSummary.getFailedStorageLocations() now returns an array of strings that are URIs and not file paths. While VolumeFailureSummary is reported from the Datanode to the Namenode in the heartbeats, VolumeFailureSummary.getFailedStorageLocations() is not used to determine which StorageLocation s actually failed. If this changes in the future, it needs to be noted that these strings are actually URIs.

          Show
          virajith Virajith Jalaparti added a comment - Attaching a new patch based on Lei (Eddy) Xu 's comments. It completely removes File from StorageLocation , and uses an URI instead. One of the results of this is that VolumeFailureSummary.getFailedStorageLocations() now returns an array of strings that are URIs and not file paths. While VolumeFailureSummary is reported from the Datanode to the Namenode in the heartbeats, VolumeFailureSummary.getFailedStorageLocations() is not used to determine which StorageLocation s actually failed. If this changes in the future, it needs to be noted that these strings are actually URIs.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 40s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 11 new or modified test files.
          +1 mvninstall 8m 15s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 44s trunk passed
          +1 javadoc 0m 39s trunk passed
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 564 unchanged - 7 fixed = 566 total (was 571)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 39s the patch passed
          -1 unit 79m 35s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          100m 38s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-10638
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834583/HDFS-10638.005.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 348d057a729b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 262827c
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17245/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17245/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17245/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 40s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 11 new or modified test files. +1 mvninstall 8m 15s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 34s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 44s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 47s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed -0 checkstyle 0m 31s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 564 unchanged - 7 fixed = 566 total (was 571) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 39s the patch passed -1 unit 79m 35s hadoop-hdfs in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 100m 38s Reason Tests Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10638 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834583/HDFS-10638.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 348d057a729b 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 262827c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17245/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17245/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17245/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17245/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          virajith Virajith Jalaparti added a comment -

          Failing test case is unrelated to the patch.

          Show
          virajith Virajith Jalaparti added a comment - Failing test case is unrelated to the patch.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          +1 . Thanks for the good work!

          I re-run the failed test and it passes on my laptop. So I commit the patch to trunk.

          Show
          eddyxu Lei (Eddy) Xu added a comment - +1 . Thanks for the good work! I re-run the failed test and it passes on my laptop. So I commit the patch to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10689 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10689/)
          HDFS-10638. Modifications to remove the assumption that StorageLocation (lei: rev f209e93566b159c22054dcb276e45f23a2b7b7d1)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataDirs.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/StorageLocation.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetTestUtil.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/LocalReplica.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestNameNodePrunesMissingStorages.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockScanner.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataStorage.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10689 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10689/ ) HDFS-10638 . Modifications to remove the assumption that StorageLocation (lei: rev f209e93566b159c22054dcb276e45f23a2b7b7d1) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailureReporting.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeVolumeFailure.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDiskError.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataDirs.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/StorageLocation.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/LocalReplica.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeHotSwapVolumes.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestNameNodePrunesMissingStorages.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockScanner.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataStorage.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10769 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10769/)
          HDFS-11098. Datanode in tests cannot start in Windows after HDFS-10638 (vinayakumarb: rev 69dd5fa2d43eefeec112f36b91a13513ac21a763)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/StorageLocation.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10769 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10769/ ) HDFS-11098 . Datanode in tests cannot start in Windows after HDFS-10638 (vinayakumarb: rev 69dd5fa2d43eefeec112f36b91a13513ac21a763) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/StorageLocation.java

            People

            • Assignee:
              virajith Virajith Jalaparti
              Reporter:
              virajith Virajith Jalaparti
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development