Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10603

Fix flaky tests in org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: hdfs, namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Test
      org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot.testWithCheckpoint

      may fail intermittently as

      -------------------------------------------------------
       T E S T S
      -------------------------------------------------------
      Running org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
      Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 63.386 sec <<< FAILURE! - in org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
      testWithCheckpoint(org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot)  Time elapsed: 15.092 sec  <<< ERROR!
      java.io.IOException: Timed out waiting for Mini HDFS Cluster to start
      	at org.apache.hadoop.hdfs.MiniDFSCluster.waitClusterUp(MiniDFSCluster.java:1363)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2041)
      	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2011)
      	at org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot.testWithCheckpoint(TestOpenFilesWithSnapshot.java:94)
      
      
      Results :
      
      Tests in error: 
        TestOpenFilesWithSnapshot.testWithCheckpoint:94 ยป IO Timed out waiting for Min...
      
      Tests run: 7, Failures: 0, Errors: 1, Skipped: 0
      
      
      1. HDFS-10603.001.patch
        2 kB
        Yiqun Lin
      2. HDFS-10603.002.patch
        3 kB
        Yiqun Lin

        Activity

        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Yongjun Zhang for reporting this. I tested this unit test many times in my local env. Every time the test failed, I found it always costed some time in processReport, the output log like these:

        2016-07-10 20:04:56,585 [Block report processor] INFO  blockmanagement.BlockManager (BlockManager.java:processReport(2178)) - Processing first storage report for DS-7cd4704a-096b-4f6d-aa4f-6f7f74798e53 from datanode 154b2810-2bb9-4ec5-bdb3-c8d38988adae
        2016-07-10 20:04:56,586 [Block report processor] INFO  BlockStateChange (BlockManager.java:processReport(2229)) - BLOCK* processReport: from storage DS-7cd4704a-096b-4f6d-aa4f-6f7f74798e53 node DatanodeRegistration(127.0.0.1:49884, datanodeUuid=154b2810-2bb9-4ec5-bdb3-c8d38988adae, infoPort=49886, infoSecurePort=0, ipcPort=49887, storageInfo=lv=-57;cid=testClusterID;nsid=653559418;c=1468152288554), blocks: 2, hasStaleStorage: true, processing time: 1 msecs, invalidatedBlocks: 0
        2016-07-10 20:04:56,586 [Block report processor] INFO  blockmanagement.BlockManager (BlockManager.java:processReport(2178)) - Processing first storage report for DS-3917a777-191f-448b-be88-2396c5308ab6 from datanode 154b2810-2bb9-4ec5-bdb3-c8d38988adae
        2016-07-10 20:04:56,586 [Block report processor] INFO  BlockStateChange (BlockManager.java:processReport(2229)) - BLOCK* processReport: from storage DS-3917a777-191f-448b-be88-2396c5308ab6 node DatanodeRegistration(127.0.0.1:49884, datanodeUuid=154b2810-2bb9-4ec5-bdb3-c8d38988adae, infoPort=49886, infoSecurePort=0, ipcPort=49887, storageInfo=lv=-57;cid=testClusterID;nsid=653559418;c=1468152288554), blocks: 2, hasStaleStorage: false, processing time: 1 msecs, invalidatedBlocks: 0
        2016-07-10 20:04:56,587 [DataNode: [[[DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data5/, [DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data6/]]  heartbeating to localhost/127.0.0.1:49874] INFO  datanode.DataNode (BPServiceActor.java:blockReport(389)) - Successfully sent block report 0x665205cb9591e953,  containing 2 storage report(s), of which we sent 2. The reports had 4 total blocks and used 1 RPC(s). This took 1 msec to generate and 3 msecs for RPC and NN processing. Got back one command: FinalizeCommand/5.
        2016-07-10 20:04:56,587 [DataNode: [[[DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data5/, [DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data6/]]  heartbeating to localhost/127.0.0.1:49874] INFO  datanode.DataNode (BPOfferService.java:processCommandFromActive(696)) - Got finalize command for block pool BP-1517015184-127.0.0.1-1468152288554
        2016-07-10 20:04:57,410 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:04:58,417 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:04:59,422 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:05:00,423 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:05:01,425 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:05:02,430 [main] WARN  hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start...
        2016-07-10 20:05:03,435 [main] ERROR hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1362)) - Timed out waiting for Mini HDFS Cluster to start
        

        And then the cluster start timeout. So I added a line cluster.triggerBlockReports(); before the operation cluster.restartNameNode(true);, it will speed this. I tested again for this test many times with my change, the result were all passed.

        In addition, the failed test TestOpenFilesWithSnapshot#testParentDirWithUCFileDeleteWithSnapShot that showed in HDFS-10512(https://builds.apache.org/job/PreCommit-HDFS-Build/16005/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) and the similar test TestOpenFilesWithSnapshot#testUCFileDeleteWithSnapShot are both have this problem. I also did a triggerBlockReports and savenamespace operations to speed the cluster startup.

        Post the patch from me.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Yongjun Zhang for reporting this. I tested this unit test many times in my local env. Every time the test failed, I found it always costed some time in processReport, the output log like these: 2016-07-10 20:04:56,585 [Block report processor] INFO blockmanagement.BlockManager (BlockManager.java:processReport(2178)) - Processing first storage report for DS-7cd4704a-096b-4f6d-aa4f-6f7f74798e53 from datanode 154b2810-2bb9-4ec5-bdb3-c8d38988adae 2016-07-10 20:04:56,586 [Block report processor] INFO BlockStateChange (BlockManager.java:processReport(2229)) - BLOCK* processReport: from storage DS-7cd4704a-096b-4f6d-aa4f-6f7f74798e53 node DatanodeRegistration(127.0.0.1:49884, datanodeUuid=154b2810-2bb9-4ec5-bdb3-c8d38988adae, infoPort=49886, infoSecurePort=0, ipcPort=49887, storageInfo=lv=-57;cid=testClusterID;nsid=653559418;c=1468152288554), blocks: 2, hasStaleStorage: true , processing time: 1 msecs, invalidatedBlocks: 0 2016-07-10 20:04:56,586 [Block report processor] INFO blockmanagement.BlockManager (BlockManager.java:processReport(2178)) - Processing first storage report for DS-3917a777-191f-448b-be88-2396c5308ab6 from datanode 154b2810-2bb9-4ec5-bdb3-c8d38988adae 2016-07-10 20:04:56,586 [Block report processor] INFO BlockStateChange (BlockManager.java:processReport(2229)) - BLOCK* processReport: from storage DS-3917a777-191f-448b-be88-2396c5308ab6 node DatanodeRegistration(127.0.0.1:49884, datanodeUuid=154b2810-2bb9-4ec5-bdb3-c8d38988adae, infoPort=49886, infoSecurePort=0, ipcPort=49887, storageInfo=lv=-57;cid=testClusterID;nsid=653559418;c=1468152288554), blocks: 2, hasStaleStorage: false , processing time: 1 msecs, invalidatedBlocks: 0 2016-07-10 20:04:56,587 [DataNode: [[[DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data5/, [DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data6/]] heartbeating to localhost/127.0.0.1:49874] INFO datanode.DataNode (BPServiceActor.java:blockReport(389)) - Successfully sent block report 0x665205cb9591e953, containing 2 storage report(s), of which we sent 2. The reports had 4 total blocks and used 1 RPC(s). This took 1 msec to generate and 3 msecs for RPC and NN processing. Got back one command: FinalizeCommand/5. 2016-07-10 20:04:56,587 [DataNode: [[[DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data5/, [DISK]file:/Users/lyq/Documents/work-project/hadoop-trunk/hadoop/hadoop-hdfs-project/hadoop-hdfs/target/test/data/dfs/data/data6/]] heartbeating to localhost/127.0.0.1:49874] INFO datanode.DataNode (BPOfferService.java:processCommandFromActive(696)) - Got finalize command for block pool BP-1517015184-127.0.0.1-1468152288554 2016-07-10 20:04:57,410 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:04:58,417 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:04:59,422 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:05:00,423 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:05:01,425 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:05:02,430 [main] WARN hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1356)) - Waiting for the Mini HDFS Cluster to start... 2016-07-10 20:05:03,435 [main] ERROR hdfs.MiniDFSCluster (MiniDFSCluster.java:waitClusterUp(1362)) - Timed out waiting for Mini HDFS Cluster to start And then the cluster start timeout. So I added a line cluster.triggerBlockReports(); before the operation cluster.restartNameNode(true); , it will speed this. I tested again for this test many times with my change, the result were all passed. In addition, the failed test TestOpenFilesWithSnapshot#testParentDirWithUCFileDeleteWithSnapShot that showed in HDFS-10512 ( https://builds.apache.org/job/PreCommit-HDFS-Build/16005/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt ) and the similar test TestOpenFilesWithSnapshot#testUCFileDeleteWithSnapShot are both have this problem. I also did a triggerBlockReports and savenamespace operations to speed the cluster startup. Post the patch from me.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 27s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 54s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 42s trunk passed
        +1 javadoc 0m 55s trunk passed
        +1 mvninstall 0m 45s the patch passed
        +1 compile 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 47s the patch passed
        +1 javadoc 0m 51s the patch passed
        -1 unit 73m 14s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        92m 26s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.server.namenode.TestEditLog



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817034/HDFS-10603.001.patch
        JIRA Issue HDFS-10603
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a3e6a705a4c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9bdb5be
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16014/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16014/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16014/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 27s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 54s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 55s trunk passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 51s the patch passed -1 unit 73m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 92m 26s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestFsDatasetCache   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestEditLog Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817034/HDFS-10603.001.patch JIRA Issue HDFS-10603 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a3e6a705a4c1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9bdb5be Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16014/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16014/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16014/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        linyiqun Yiqun Lin added a comment -

        I found the test TestOpenFilesWithSnapshot#testOpenFilesWithRename also failed sometimes. The stack infos:

        org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        testOpenFilesWithRename(org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot)  Time elapsed: 14.069 sec  <<< ERROR!
        java.io.IOException: Timed out waiting for Mini HDFS Cluster to start
        	at org.apache.hadoop.hdfs.MiniDFSCluster.waitClusterUp(MiniDFSCluster.java:1363)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2041)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2011)
        	at org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot.testOpenFilesWithRename(TestOpenFilesWithSnapshot.java:210)
        

        Then I made a code review in other tests in TestOpenFilesWithSnapshot and did the fix. Post the new patch, pending jenkins.

        Show
        linyiqun Yiqun Lin added a comment - I found the test TestOpenFilesWithSnapshot#testOpenFilesWithRename also failed sometimes. The stack infos: org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot testOpenFilesWithRename(org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot) Time elapsed: 14.069 sec <<< ERROR! java.io.IOException: Timed out waiting for Mini HDFS Cluster to start at org.apache.hadoop.hdfs.MiniDFSCluster.waitClusterUp(MiniDFSCluster.java:1363) at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2041) at org.apache.hadoop.hdfs.MiniDFSCluster.restartNameNode(MiniDFSCluster.java:2011) at org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot.testOpenFilesWithRename(TestOpenFilesWithSnapshot.java:210) Then I made a code review in other tests in TestOpenFilesWithSnapshot and did the fix. Post the new patch, pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 53s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 28s trunk passed
        +1 mvnsite 0m 58s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 1m 1s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 55s the patch passed
        +1 javac 0m 55s the patch passed
        +1 checkstyle 0m 25s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 77m 14s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        97m 29s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817098/HDFS-10603.002.patch
        JIRA Issue HDFS-10603
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d41b002fcec3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0fd3980
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/16016/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16016/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16016/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 53s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 1m 1s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 55s the patch passed +1 javac 0m 55s the patch passed +1 checkstyle 0m 25s the patch passed +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 77m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 97m 29s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817098/HDFS-10603.002.patch JIRA Issue HDFS-10603 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d41b002fcec3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fd3980 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/16016/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16016/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16016/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Nice catch Yiqun Lin, +1 for the latest patch. I'll commit this tomorrow if there are no objections.

        Show
        ajisakaa Akira Ajisaka added a comment - Nice catch Yiqun Lin , +1 for the latest patch. I'll commit this tomorrow if there are no objections.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks for working on this Yiqun Lin, nice catch! Thanks Akira Ajisaka for the review, My +1 too.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks for working on this Yiqun Lin , nice catch! Thanks Akira Ajisaka for the review, My +1 too.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution and thanks Yongjun Zhang for the review!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Yiqun Lin for the contribution and thanks Yongjun Zhang for the review!
        Hide
        linyiqun Yiqun Lin added a comment -

        Thanks Akira Ajisaka for the commit, and thanks Yongjun Zhang for the review.

        Show
        linyiqun Yiqun Lin added a comment - Thanks Akira Ajisaka for the commit, and thanks Yongjun Zhang for the review.

          People

          • Assignee:
            linyiqun Yiqun Lin
            Reporter:
            yzhangal Yongjun Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development