Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10570

Remove classpath conflicts of netty-all jar in hadoop-hdfs-client

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      While debugging tests in eclipse, Cannot access DN http url.
      Also WebHdfs tests cannot run in eclipse due to classes loading from old version of netty jars instead of netty-all jar.

      1. HDFS-10570-01.patch
        1 kB
        Vinayakumar B
      2. HDFS-10570-02.patch
        2 kB
        Vinayakumar B
      3. HDFS-10570-branch-2.8-02.patch
        2 kB
        Steve Loughran

        Activity

        Hide
        vinayrpet Vinayakumar B added a comment -

        Attached the patch to change the order

        Show
        vinayrpet Vinayakumar B added a comment - Attached the patch to change the order
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 43s trunk passed
        +1 compile 0m 48s trunk passed
        +1 mvnsite 0m 55s trunk passed
        +1 mvneclipse 0m 11s trunk passed
        +1 javadoc 0m 53s trunk passed
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 44s the patch passed
        +1 javac 0m 44s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 53s the patch passed
        -1 unit 69m 36s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        84m 19s



        Reason Tests
        Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          hadoop.hdfs.server.datanode.TestDataNodeMXBean



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:85209cc
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814091/HDFS-10570-01.patch
        JIRA Issue HDFS-10570
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 9982d58dfb9a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2a0082c
        Default Java 1.8.0_91
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15931/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15931/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15931/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 43s trunk passed +1 compile 0m 48s trunk passed +1 mvnsite 0m 55s trunk passed +1 mvneclipse 0m 11s trunk passed +1 javadoc 0m 53s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 53s the patch passed -1 unit 69m 36s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 84m 19s Reason Tests Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.server.datanode.TestDataNodeMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12814091/HDFS-10570-01.patch JIRA Issue HDFS-10570 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 9982d58dfb9a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2a0082c Default Java 1.8.0_91 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15931/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15931/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15931/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        does this mean that there are conflicting versions of netty in the CP here? As that needs to be fixed. Changing the order of the CP simply by re-ordering declarations in maven is a dangerous approach as it's an mvn feature that most people don't know of, and isn't, AFAIK, guaranteed to hold over time

        Show
        stevel@apache.org Steve Loughran added a comment - does this mean that there are conflicting versions of netty in the CP here? As that needs to be fixed. Changing the order of the CP simply by re-ordering declarations in maven is a dangerous approach as it's an mvn feature that most people don't know of, and isn't, AFAIK, guaranteed to hold over time
        Hide
        vinayrpet Vinayakumar B added a comment -

        Yes you are right Steve Loughran. There are multiple versions of netty jars.

        Attaching the patch to exclude duplicates.

        Show
        vinayrpet Vinayakumar B added a comment - Yes you are right Steve Loughran . There are multiple versions of netty jars. Attaching the patch to exclude duplicates.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 35s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 6s trunk passed
        +1 compile 0m 30s trunk passed
        +1 mvnsite 0m 35s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 28s the patch passed
        +1 javac 0m 28s the patch passed
        +1 mvnsite 0m 31s the patch passed
        +1 mvneclipse 0m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 18s the patch passed
        +1 unit 0m 53s hadoop-hdfs-client in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        13m 30s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817475/HDFS-10570-02.patch
        JIRA Issue HDFS-10570
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 39d9654e20f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7705812
        Default Java 1.8.0_91
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16029/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16029/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 6s trunk passed +1 compile 0m 30s trunk passed +1 mvnsite 0m 35s trunk passed +1 mvneclipse 0m 12s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 18s the patch passed +1 unit 0m 53s hadoop-hdfs-client in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 13m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817475/HDFS-10570-02.patch JIRA Issue HDFS-10570 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 39d9654e20f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7705812 Default Java 1.8.0_91 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16029/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16029/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        +1, committed to trunk.

        I haven't yet cherry picked it to branch-2; adding a patch for yetus to test there before dong that

        Show
        stevel@apache.org Steve Loughran added a comment - +1, committed to trunk. I haven't yet cherry picked it to branch-2; adding a patch for yetus to test there before dong that
        Hide
        stevel@apache.org Steve Loughran added a comment -

        -02 patch renamed for a 2.8 test run

        Show
        stevel@apache.org Steve Loughran added a comment - -02 patch renamed for a 2.8 test run
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10097 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10097/)
        HDFS-10570. Remove classpath conflicts of netty-all jar in (stevel: rev 1fa1fab695355fadb7898efb6d0d03fc88513466)

        • hadoop-hdfs-project/hadoop-hdfs-client/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10097 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10097/ ) HDFS-10570 . Remove classpath conflicts of netty-all jar in (stevel: rev 1fa1fab695355fadb7898efb6d0d03fc88513466) hadoop-hdfs-project/hadoop-hdfs-client/pom.xml
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 9m 55s branch-2.8 passed
        +1 compile 0m 29s branch-2.8 passed with JDK v1.8.0_91
        +1 compile 0m 30s branch-2.8 passed with JDK v1.7.0_101
        +1 mvnsite 0m 37s branch-2.8 passed
        +1 mvneclipse 0m 18s branch-2.8 passed
        +1 javadoc 0m 22s branch-2.8 passed with JDK v1.8.0_91
        +1 javadoc 0m 25s branch-2.8 passed with JDK v1.7.0_101
        +1 mvninstall 0m 32s the patch passed
        +1 compile 0m 26s the patch passed with JDK v1.8.0_91
        +1 javac 0m 26s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_101
        +1 javac 0m 28s the patch passed
        +1 mvnsite 0m 33s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 javadoc 0m 19s the patch passed with JDK v1.8.0_91
        +1 javadoc 0m 22s the patch passed with JDK v1.7.0_101
        +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        33m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817915/HDFS-10570-branch-2.8-02.patch
        JIRA Issue HDFS-10570
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 817aa2a2a808 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / cbd885b
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16055/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16055/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 55s branch-2.8 passed +1 compile 0m 29s branch-2.8 passed with JDK v1.8.0_91 +1 compile 0m 30s branch-2.8 passed with JDK v1.7.0_101 +1 mvnsite 0m 37s branch-2.8 passed +1 mvneclipse 0m 18s branch-2.8 passed +1 javadoc 0m 22s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 0m 25s branch-2.8 passed with JDK v1.7.0_101 +1 mvninstall 0m 32s the patch passed +1 compile 0m 26s the patch passed with JDK v1.8.0_91 +1 javac 0m 26s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_101 +1 javac 0m 28s the patch passed +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 javadoc 0m 19s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_101 +1 unit 1m 5s hadoop-hdfs-client in the patch passed with JDK v1.7.0_101. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 33m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817915/HDFS-10570-branch-2.8-02.patch JIRA Issue HDFS-10570 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 817aa2a2a808 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / cbd885b Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/16055/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client Console output https://builds.apache.org/job/PreCommit-HDFS-Build/16055/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Ported this to branch-2.8 and branch-2 as well.
        Thanks Steve Loughran for review.

        Show
        vinayrpet Vinayakumar B added a comment - Ported this to branch-2.8 and branch-2 as well. Thanks Steve Loughran for review.

          People

          • Assignee:
            vinayrpet Vinayakumar B
            Reporter:
            vinayrpet Vinayakumar B
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development