Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10576 DiskBalancer followup work items
  3. HDFS-10566

Submit plan request should throw exception if Datanode is in non-REGULAR status.

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: datanode
    • Labels:
      None

      Description

      If datanode is in non-REGULAR status such as upgrade and rollback etc., it might be simpler to just refuse balancing.

      1. HDFS-10566.001.patch
        10 kB
        Xiaobing Zhou
      2. HDFS-10566.000.patch
        9 kB
        Xiaobing Zhou

        Activity

        Hide
        anu Anu Engineer added a comment -

        Xiaobing Zhou Is there anything I can do to expedite this ? I am trying to resolve HDFS-10576. This is one of the issues that needs to be fixed before resolving 10576. Please let me know if you need anything or if you would like me to work on this.

        Show
        anu Anu Engineer added a comment - Xiaobing Zhou Is there anything I can do to expedite this ? I am trying to resolve HDFS-10576 . This is one of the issues that needs to be fixed before resolving 10576. Please let me know if you need anything or if you would like me to work on this.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        Anu Engineer I posted initial patch v000, please help to review it, thanks.

        Show
        xiaobingo Xiaobing Zhou added a comment - Anu Engineer I posted initial patch v000, please help to review it, thanks.
        Hide
        anu Anu Engineer added a comment - - edited

        Xiaobing Zhou Thank you submitting the patch. It looks very good overall.

        Had a minor comment. Instead of throwing an IOException in Datanode.java, would it be possible to throw a DiskBalancerException.
        You would first need to add a corresponding state in DiskBalancerException.result enum. Say DATANODE_STATUS_NOT_REGULAR.

        Then in the exception we can say something like

         throw new DiskBalancerException("Datanode is in special state. Upgrade/Rollback etc. Disk balancing not permitted.", DiskBalancerException.Result.DATANODE_STATUS_NOT_REGULAR);
         
        Show
        anu Anu Engineer added a comment - - edited Xiaobing Zhou Thank you submitting the patch. It looks very good overall. Had a minor comment. Instead of throwing an IOException in Datanode.java , would it be possible to throw a DiskBalancerException. You would first need to add a corresponding state in DiskBalancerException.result enum. Say DATANODE_STATUS_NOT_REGULAR. Then in the exception we can say something like throw new DiskBalancerException("Datanode is in special state. Upgrade/Rollback etc. Disk balancing not permitted.", DiskBalancerException.Result.DATANODE_STATUS_NOT_REGULAR);
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 8m 1s trunk passed
        +1 compile 0m 53s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 1m 51s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 51s the patch passed
        +1 compile 0m 50s the patch passed
        +1 javac 0m 50s the patch passed
        -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 163 unchanged - 0 fixed = 167 total (was 163)
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 0m 42s the patch passed
        +1 unit 76m 58s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        98m 19s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10566
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836474/HDFS-10566.000.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1fd2346d18a6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bd7f591
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17372/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17372/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17372/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 1s trunk passed +1 compile 0m 53s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 51s the patch passed +1 compile 0m 50s the patch passed +1 javac 0m 50s the patch passed -0 checkstyle 0m 29s hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 163 unchanged - 0 fixed = 167 total (was 163) +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 42s the patch passed +1 unit 76m 58s hadoop-hdfs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 98m 19s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10566 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836474/HDFS-10566.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1fd2346d18a6 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bd7f591 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17372/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17372/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17372/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        xiaobingo Xiaobing Zhou added a comment -

        v001 is posted.

        1. It addressed your comment, thanks Anu Engineer
        2. It fixed the check style issues.
        Show
        xiaobingo Xiaobing Zhou added a comment - v001 is posted. It addressed your comment, thanks Anu Engineer It fixed the check style issues.
        Hide
        anu Anu Engineer added a comment -

        Xiaobing Zhou Thank you for updating the patch. +1, pending jenkins.

        Show
        anu Anu Engineer added a comment - Xiaobing Zhou Thank you for updating the patch. +1, pending jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 28s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 9m 52s trunk passed
        +1 compile 0m 45s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 0m 54s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 43s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 28s the patch passed
        +1 mvnsite 0m 52s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 1s The patch has no whitespace issues.
        +1 findbugs 1m 48s the patch passed
        +1 javadoc 0m 38s the patch passed
        -1 unit 84m 1s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 22s The patch does not generate ASF License warnings.
        106m 23s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Issue HDFS-10566
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836602/HDFS-10566.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 980b42955362 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0dc2a6a
        Default Java 1.8.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/17386/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17386/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17386/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 28s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 52s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 43s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 49s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 28s the patch passed +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 1m 48s the patch passed +1 javadoc 0m 38s the patch passed -1 unit 84m 1s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 106m 23s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-10566 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12836602/HDFS-10566.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 980b42955362 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0dc2a6a Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/17386/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17386/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17386/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        anu Anu Engineer added a comment -

        Xiaobing Zhou Thank you for the contribution. I have committed this to trunk.

        Show
        anu Anu Engineer added a comment - Xiaobing Zhou Thank you for the contribution. I have committed this to trunk.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10758 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10758/)
        HDFS-10566. Submit plan request should throw exception if Datanode is in (aengineer: rev 730cb0cff6a6e2f1a6eef3593568e8a1b5172cf7)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/diskbalancer/DiskBalancerTestUtil.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/DiskBalancerException.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/diskbalancer/command/TestDiskBalancerCommand.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10758 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10758/ ) HDFS-10566 . Submit plan request should throw exception if Datanode is in (aengineer: rev 730cb0cff6a6e2f1a6eef3593568e8a1b5172cf7) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/diskbalancer/DiskBalancerTestUtil.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/diskbalancer/DiskBalancerException.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/diskbalancer/command/TestDiskBalancerCommand.java

          People

          • Assignee:
            xiaobingo Xiaobing Zhou
            Reporter:
            jnp Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development