[HDFS-10554] libhdfs++: signed to unsigned conversions are breaking things and compiler isn't issuing expected warnings

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: hdfs-client
• Assignee: James Clampffer
• Reporter: James Clampffer
• Created: 21/Jun/16 21:41
• Updated: 26/Oct/18 13:00

Description

There's at least two places where we use -1 to indicate unset/default values that end up getting cast into unsigned integers. The compiler should be smart enough to figure this out and issue a warning but it's not; we need to find out what's going on there. We also need to fix the places where this sort of thing has found its way into the code:

In URI

      // -1 if the port is undefined.
      optional<uint16_t> get_port() const
      { return port; }

In Options (gets cast to uint64_t somewhere)

    /**
     * Maximum number of retries for RPC operations
     **/
    int max_rpc_retries;
    static const int kNoRetry = -1;