[HDFS-10527] libhdfs++: hdfsGetBlockLocations doesn't null terminate ip address strings

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Component/s: hdfs-client
• Assignee: James Clampffer
• Reporter: James Clampffer
• Created: 14/Jun/16 19:28
• Updated: 22/Mar/18 21:57
• Resolved: 16/Jun/16 17:23

Description

Code looks like this

strncpy(buf, ipaddr.c_str(),ipaddr.size());

But should be

strncpy(buf, ipaddr.c_str(),ipaddr.size()+1);

In order to make sure there is at least 1 null terminating byte. If we could run the minidfscluster an another process and run valgrind on the libhdfs++ tests this would show up really quickly as a sequence of invalid reads when that const char* was passed to std::string::string(const char*), strlen, or strcpy.