Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10493

Add links to datanode web UI in namenode datanodes page

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode, ui
    • Labels:
      None

      Description

      HDFS-10440 makes some improvements to datanode UI, it will be good to provide links from namenode datanodes information page to individual datanode UI, to check more datanode information easily.

      1. secure_nn_dn_links.jpg
        46 kB
        Weiwei Yang
      2. NN_DN_Links.jpg
        54 kB
        Weiwei Yang
      3. HDFS-10493.002.patch
        3 kB
        Weiwei Yang
      4. HDFS-10493.001.patch
        2 kB
        Weiwei Yang
      5. dn_http_addr_links.002.jpg
        51 kB
        Weiwei Yang
      6. dn_2_alive_1_down.002.jpg
        53 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment -

          I have tested the patch on latest trunk, using HTTP policy (default), and the links work fine, see NN_DN_Links.jpg, I also tested the patch on a 2.7.2 cluster with HTTPS enabled, it also works fine, see secure_nn_dn_links.jpg. Please kindly review and comment. Thank you.

          Show
          cheersyang Weiwei Yang added a comment - I have tested the patch on latest trunk, using HTTP policy (default), and the links work fine, see NN_DN_Links.jpg , I also tested the patch on a 2.7.2 cluster with HTTPS enabled, it also works fine, see secure_nn_dn_links.jpg . Please kindly review and comment. Thank you.
          Hide
          kihwal Kihwal Lee added a comment -

          It looks a bit funny because "name" contains the xferAddr, but the link contains the infoAddr. The hostname:xfer_port identifies a dn process, so that is probably the best choice as a displayable unique name. We could leave the name as unlinked text and add additional text to associate with the infoAddr link, something like "info", "status" or "details". What do you think?

          Show
          kihwal Kihwal Lee added a comment - It looks a bit funny because "name" contains the xferAddr, but the link contains the infoAddr. The hostname:xfer_port identifies a dn process, so that is probably the best choice as a displayable unique name. We could leave the name as unlinked text and add additional text to associate with the infoAddr link, something like "info", "status" or "details". What do you think?
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Kihwal Lee

          I agree with your comment, so I add a column "Http Address" for the info links, this is just like the links on Yarn nodes page. I just uploaded v2 patch, the screen shot can be seen here dn_http_addr_links.002.jpg when there is some datanodes down, the UI looks like dn_2_alive_1_down.002.jpg. Please help to review, appreciate your suggestions.

          Thank you

          Show
          cheersyang Weiwei Yang added a comment - Hello Kihwal Lee I agree with your comment, so I add a column "Http Address" for the info links, this is just like the links on Yarn nodes page. I just uploaded v2 patch, the screen shot can be seen here dn_http_addr_links.002.jpg when there is some datanodes down, the UI looks like dn_2_alive_1_down.002.jpg . Please help to review, appreciate your suggestions. Thank you
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 asflicense 0m 14s The patch does not generate ASF License warnings.
          0m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811318/HDFS-10493.002.patch
          JIRA Issue HDFS-10493
          Optional Tests asflicense
          uname Linux 1cb7e7cbfaac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 09e82ac
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15802/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 0m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12811318/HDFS-10493.002.patch JIRA Issue HDFS-10493 Optional Tests asflicense uname Linux 1cb7e7cbfaac 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09e82ac modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15802/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Just a note, though this one is marked as related to HDFS-10440, but the patch is self-contained and it can be reviewed and committed independently.

          Show
          cheersyang Weiwei Yang added a comment - Just a note, though this one is marked as related to HDFS-10440 , but the patch is self-contained and it can be reviewed and committed independently.
          Hide
          kihwal Kihwal Lee added a comment -

          +1 The patch Looks good

          Show
          kihwal Kihwal Lee added a comment - +1 The patch Looks good
          Hide
          kihwal Kihwal Lee added a comment -

          I've committed to trunk, branch-2 and branch-2.8. Thanks for the path, Weiwei Yang.

          Show
          kihwal Kihwal Lee added a comment - I've committed to trunk, branch-2 and branch-2.8. Thanks for the path, Weiwei Yang .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9979 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9979/)
          HDFS-10493. Add links to datanode web UI in namenode datanodes page. (kihwal: rev 280069510b71d81a150b2b28d9fa987891d82774)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9979 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9979/ ) HDFS-10493 . Add links to datanode web UI in namenode datanodes page. (kihwal: rev 280069510b71d81a150b2b28d9fa987891d82774) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks a lot Kihwal Lee

          Show
          cheersyang Weiwei Yang added a comment - Thanks a lot Kihwal Lee

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              cheersyang Weiwei Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development