Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If an interrupt comes in during an HDFS read - it looks like HDFS ends up ignoring it (handling it), and retries the read after an interval.

      An interrupt should result in the read being cancelled, with an InterruptedException being thrown.

      Similarly - if an HDFS op is started with the interrupt status on the thread set, an InterruptedException should be thrown.

      cc Jing Zhao

      1. log
        34 kB
        Siddharth Seth
      2. HDFS-10468.003.patch
        11 kB
        Jing Zhao
      3. HDFS-10468.002.patch
        11 kB
        Jing Zhao
      4. HDFS-10468.001.patch
        6 kB
        Jing Zhao
      5. HDFS-10468.000.patch
        1 kB
        Jing Zhao

        Activity

        Hide
        sseth Siddharth Seth added a comment -

        Messages from the log when this happened.

        Show
        sseth Siddharth Seth added a comment - Messages from the log when this happened.
        Hide
        jingzhao Jing Zhao added a comment -

        When the blockSeekTo gets ClosedByInterruptException, the IO channels have already been interrupted. Instead of retrying the read with other DataNodes for reading, maybe a better choice here is to check the current thread's interrupt state and throw the ClosedByInterruptException to upper level. Will upload a patch for this.

        Show
        jingzhao Jing Zhao added a comment - When the blockSeekTo gets ClosedByInterruptException , the IO channels have already been interrupted. Instead of retrying the read with other DataNodes for reading, maybe a better choice here is to check the current thread's interrupt state and throw the ClosedByInterruptException to upper level. Will upload a patch for this.
        Hide
        jingzhao Jing Zhao added a comment -

        Add a unit test. Also check InterruptIOException.

        Show
        jingzhao Jing Zhao added a comment - Add a unit test. Also check InterruptIOException .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 6m 13s trunk passed
        +1 compile 1m 29s trunk passed
        +1 checkstyle 0m 33s trunk passed
        +1 mvnsite 1m 27s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 3m 15s trunk passed
        +1 javadoc 1m 26s trunk passed
        0 mvndep 0m 6s Maven dependency ordering for patch
        +1 mvninstall 1m 20s the patch passed
        +1 compile 1m 46s the patch passed
        +1 javac 1m 46s the patch passed
        -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 2 new + 126 unchanged - 1 fixed = 128 total (was 127)
        +1 mvnsite 1m 42s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 40s the patch passed
        +1 javadoc 1m 28s the patch passed
        +1 unit 1m 3s hadoop-hdfs-client in the patch passed.
        -1 unit 75m 17s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        104m 28s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807025/HDFS-10468.001.patch
        JIRA Issue HDFS-10468
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 25c969128609 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 93d8a7f
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15607/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15607/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 6m 13s trunk passed +1 compile 1m 29s trunk passed +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 27s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 15s trunk passed +1 javadoc 1m 26s trunk passed 0 mvndep 0m 6s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 1m 46s the patch passed +1 javac 1m 46s the patch passed -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 2 new + 126 unchanged - 1 fixed = 128 total (was 127) +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 40s the patch passed +1 javadoc 1m 28s the patch passed +1 unit 1m 3s hadoop-hdfs-client in the patch passed. -1 unit 75m 17s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 104m 28s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807025/HDFS-10468.001.patch JIRA Issue HDFS-10468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 25c969128609 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 93d8a7f Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15607/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15607/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15607/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment - - edited

        Thanks for working on this, Jing Zhao.

        The test worked for me but the expected exception still seems to be thrown after some retries in DFSInputStream#readWithStrategy.

        In addition, there is another code path which swallows interrupted exception. For example, DFSInputStream#chooseDataNode catches InterruptedException on the sleep before retries.

                  DFSClient.LOG.warn("DFS chooseDataNode: got # " + (failures + 1) + " IOException, will wait for " + waitTime + " msec.");
                  Thread.sleep((long)waitTime);
                } catch (InterruptedException ignored) {
                }
        

        We do not have way out here since java.lang.Thread#sleep clears interrupted status before throwing Interrupted Exception.

        Show
        iwasakims Masatake Iwasaki added a comment - - edited Thanks for working on this, Jing Zhao . The test worked for me but the expected exception still seems to be thrown after some retries in DFSInputStream#readWithStrategy . In addition, there is another code path which swallows interrupted exception. For example, DFSInputStream#chooseDataNode catches InterruptedException on the sleep before retries. DFSClient.LOG.warn( "DFS chooseDataNode: got # " + (failures + 1) + " IOException, will wait for " + waitTime + " msec." ); Thread .sleep(( long )waitTime); } catch (InterruptedException ignored) { } We do not have way out here since java.lang.Thread#sleep clears interrupted status before throwing Interrupted Exception.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        there still seems to be code paths which swallows interrupted state.

        I ran modified TestRead#testInterruptReader against mini cluster with short-circuit local read enabled. The read with interrupted status succeeded after a retry when ShortCircuitCache.fetchOrCreate returns cached instance.

        Show
        iwasakims Masatake Iwasaki added a comment - there still seems to be code paths which swallows interrupted state. I ran modified TestRead#testInterruptReader against mini cluster with short-circuit local read enabled. The read with interrupted status succeeded after a retry when ShortCircuitCache.fetchOrCreate returns cached instance.
        Hide
        iwasakims Masatake Iwasaki added a comment -
        678	          DFSClient.LOG.warn("The reading thread has been interrupted: {}.", ex);
        

        nit: "{}" was not replaced since the second argument is Exception.

        2016-06-01 14:10:29,476 [Thread-95] WARN  hdfs.DFSClient (DFSInputStream.java:blockSeekTo(678)) - The reading thread has been interrupted: {}.
        java.nio.channels.ClosedByInterruptException
                at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202)
                ...
        
        Show
        iwasakims Masatake Iwasaki added a comment - 678 DFSClient.LOG.warn( "The reading thread has been interrupted: {}." , ex); nit: "{}" was not replaced since the second argument is Exception. 2016-06-01 14:10:29,476 [Thread-95] WARN hdfs.DFSClient (DFSInputStream.java:blockSeekTo(678)) - The reading thread has been interrupted: {}. java.nio.channels.ClosedByInterruptException at java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:202) ...
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for the review, Masatake Iwasaki. I agree there are still many places in DFSInputStream that have not correctly handle the interrupt. But considering the current complexity of the DFSInputStream code, I do not plan to fix all of them in this jira. To achieve that we may also need to do more code refactoring. Maybe we can create an umbrella jira for this later.

        I did another quick skim of the current DFSInputStream code and fixed several other places. Uploaded 002 patch.

        Show
        jingzhao Jing Zhao added a comment - Thanks for the review, Masatake Iwasaki . I agree there are still many places in DFSInputStream that have not correctly handle the interrupt. But considering the current complexity of the DFSInputStream code, I do not plan to fix all of them in this jira. To achieve that we may also need to do more code refactoring. Maybe we can create an umbrella jira for this later. I did another quick skim of the current DFSInputStream code and fixed several other places. Uploaded 002 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 37s trunk passed
        +1 compile 1m 24s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 1m 41s trunk passed
        +1 mvneclipse 0m 24s trunk passed
        +1 findbugs 3m 36s trunk passed
        +1 javadoc 1m 33s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 1m 31s the patch passed
        +1 compile 1m 40s the patch passed
        +1 javac 1m 40s the patch passed
        -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 125 unchanged - 2 fixed = 126 total (was 127)
        +1 mvnsite 1m 43s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 57s the patch passed
        +1 javadoc 1m 21s the patch passed
        +1 unit 0m 54s hadoop-hdfs-client in the patch passed.
        +1 unit 71m 51s hadoop-hdfs in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        101m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807518/HDFS-10468.002.patch
        JIRA Issue HDFS-10468
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1caa1310432e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0bc05e4
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15626/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15626/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15626/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 37s trunk passed +1 compile 1m 24s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 1m 41s trunk passed +1 mvneclipse 0m 24s trunk passed +1 findbugs 3m 36s trunk passed +1 javadoc 1m 33s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 1m 31s the patch passed +1 compile 1m 40s the patch passed +1 javac 1m 40s the patch passed -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 125 unchanged - 2 fixed = 126 total (was 127) +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 57s the patch passed +1 javadoc 1m 21s the patch passed +1 unit 0m 54s hadoop-hdfs-client in the patch passed. +1 unit 71m 51s hadoop-hdfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 101m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807518/HDFS-10468.002.patch JIRA Issue HDFS-10468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1caa1310432e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0bc05e4 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15626/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15626/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15626/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        But considering the current complexity of the DFSInputStream code, I do not plan to fix all of them in this jira.

        I agree to fix this incrementally.

        While testing the 002, same exception was logged multiple times because the exception thrown by DFSInputStream#checkInterrupted is passed to DFSInputStream#checkInterrupted again in outer scope. It might to be better to use debug level for logging in DFSInputStream#checkInterrupted.

        2016-06-07 01:51:13,191 [Thread-84] WARN  impl.BlockReaderFactory (BlockReaderFactory.java:getRemoteBlockReaderFromTcp(758)) - I/O error constructing remote block reader.
        java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left.
        	at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342)
                ...(snip)
        2016-06-07 01:51:13,194 [Thread-84] WARN  hdfs.DFSClient (DFSInputStream.java:checkInterrupted(693)) - The reading thread has been interrupted.
        java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left.
        	at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342)
                ...(snip)
        2016-06-07 01:51:13,194 [Thread-84] WARN  hdfs.DFSClient (DFSInputStream.java:checkInterrupted(693)) - The reading thread has been interrupted.
        java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left.
        	at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342)
                ...(snip)
        

        I'm +1 if this is addressed.

        Show
        iwasakims Masatake Iwasaki added a comment - But considering the current complexity of the DFSInputStream code, I do not plan to fix all of them in this jira. I agree to fix this incrementally. While testing the 002, same exception was logged multiple times because the exception thrown by DFSInputStream#checkInterrupted is passed to DFSInputStream#checkInterrupted again in outer scope. It might to be better to use debug level for logging in DFSInputStream#checkInterrupted . 2016-06-07 01:51:13,191 [Thread-84] WARN impl.BlockReaderFactory (BlockReaderFactory.java:getRemoteBlockReaderFromTcp(758)) - I/O error constructing remote block reader. java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left. at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342) ...(snip) 2016-06-07 01:51:13,194 [Thread-84] WARN hdfs.DFSClient (DFSInputStream.java:checkInterrupted(693)) - The reading thread has been interrupted. java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left. at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342) ...(snip) 2016-06-07 01:51:13,194 [Thread-84] WARN hdfs.DFSClient (DFSInputStream.java:checkInterrupted(693)) - The reading thread has been interrupted. java.io.InterruptedIOException: Interrupted while waiting for IO on channel java.nio.channels.SocketChannel[connected local=/127.0.0.1:37109 remote=/127.0.0.1:34420]. 60000 millis timeout left. at org.apache.hadoop.net.SocketIOWithTimeout$SelectorPool.select(SocketIOWithTimeout.java:342) ...(snip) I'm +1 if this is addressed.
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks a lot for the review, Masatake Iwasaki. Yes, to change the log level to debug should be better here: the upper level application will get the exception anyway. Upload a new patch to address your comments.

        Show
        jingzhao Jing Zhao added a comment - Thanks a lot for the review, Masatake Iwasaki . Yes, to change the log level to debug should be better here: the upper level application will get the exception anyway. Upload a new patch to address your comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 7s Maven dependency ordering for branch
        +1 mvninstall 7m 34s trunk passed
        +1 compile 1m 42s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 1m 43s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 26s trunk passed
        +1 javadoc 1m 34s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 32s the patch passed
        +1 compile 1m 33s the patch passed
        +1 javac 1m 33s the patch passed
        -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 125 unchanged - 2 fixed = 126 total (was 127)
        +1 mvnsite 1m 26s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 38s the patch passed
        +1 javadoc 1m 29s the patch passed
        +1 unit 1m 2s hadoop-hdfs-client in the patch passed.
        -1 unit 77m 59s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        109m 10s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.TestAsyncHDFSWithHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808478/HDFS-10468.003.patch
        JIRA Issue HDFS-10468
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux ab32f06023b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4a1cedc
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15669/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15669/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 7s Maven dependency ordering for branch +1 mvninstall 7m 34s trunk passed +1 compile 1m 42s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 34s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 32s the patch passed +1 compile 1m 33s the patch passed +1 javac 1m 33s the patch passed -1 checkstyle 0m 34s hadoop-hdfs-project: The patch generated 1 new + 125 unchanged - 2 fixed = 126 total (was 127) +1 mvnsite 1m 26s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 38s the patch passed +1 javadoc 1m 29s the patch passed +1 unit 1m 2s hadoop-hdfs-client in the patch passed. -1 unit 77m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 109m 10s Reason Tests Failed junit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestAsyncHDFSWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12808478/HDFS-10468.003.patch JIRA Issue HDFS-10468 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ab32f06023b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4a1cedc Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15669/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15669/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15669/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        +1

        Show
        iwasakims Masatake Iwasaki added a comment - +1
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks again for the review, Masatake Iwasaki. I've committed this to trunk and branch-2.

        Show
        jingzhao Jing Zhao added a comment - Thanks again for the review, Masatake Iwasaki . I've committed this to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9922 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9922/)
        HDFS-10468. HDFS read ends up ignoring an interrupt. Contributed by Jing (jing9: rev be34e85e682880f46eee0310bf00ecc7d39cd5bd)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRead.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9922 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9922/ ) HDFS-10468 . HDFS read ends up ignoring an interrupt. Contributed by Jing (jing9: rev be34e85e682880f46eee0310bf00ecc7d39cd5bd) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestRead.java

          People

          • Assignee:
            jingzhao Jing Zhao
            Reporter:
            sseth Siddharth Seth
          • Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development