Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10424

DatanodeLifelineProtocol not able to use under security cluster

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      protocol org.apache.hadoop.hdfs.server.protocol.DatanodeLifelineProtocol is unauthorized for user ***** (auth:KERBEROS) | Server.java:1979

      I am using security cluster authenticate with kerberos, as I checked the the code, if security auth enabled, because the DatanodeLifelineProtocol is not inside HDFSPolicyProvider, when authorize in ServiceAuthorizationManager, AuthorizationException will be thrown at line 96.

      Please point me out if I am wrong

      1. HDFS-10424.001.patch
        10 kB
        Chris Nauroth
      2. HDFS-10424-branch-2.8.001.patch
        9 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          gu chi gu-chi added a comment -

          Chris Nauroth please help check, thx

          Show
          gu chi gu-chi added a comment - Chris Nauroth please help check, thx
          Hide
          cnauroth Chris Nauroth added a comment -

          gu-chi, thank you for the bug report. I was able to reproduce it in a secured cluster, and then I verified that the attached patch fixes it.

          This patch also includes a new test suite designed to catch similar kinds of bugs in the future. It works by scanning the list of protocol classes covered by HDFSPolicyProvider and then comparing that to *Protocol interfaces implemented by known RPC server classes. If it finds a protocol interface implemented by a server, but not covered in the policy, then it fails. This way, if we add new protocols, but forget to update HDFSPolicyProvider, then the test will fail during pre-commit.

          Interestingly, this test immediately exposed another potential offender: ReconfigurationProtocol. I've coded the test to skip checking that one for now in the interest of expediting the patch here. I'll file a separate JIRA for follow-up on that one and contact contributors who have worked on reconfiguration.

          Show
          cnauroth Chris Nauroth added a comment - gu-chi , thank you for the bug report. I was able to reproduce it in a secured cluster, and then I verified that the attached patch fixes it. This patch also includes a new test suite designed to catch similar kinds of bugs in the future. It works by scanning the list of protocol classes covered by HDFSPolicyProvider and then comparing that to *Protocol interfaces implemented by known RPC server classes. If it finds a protocol interface implemented by a server, but not covered in the policy, then it fails. This way, if we add new protocols, but forget to update HDFSPolicyProvider , then the test will fail during pre-commit. Interestingly, this test immediately exposed another potential offender: ReconfigurationProtocol . I've coded the test to skip checking that one for now in the interest of expediting the patch here. I'll file a separate JIRA for follow-up on that one and contact contributors who have worked on reconfiguration.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 6m 0s trunk passed
          +1 compile 6m 10s trunk passed
          +1 checkstyle 1m 19s trunk passed
          +1 mvnsite 1m 42s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 2m 54s trunk passed
          +1 javadoc 1m 57s trunk passed
          0 mvndep 0m 12s Maven dependency ordering for patch
          +1 mvninstall 1m 22s the patch passed
          +1 compile 6m 6s the patch passed
          +1 javac 6m 6s the patch passed
          -1 checkstyle 1m 20s root: patch generated 3 new + 156 unchanged - 0 fixed = 159 total (was 156)
          +1 mvnsite 1m 40s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 11s the patch passed
          +1 javadoc 2m 0s the patch passed
          -1 unit 19m 31s hadoop-common in the patch failed.
          -1 unit 70m 28s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          128m 20s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage
            hadoop.hdfs.TestFileAppend
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805069/HDFS-10424.001.patch
          JIRA Issue HDFS-10424
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c45856748611 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 42c22f7
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15503/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15503/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 6m 0s trunk passed +1 compile 6m 10s trunk passed +1 checkstyle 1m 19s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 2m 54s trunk passed +1 javadoc 1m 57s trunk passed 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 22s the patch passed +1 compile 6m 6s the patch passed +1 javac 6m 6s the patch passed -1 checkstyle 1m 20s root: patch generated 3 new + 156 unchanged - 0 fixed = 159 total (was 156) +1 mvnsite 1m 40s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 11s the patch passed +1 javadoc 2m 0s the patch passed -1 unit 19m 31s hadoop-common in the patch failed. -1 unit 70m 28s hadoop-hdfs in the patch failed. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 128m 20s Reason Tests Failed junit tests hadoop.hdfs.TestDFSUpgradeFromImage   hadoop.hdfs.TestFileAppend Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805069/HDFS-10424.001.patch JIRA Issue HDFS-10424 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c45856748611 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 42c22f7 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15503/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15503/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15503/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1. Neat unit test Chris Nauroth. Thanks for taking care of this and for finding the ReconfigurationProtocol issue.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1. Neat unit test Chris Nauroth . Thanks for taking care of this and for finding the ReconfigurationProtocol issue.
          Hide
          cnauroth Chris Nauroth added a comment -

          Arpit Agarwal, thank you for the code review. I just noticed that I need a separate patch for branch-2.8, because ReconfigurationProtocol doesn't exist there. I'm attaching that now. Are you +1 for the branch-2.8 patch too?

          Show
          cnauroth Chris Nauroth added a comment - Arpit Agarwal , thank you for the code review. I just noticed that I need a separate patch for branch-2.8, because ReconfigurationProtocol doesn't exist there. I'm attaching that now. Are you +1 for the branch-2.8 patch too?
          Hide
          cnauroth Chris Nauroth added a comment -

          The Checkstyle warnings are triggered by existing patterns in the code. I'm not planning on cleaning those up within the scope of this patch.

          Show
          cnauroth Chris Nauroth added a comment - The Checkstyle warnings are triggered by existing patterns in the code. I'm not planning on cleaning those up within the scope of this patch.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the branch-2.8 patch too. Thanks Chris Nauroth!

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the branch-2.8 patch too. Thanks Chris Nauroth !
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 3m 11s Maven dependency ordering for branch
          +1 mvninstall 7m 44s branch-2.8 passed
          +1 compile 6m 11s branch-2.8 passed with JDK v1.8.0_74
          +1 compile 6m 51s branch-2.8 passed with JDK v1.7.0_95
          +1 checkstyle 1m 13s branch-2.8 passed
          +1 mvnsite 1m 53s branch-2.8 passed
          +1 mvneclipse 0m 36s branch-2.8 passed
          +1 findbugs 3m 47s branch-2.8 passed
          +1 javadoc 2m 6s branch-2.8 passed with JDK v1.8.0_74
          +1 javadoc 2m 59s branch-2.8 passed with JDK v1.7.0_95
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 30s the patch passed
          +1 compile 5m 56s the patch passed with JDK v1.8.0_74
          +1 javac 5m 56s the patch passed
          +1 compile 6m 48s the patch passed with JDK v1.7.0_95
          +1 javac 6m 48s the patch passed
          -1 checkstyle 1m 8s root: patch generated 4 new + 154 unchanged - 1 fixed = 158 total (was 155)
          +1 mvnsite 1m 48s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 4m 2s the patch passed
          +1 javadoc 2m 9s the patch passed with JDK v1.8.0_74
          +1 javadoc 2m 57s the patch passed with JDK v1.7.0_95
          +1 unit 7m 58s hadoop-common in the patch passed with JDK v1.8.0_74.
          -1 unit 61m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.7.0_95.
          -1 unit 61m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          205m 10s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
            hadoop.hdfs.TestDistributedFileSystem
            hadoop.hdfs.TestRollingUpgrade
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c60792e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805148/HDFS-10424-branch-2.8.001.patch
          JIRA Issue HDFS-10424
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d9d0995d1473 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / dbff8f2
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15509/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15509/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 3m 11s Maven dependency ordering for branch +1 mvninstall 7m 44s branch-2.8 passed +1 compile 6m 11s branch-2.8 passed with JDK v1.8.0_74 +1 compile 6m 51s branch-2.8 passed with JDK v1.7.0_95 +1 checkstyle 1m 13s branch-2.8 passed +1 mvnsite 1m 53s branch-2.8 passed +1 mvneclipse 0m 36s branch-2.8 passed +1 findbugs 3m 47s branch-2.8 passed +1 javadoc 2m 6s branch-2.8 passed with JDK v1.8.0_74 +1 javadoc 2m 59s branch-2.8 passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_74 +1 javac 5m 56s the patch passed +1 compile 6m 48s the patch passed with JDK v1.7.0_95 +1 javac 6m 48s the patch passed -1 checkstyle 1m 8s root: patch generated 4 new + 154 unchanged - 1 fixed = 158 total (was 155) +1 mvnsite 1m 48s the patch passed +1 mvneclipse 0m 28s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 4m 2s the patch passed +1 javadoc 2m 9s the patch passed with JDK v1.8.0_74 +1 javadoc 2m 57s the patch passed with JDK v1.7.0_95 +1 unit 7m 58s hadoop-common in the patch passed with JDK v1.8.0_74. -1 unit 61m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_74. +1 unit 8m 16s hadoop-common in the patch passed with JDK v1.7.0_95. -1 unit 61m 10s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 205m 10s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.TestDistributedFileSystem   hadoop.hdfs.TestRollingUpgrade JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:c60792e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805148/HDFS-10424-branch-2.8.001.patch JIRA Issue HDFS-10424 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d9d0995d1473 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / dbff8f2 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15509/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15509/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Reports were not available to check the test failure.

          Slave went offline during the build

          Re-triggered jenkins for this.

          Show
          vinayrpet Vinayakumar B added a comment - Reports were not available to check the test failure. Slave went offline during the build Re-triggered jenkins for this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 2m 16s Maven dependency ordering for branch
          +1 mvninstall 6m 59s branch-2.8 passed
          +1 compile 5m 55s branch-2.8 passed with JDK v1.8.0_91
          +1 compile 6m 36s branch-2.8 passed with JDK v1.7.0_101
          +1 checkstyle 1m 10s branch-2.8 passed
          +1 mvnsite 1m 50s branch-2.8 passed
          +1 mvneclipse 0m 32s branch-2.8 passed
          +1 findbugs 3m 39s branch-2.8 passed
          +1 javadoc 2m 2s branch-2.8 passed with JDK v1.8.0_91
          +1 javadoc 2m 51s branch-2.8 passed with JDK v1.7.0_101
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 24s the patch passed
          +1 compile 5m 31s the patch passed with JDK v1.8.0_91
          +1 javac 5m 31s the patch passed
          +1 compile 6m 27s the patch passed with JDK v1.7.0_101
          +1 javac 6m 27s the patch passed
          -1 checkstyle 1m 5s root: patch generated 4 new + 155 unchanged - 1 fixed = 159 total (was 156)
          +1 mvnsite 1m 44s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 53s the patch passed
          +1 javadoc 1m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 2m 45s the patch passed with JDK v1.7.0_101
          +1 unit 6m 54s hadoop-common in the patch passed with JDK v1.8.0_91.
          -1 unit 47m 56s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
          +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.7.0_101.
          -1 unit 45m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          169m 2s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestDistributedFileSystem
          JDK v1.7.0_101 Failed junit tests hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c60792e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805148/HDFS-10424-branch-2.8.001.patch
          JIRA Issue HDFS-10424
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8bcae3f8d969 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.8 / dbff8f2
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15513/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15513/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 2m 16s Maven dependency ordering for branch +1 mvninstall 6m 59s branch-2.8 passed +1 compile 5m 55s branch-2.8 passed with JDK v1.8.0_91 +1 compile 6m 36s branch-2.8 passed with JDK v1.7.0_101 +1 checkstyle 1m 10s branch-2.8 passed +1 mvnsite 1m 50s branch-2.8 passed +1 mvneclipse 0m 32s branch-2.8 passed +1 findbugs 3m 39s branch-2.8 passed +1 javadoc 2m 2s branch-2.8 passed with JDK v1.8.0_91 +1 javadoc 2m 51s branch-2.8 passed with JDK v1.7.0_101 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 5m 31s the patch passed with JDK v1.8.0_91 +1 javac 5m 31s the patch passed +1 compile 6m 27s the patch passed with JDK v1.7.0_101 +1 javac 6m 27s the patch passed -1 checkstyle 1m 5s root: patch generated 4 new + 155 unchanged - 1 fixed = 159 total (was 156) +1 mvnsite 1m 44s the patch passed +1 mvneclipse 0m 26s the patch passed -1 whitespace 0m 0s The patch has 49 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 53s the patch passed +1 javadoc 1m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 2m 45s the patch passed with JDK v1.7.0_101 +1 unit 6m 54s hadoop-common in the patch passed with JDK v1.8.0_91. -1 unit 47m 56s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 7m 17s hadoop-common in the patch passed with JDK v1.7.0_101. -1 unit 45m 34s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 169m 2s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestDistributedFileSystem JDK v1.7.0_101 Failed junit tests hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Docker Image:yetus/hadoop:c60792e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805148/HDFS-10424-branch-2.8.001.patch JIRA Issue HDFS-10424 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8bcae3f8d969 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / dbff8f2 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15513/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15513/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15513/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Test failure seems unrelated.
          +1 for the patch.

          Show
          vinayrpet Vinayakumar B added a comment - Test failure seems unrelated. +1 for the patch.
          Hide
          cnauroth Chris Nauroth added a comment -

          Arpit Agarwal and Vinayakumar B, thank you for the code reviews. I have committed this to trunk, branch-2 and branch-2.8.

          Show
          cnauroth Chris Nauroth added a comment - Arpit Agarwal and Vinayakumar B , thank you for the code reviews. I have committed this to trunk, branch-2 and branch-2.8.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9835 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9835/)
          HDFS-10424. DatanodeLifelineProtocol not able to use under security (cnauroth: rev bcde1562d25c4f5595f4e3436dc3630315b1ceed)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HDFSPolicyProvider.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSPolicyProvider.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeRpcServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9835 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9835/ ) HDFS-10424 . DatanodeLifelineProtocol not able to use under security (cnauroth: rev bcde1562d25c4f5595f4e3436dc3630315b1ceed) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HDFSPolicyProvider.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHDFSPolicyProvider.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNodeRpcServer.java

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              gu chi gu-chi
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development