Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1041

DFSClient does not retry in getFileChecksum(..)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20.2, 0.21.0, 0.22.0
    • Fix Version/s: 0.20.3, 0.21.0, 1.0.3
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If connection to the first datanode fails, DFSClient does not retry in getFileChecksum(..).

      1. h1041_20100405_branch-1.patch
        4 kB
        Tsz Wo Nicholas Sze
      2. h1041_20100405_0.20.patch
        4 kB
        Tsz Wo Nicholas Sze
      3. h1041_20100405_0.21.patch
        3 kB
        Tsz Wo Nicholas Sze
      4. h1041_20100405.patch
        3 kB
        Tsz Wo Nicholas Sze
      5. h1041_20100317.patch
        2 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1041_20100317.patch: move the connection codes in the try-catch.

        Show
        Tsz Wo Nicholas Sze added a comment - h1041_20100317.patch: move the connection codes in the try-catch.
        Hide
        Todd Lipcon added a comment -

        Seems good to me. Can you add a test case for this? Seems reasonably easy to test (see TestDFSClientRetries)

        Show
        Todd Lipcon added a comment - Seems good to me. Can you add a test case for this? Seems reasonably easy to test (see TestDFSClientRetries)
        Hide
        dhruba borthakur added a comment -

        Does this problem also exist in hadoop 0.20?

        Show
        dhruba borthakur added a comment - Does this problem also exist in hadoop 0.20?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Yes, 0.20 also has this problem.

        Show
        Tsz Wo Nicholas Sze added a comment - Yes, 0.20 also has this problem.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1041_20100405.patch: added a test.

        Show
        Tsz Wo Nicholas Sze added a comment - h1041_20100405.patch: added a test.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12440781/h1041_20100405.patch
        against trunk revision 930967.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12440781/h1041_20100405.patch against trunk revision 930967. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/147/console This message is automatically generated.
        Hide
        Suresh Srinivas added a comment -

        +1. The patch looks good.

        Show
        Suresh Srinivas added a comment - +1. The patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1041_20100405_0.21.patch: for 0.21
        h1041_20100405_0.20.patch: for 0.20

        Show
        Tsz Wo Nicholas Sze added a comment - h1041_20100405_0.21.patch: for 0.21 h1041_20100405_0.20.patch: for 0.20
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this to 0.20 and above.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this to 0.20 and above.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #236 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/236/)
        HDFS-1041. DFSClient.getFileChecksum(..) should retry if connection to the first datanode fails.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #236 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/236/ ) HDFS-1041 . DFSClient.getFileChecksum(..) should retry if connection to the first datanode fails.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        This somehow is not in branch-1 and branch-1.0. h1041_20100405_0.20.patch still applies to branch-1.0 but not branch-1.

        Show
        Tsz Wo Nicholas Sze added a comment - This somehow is not in branch-1 and branch-1.0. h1041_20100405_0.20.patch still applies to branch-1.0 but not branch-1.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1041_20100405_branch-1.patch: for branch-1.

        Show
        Tsz Wo Nicholas Sze added a comment - h1041_20100405_branch-1.patch: for branch-1.
        Hide
        Matt Foley added a comment -

        +1. Thank you Nicholas! Please commit to branch-1 and branch-1.0, for 1.0.3.

        Show
        Matt Foley added a comment - +1. Thank you Nicholas! Please commit to branch-1 and branch-1.0, for 1.0.3.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have merged this to branch-1.0 and committed the branch-1 patch.

        Show
        Tsz Wo Nicholas Sze added a comment - I have merged this to branch-1.0 and committed the branch-1 patch.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development