Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10410

RedundantEditLogInputStream#LOG is set to wrong class

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      Found the issue while analyzing a log message that points to the wrong class.

      class RedundantEditLogInputStream extends EditLogInputStream {
        public static final Log LOG = LogFactory.getLog(EditLogInputStream.class.getName());
      

      should be changed to:

        public static final Log LOG = LogFactory.getLog(RedundantEditLogInputStream.class.getName());
      

        Activity

        Hide
        jzhuge John Zhuge added a comment -

        Patch 001:

        • Set RedundantEditLogInputStream#LOG to its own class
        Show
        jzhuge John Zhuge added a comment - Patch 001: Set RedundantEditLogInputStream#LOG to its own class
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 1s trunk passed
        +1 compile 0m 50s trunk passed with JDK v1.8.0_91
        +1 compile 0m 41s trunk passed with JDK v1.7.0_101
        +1 checkstyle 0m 26s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 55s trunk passed
        +1 javadoc 1m 3s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 48s trunk passed with JDK v1.7.0_101
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 38s the patch passed with JDK v1.8.0_91
        +1 javac 0m 38s the patch passed
        +1 compile 0m 39s the patch passed with JDK v1.7.0_101
        +1 javac 0m 39s the patch passed
        +1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 8s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 44s the patch passed with JDK v1.7.0_101
        -1 unit 57m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 59m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        142m 34s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestRenameWhileOpen
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.server.balancer.TestBalancer
          hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804203/HADOOP-10410.001.patch
        JIRA Issue HDFS-10410
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c6a6dea095d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 81effb7
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15447/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15447/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 1s trunk passed +1 compile 0m 50s trunk passed with JDK v1.8.0_91 +1 compile 0m 41s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 48s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 47s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_91 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_101 +1 javac 0m 39s the patch passed +1 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_101 -1 unit 57m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 59m 14s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 142m 34s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestRenameWhileOpen JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.qjournal.client.TestQuorumJournalManager   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804203/HADOOP-10410.001.patch JIRA Issue HDFS-10410 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c6a6dea095d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 81effb7 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15447/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15447/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15447/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jzhuge John Zhuge added a comment -

        Upload the correct patch file name.

        Show
        jzhuge John Zhuge added a comment - Upload the correct patch file name.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 54s trunk passed
        +1 compile 0m 41s trunk passed with JDK v1.8.0_91
        +1 compile 0m 43s trunk passed with JDK v1.7.0_101
        +1 checkstyle 0m 27s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 1m 7s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 46s trunk passed with JDK v1.7.0_101
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 43s the patch passed with JDK v1.8.0_91
        +1 javac 0m 43s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.7.0_101
        +1 javac 0m 40s the patch passed
        +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101
        -1 unit 58m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        -1 unit 59m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_101.
        +1 asflicense 0m 22s Patch does not generate ASF License warnings.
        144m 2s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.server.datanode.TestDataNodeLifeline
        JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.balancer.TestBalancer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804257/HDFS-10410.001.patch
        JIRA Issue HDFS-10410
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e87811349dda 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1217c8f
        Default Java 1.7.0_101
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt
        JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15451/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15451/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 54s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_91 +1 compile 0m 43s trunk passed with JDK v1.7.0_101 +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 7s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_101 +1 mvninstall 0m 50s the patch passed +1 compile 0m 43s the patch passed with JDK v1.8.0_91 +1 javac 0m 43s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_101 +1 javac 0m 40s the patch passed +1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 48s the patch passed with JDK v1.7.0_101 -1 unit 58m 28s hadoop-hdfs in the patch failed with JDK v1.8.0_91. -1 unit 59m 43s hadoop-hdfs in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 144m 2s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.TestDataNodeLifeline JDK v1.7.0_101 Failed junit tests hadoop.hdfs.server.balancer.TestBalancer Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804257/HDFS-10410.001.patch JIRA Issue HDFS-10410 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e87811349dda 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1217c8f Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15451/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15451/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15451/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9771 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9771/)
        HDFS-10410. RedundantEditLogInputStream.LOG is set to wrong class. (John (lei: rev 6a6e74acf5c38a4995c4622148721cfe2f1fbdad)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/RedundantEditLogInputStream.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9771 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9771/ ) HDFS-10410 . RedundantEditLogInputStream.LOG is set to wrong class. (John (lei: rev 6a6e74acf5c38a4995c4622148721cfe2f1fbdad) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/RedundantEditLogInputStream.java
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        The change is trivial. It provides more clear context for the log messages.

        +1. Thanks a lot, John Zhuge!

        Show
        eddyxu Lei (Eddy) Xu added a comment - The change is trivial. It provides more clear context for the log messages. +1. Thanks a lot, John Zhuge !
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Lei (Eddy) Xu!

        Show
        jzhuge John Zhuge added a comment - Thanks Lei (Eddy) Xu !

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development