Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1038

In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      nn_browsedfscontent.jsp calls getDelegationToken even if security is disabled, which causes NPE.

      1. HDFS-1038.3.patch
        2 kB
        Jitendra Nath Pandey
      2. HDFS-1038.2.patch
        3 kB
        Jitendra Nath Pandey
      3. HDFS-1038.1.patch
        0.9 kB
        Jitendra Nath Pandey
      4. HDFS-1038-y20.1.patch
        0.7 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Jitendra Nath Pandey added a comment -

        Patch hadoop-20.

        Show
        Jitendra Nath Pandey added a comment - Patch hadoop-20.
        Hide
        Jitendra Nath Pandey added a comment -

        patch for trunk

        Show
        Jitendra Nath Pandey added a comment - patch for trunk
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445220/HDFS-1038.1.patch
        against trunk revision 947204.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445220/HDFS-1038.1.patch against trunk revision 947204. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/374/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        New patch includes a test case.

        Show
        Jitendra Nath Pandey added a comment - New patch includes a test case.
        Hide
        Boris Shkolnik added a comment -

        patch looks good +1.
        It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there.

        Show
        Boris Shkolnik added a comment - patch looks good +1. It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there.
        Hide
        Jitendra Nath Pandey added a comment -

        >It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there.

        NameNodeJspHelper.getDelegationToken is package private and is called in only one place, redirectToRandomDataNode in the same file, apart from the newly added testcase. 'redirectToRandomDataNode' method handles the null value.

        Show
        Jitendra Nath Pandey added a comment - >It might be a good idea to scan quickly all the places where the getDT api is called to verify 'null' value is expected there. NameNodeJspHelper.getDelegationToken is package private and is called in only one place, redirectToRandomDataNode in the same file, apart from the newly added testcase. 'redirectToRandomDataNode' method handles the null value.
        Hide
        Jitendra Nath Pandey added a comment -

        test-patch results

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jitendra Nath Pandey added a comment - test-patch results [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Jitendra Nath Pandey added a comment -

        tests were run manually, all passed except TestHDFSTrash which fails without this patch as well.

        Show
        Jitendra Nath Pandey added a comment - tests were run manually, all passed except TestHDFSTrash which fails without this patch as well.
        Hide
        Boris Shkolnik added a comment -

        Committed this. Thanks Jitendra.

        Show
        Boris Shkolnik added a comment - Committed this. Thanks Jitendra.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445373/HDFS-1038.2.patch
        against trunk revision 947204.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445373/HDFS-1038.2.patch against trunk revision 947204. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/375/console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #281 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/281/)
        HDFS-1038. In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #281 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/281/ ) HDFS-1038 . In nn_browsedfscontent.jsp fetch delegation token only if security is enabled.
        Hide
        Jitendra Nath Pandey added a comment -

        HDFS-1038.3.patch contains only the test.

        Show
        Jitendra Nath Pandey added a comment - HDFS-1038 .3.patch contains only the test.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/285/)
        HDFS-1038. FIX. A test missed in a previous commit for this JIRA
        HDFS-1038. Fix. Added missing test

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #285 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/285/ ) HDFS-1038 . FIX. A test missed in a previous commit for this JIRA HDFS-1038 . Fix. Added missing test

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development