DataTransferProtocol#writeBlock's javadocs has the following parameters missing:
final DataChecksum requestedChecksum,
final CachingStrategy cachingStrategy,
Thanks John for being willing to help on this one.
allowLazyPersist also misses javadoc.
Please review patch 001:
Thanks for the patch. May I ask why allowLazyPersist is stated as hint to the DataNode that...? By "hint", it appears that DataNode is free to ignore it.
This message was automatically generated.
Mingliang Liu The DN is free to ignore it. Copy from protobuf comment in datatransfer.proto:
* Hint to the DataNode that the block can be allocated on transient
* storage i.e. memory and written to disk lazily. The DataNode is free
* to ignore this hint.
optional bool allowLazyPersist = 13 [default = false];
That makes sense to me. Thanks for the explanation, John Zhuge.
+1. Thanks! Document fixes are always welcome, John Zhuge
Committed to trunk and branch-2.
Thanks Lei (Eddy) Xu.
SUCCESS: Integrated in Hadoop-trunk-Commit #10083 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10083/)
HDFS-10387. DataTransferProtocol#writeBlock missing some javadocs (John (lei: rev d5f5a6475b19a52bf54f97cd8843408265b888f0)