Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10381

DataStreamer DataNode exclusion log message should be warning

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When adding a DN to excludedNodes, it should log a warning message instead of info.

            success = createBlockOutputStream(nodes, storageTypes, 0L, false);
      
            if (!success) {
              LOG.info("Abandoning " + block);
              dfsClient.namenode.abandonBlock(block, stat.getFileId(), src,
                  dfsClient.clientName);
              block = null;
              final DatanodeInfo badNode = nodes[errorState.getBadNodeIndex()];
              LOG.info("Excluding datanode " + badNode);
              excludedNodes.put(badNode, badNode);
            }
      

        Activity

        Hide
        jzhuge John Zhuge added a comment -
        Show
        jzhuge John Zhuge added a comment - Thanks Mingliang Liu , Wei-Chiu Chuang , Jing Zhao , and Yongjun Zhang .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9810 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9810/)
        HDFS-10381, DataStreamer DataNode exclusion log message should be (yzhang: rev 16c07cc68a3e0a06f57b7f4c7207cc8e5dce211f)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9810 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9810/ ) HDFS-10381 , DataStreamer DataNode exclusion log message should be (yzhang: rev 16c07cc68a3e0a06f57b7f4c7207cc8e5dce211f) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/StripedDataStreamer.java
        Hide
        yzhangal Yongjun Zhang added a comment -

        Committed to trunk, branch-2, and branch-2.8.

        Thanks John Zhuge for the contribution, Mingliang Liu, Wei-Chiu Chuang and Jing Zhao for the review!

        Show
        yzhangal Yongjun Zhang added a comment - Committed to trunk, branch-2, and branch-2.8. Thanks John Zhuge for the contribution, Mingliang Liu , Wei-Chiu Chuang and Jing Zhao for the review!
        Hide
        jingzhao Jing Zhao added a comment -

        Thanks for the contribution, John Zhuge. +1

        Show
        jingzhao Jing Zhao added a comment - Thanks for the contribution, John Zhuge . +1
        Hide
        yzhangal Yongjun Zhang added a comment -

        Hi John Zhuge,

        Thanks for reporting and working on this issue. The patch looks good to me. +1. I will wait for tomorrow before I commit it, in case Jing Zhao has further comments.

        Show
        yzhangal Yongjun Zhang added a comment - Hi John Zhuge , Thanks for reporting and working on this issue. The patch looks good to me. +1. I will wait for tomorrow before I commit it, in case Jing Zhao has further comments.
        Hide
        jzhuge John Zhuge added a comment -

        Jing Zhao Could you please review since you worked on this code?

        Show
        jzhuge John Zhuge added a comment - Jing Zhao Could you please review since you worked on this code?
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Looks good to me +1 (non-binding)

        Show
        jojochuang Wei-Chiu Chuang added a comment - Looks good to me +1 (non-binding)
        Hide
        jzhuge John Zhuge added a comment -

        Please review patch 001:

        • Change 2 logs from info to warn in DataStreamer.nextBlockOutputStream
        • Change 1 log from info to warn in StripedDataStreamer.nextBlockOutputStream

        Couldn't find any suitable unit test to change or run.

        Show
        jzhuge John Zhuge added a comment - Please review patch 001: Change 2 logs from info to warn in DataStreamer.nextBlockOutputStream Change 1 log from info to warn in StripedDataStreamer.nextBlockOutputStream Couldn't find any suitable unit test to change or run.
        Hide
        jzhuge John Zhuge added a comment -

        Thanks Mingliang Liu. Fixed.

        Show
        jzhuge John Zhuge added a comment - Thanks Mingliang Liu . Fixed.
        Hide
        liuml07 Mingliang Liu added a comment -

        Is this for DataStreamer? Perhaps we can set the component field as hdfs-client.

        Show
        liuml07 Mingliang Liu added a comment - Is this for DataStreamer ? Perhaps we can set the component field as hdfs-client .

          People

          • Assignee:
            jzhuge John Zhuge
            Reporter:
            jzhuge John Zhuge
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development