[HDFS-10372] Fix for failing TestFsDatasetImpl#testCleanShutdownOfVolume

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.3
• Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
• Component/s: test
• Target Version/s: 2.7.3
• Hadoop Flags: Reviewed
• Assignee: Rushabh Shah
• Reporter: Rushabh Shah
• Created: 06/May/16 02:23
• Updated: 02/Oct/19 17:12
• Resolved: 09/May/16 21:00

Description

TestFsDatasetImpl#testCleanShutdownOfVolume fails very often.
We added more debug information in HDFS-10260 to find out why this test is failing.
Now I think I know the root cause of failure.
I thought that LocatedBlock#getLocations() returns an array of DatanodeInfo but now I realized that it returns an array of DatandeStorageInfo (which is subclass of DatanodeInfo).
In the test I intended to check whether the exception contains the xfer address of the DatanodeInfo. Since DatanodeInfo#toString() method returns the xfer address, I checked whether exception contains DatanodeInfo#toString or not.
But since LocatedBlock#getLocations() returned an array of DatanodeStorageInfo, it has storage info in the toString() implementation.

Issue Links

• relates to: HDFS-10260 TestFsDatasetImpl#testCleanShutdownOfVolume often fails