Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10344

DistributedFileSystem#getTrashRoots should skip encryption zone that does not have .Trash

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HDFS-8831 added trash support for encryption zones. For encryption zone that does not have .Trash created yet, DistributedFileSystem#getTrashRoots should skip rather than call listStatus() and break by FileNotFoundException. I will post a patch for the fix shortly.

        Activity

        Hide
        xyao Xiaoyu Yao added a comment -

        Attach a patch with unit tests.

        Show
        xyao Xiaoyu Yao added a comment - Attach a patch with unit tests.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 13m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 12s Maven dependency ordering for branch
        +1 mvninstall 7m 39s trunk passed
        +1 compile 1m 25s trunk passed with JDK v1.8.0_91
        +1 compile 1m 31s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 40s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 4m 1s trunk passed
        +1 javadoc 1m 35s trunk passed with JDK v1.8.0_91
        +1 javadoc 2m 19s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 25s the patch passed
        +1 compile 1m 34s the patch passed with JDK v1.8.0_91
        +1 javac 1m 34s the patch passed
        +1 compile 1m 31s the patch passed with JDK v1.7.0_95
        +1 javac 1m 31s the patch passed
        +1 checkstyle 0m 27s the patch passed
        +1 mvnsite 1m 28s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 12s the patch passed
        +1 javadoc 1m 19s the patch passed with JDK v1.8.0_91
        +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95
        +1 unit 0m 47s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91.
        -1 unit 58m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_91.
        +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        +1 unit 55m 53s hadoop-hdfs in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 24s Patch does not generate ASF License warnings.
        168m 8s



        Reason Tests
        JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801327/HDFS-10344.00.patch
        JIRA Issue HDFS-10344
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b7702cdd0d0d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 6243eab
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15317/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15317/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 7m 39s trunk passed +1 compile 1m 25s trunk passed with JDK v1.8.0_91 +1 compile 1m 31s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 40s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 4m 1s trunk passed +1 javadoc 1m 35s trunk passed with JDK v1.8.0_91 +1 javadoc 2m 19s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 1m 34s the patch passed with JDK v1.8.0_91 +1 javac 1m 34s the patch passed +1 compile 1m 31s the patch passed with JDK v1.7.0_95 +1 javac 1m 31s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 12s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_91 +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95 +1 unit 0m 47s hadoop-hdfs-client in the patch passed with JDK v1.8.0_91. -1 unit 58m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_91. +1 unit 0m 58s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. +1 unit 55m 53s hadoop-hdfs in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 168m 8s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.hdfs.TestHFlush   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801327/HDFS-10344.00.patch JIRA Issue HDFS-10344 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b7702cdd0d0d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6243eab Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15317/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15317/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15317/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks Xiaoyu for the find and fix, patch LGTM +1.

        Show
        andrew.wang Andrew Wang added a comment - Thanks Xiaoyu for the find and fix, patch LGTM +1.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Andrew Wang for the review. I'll commit the patch shortly.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Andrew Wang for the review. I'll commit the patch shortly.
        Hide
        xyao Xiaoyu Yao added a comment -

        Thanks Andrew Wang for the review. I've committed the fix to trunk, branch-2 and branch-2.8.

        Show
        xyao Xiaoyu Yao added a comment - Thanks Andrew Wang for the review. I've committed the fix to trunk, branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9704 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9704/)
        HDFS-10344. DistributedFileSystem#getTrashRoots should skip encryption (xyao: rev 45a753ccf79d334513c7bc8f2b81c89a4697075d)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9704 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9704/ ) HDFS-10344 . DistributedFileSystem#getTrashRoots should skip encryption (xyao: rev 45a753ccf79d334513c7bc8f2b81c89a4697075d) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestEncryptionZones.java

          People

          • Assignee:
            xyao Xiaoyu Yao
            Reporter:
            nmaheshwari Namit Maheshwari
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development