[HDFS-10329] Bad initialisation of StringBuffer in RequestHedgingProxyProvider.java

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: ha
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Yiqun Lin
• Reporter: Max Schaefer
• Created: 26/Apr/16 11:17
• Updated: 30/Aug/16 01:16
• Resolved: 26/Apr/16 16:49

Description

On line 167 of RequestHedgingProxyProvider.java, a StringBuilder is initialised like this:

StringBuilder combinedInfo = new StringBuilder('[');

This won't have the (presumably) desired effect of creating a StringBuilder containing the string "["; instead, it will create a StringBuilder with capacity 91 (the character code of '['). See here for an explanation.

To fix this, pass a string literal instead of the character literal:

StringBuilder combinedInfo = new StringBuilder("[");

Issue Links

• is related to: HDFS-7858 Improve HA Namenode Failover detection on the client