Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None

      Description

      TestShortCircuitLocalRead failing as length of read is considered off end of buffer.

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -
          java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size
          	at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:975)
          	at java.io.DataInputStream.read(DataInputStream.java:149)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitRead(TestShortCircuitLocalRead.java:241)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testSmallFileLocalRead(TestShortCircuitLocalRead.java:308)
          
          Show
          stevel@apache.org Steve Loughran added a comment - java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:975) at java.io.DataInputStream.read(DataInputStream.java:149) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitRead(TestShortCircuitLocalRead.java:241) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testSmallFileLocalRead(TestShortCircuitLocalRead.java:308)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          1. test is doing a short circuited read of a 13 byte file doTestShortCircuitRead(false, size= 13, readOffset= 0)
          2. # creates 13 bytes of data, saves it: byte[] fileData = AppendTestUtil.randomBytes(seed, size)
          3. dest buffer is created for this

          byte[] actual = new byte[expected.length-readOffset];
          

          4 does some small reads:

          //Read a small number of bytes first.
          int nread = stm.read(actual, 0, 3);
          nread += stm.read(actual, nread, 2);
          //Read across chunk boundary
          nread += stm.read(actual, nread, 517);    // ** HERE **
          

          The exception is being raised as the code is asking to read 517 bytes into a buffer 13 bytes long. This breaks IOStream's rules: you can't ask for more than you have space for. It says that clearly in the IOStream API spec; what was added in HADOOP-12994 was the checking of passing in too big a length or negative offsets.

          I think this a bug in the test. Whatever it is trying to do, it shouldn't be trying to do it on such a small buffer.

          What's interesting though is when you delve into the code: the block reader logic doesn't look at the length of the read at all. That is, it appears to fill up the entire byte array passed in, from the offset supplied, stopping at the end of the buffer or file, whichever comes first.

          Which is something that other code (i.e. production code) could be relying on. They shouldn't, as the code will break when working with any FS other than HDFS, but there is a risk that they might.

          What to do?

          1. retain checks, fix test.
          2. log at warning and shrink len parameter when passed down. People shouldn't be doing this, but HDFS will reluctantly let you.
          Show
          stevel@apache.org Steve Loughran added a comment - 1. test is doing a short circuited read of a 13 byte file doTestShortCircuitRead(false, size= 13, readOffset= 0) 2. # creates 13 bytes of data, saves it: byte[] fileData = AppendTestUtil.randomBytes(seed, size) 3. dest buffer is created for this byte [] actual = new byte [expected.length-readOffset]; 4 does some small reads: //Read a small number of bytes first. int nread = stm.read(actual, 0, 3); nread += stm.read(actual, nread, 2); //Read across chunk boundary nread += stm.read(actual, nread, 517); // ** HERE ** The exception is being raised as the code is asking to read 517 bytes into a buffer 13 bytes long. This breaks IOStream's rules: you can't ask for more than you have space for. It says that clearly in the IOStream API spec; what was added in HADOOP-12994 was the checking of passing in too big a length or negative offsets. I think this a bug in the test. Whatever it is trying to do, it shouldn't be trying to do it on such a small buffer. What's interesting though is when you delve into the code: the block reader logic doesn't look at the length of the read at all. That is, it appears to fill up the entire byte array passed in, from the offset supplied, stopping at the end of the buffer or file, whichever comes first. Which is something that other code (i.e. production code) could be relying on. They shouldn't, as the code will break when working with any FS other than HDFS, but there is a risk that they might. What to do? retain checks, fix test. log at warning and shrink len parameter when passed down. People shouldn't be doing this, but HDFS will reluctantly let you.
          Hide
          liuml07 Mingliang Liu added a comment -

          Thanks for the detailed investigation, Steve Loughran. I prefer the first choice (fixing the test only). IMHO, throwing exception is a better defined behavior than making HDFS itself shrinking read length as this is not really a necessary feature.

          Show
          liuml07 Mingliang Liu added a comment - Thanks for the detailed investigation, Steve Loughran . I prefer the first choice (fixing the test only). IMHO, throwing exception is a better defined behavior than making HDFS itself shrinking read length as this is not really a necessary feature.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          FWIW, the reason this didn't show up on my local precommit runs is that this test is skipped on OSX. Moral: test on linux

          Show
          stevel@apache.org Steve Loughran added a comment - FWIW, the reason this didn't show up on my local precommit runs is that this test is skipped on OSX. Moral: test on linux
          Hide
          stevel@apache.org Steve Loughran added a comment -
          calRead
          testSmallFileLocalRead(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead)  Time elapsed: 0.774 sec  <<< ERROR!
          java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size
          	at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977)
          	at java.io.DataInputStream.read(DataInputStream.java:149)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitRead(TestShortCircuitLocalRead.java:241)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testSmallFileLocalRead(TestShortCircuitLocalRead.java:308)
          
          testLocalReadLegacy(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead)  Time elapsed: 0.709 sec  <<< ERROR!
          java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size
          	at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977)
          	at java.io.DataInputStream.read(DataInputStream.java:149)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadLegacy(TestShortCircuitLocalRead.java:235)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testLocalReadLegacy(TestShortCircuitLocalRead.java:316)
          
          testLocalReadFallback(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead)  Time elapsed: 0.644 sec  <<< ERROR!
          java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size
          	at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107)
          	at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977)
          	at java.io.DataInputStream.read(DataInputStream.java:149)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadLegacy(TestShortCircuitLocalRead.java:235)
          	at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testLocalReadFallback(TestShortCircuitLocalRead.java:327)
          
          
          Results :
          
          
          Show
          stevel@apache.org Steve Loughran added a comment - calRead testSmallFileLocalRead(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead) Time elapsed: 0.774 sec <<< ERROR! java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977) at java.io.DataInputStream.read(DataInputStream.java:149) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitRead(TestShortCircuitLocalRead.java:241) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testSmallFileLocalRead(TestShortCircuitLocalRead.java:308) testLocalReadLegacy(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead) Time elapsed: 0.709 sec <<< ERROR! java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977) at java.io.DataInputStream.read(DataInputStream.java:149) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadLegacy(TestShortCircuitLocalRead.java:235) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testLocalReadLegacy(TestShortCircuitLocalRead.java:316) testLocalReadFallback(org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead) Time elapsed: 0.644 sec <<< ERROR! java.lang.IndexOutOfBoundsException: Requested more bytes than destination buffer size at org.apache.hadoop.fs.FSInputStream.validatePositionedReadArgs(FSInputStream.java:107) at org.apache.hadoop.hdfs.DFSInputStream.read(DFSInputStream.java:977) at java.io.DataInputStream.read(DataInputStream.java:149) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.checkFileContent(TestShortCircuitLocalRead.java:157) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadImpl(TestShortCircuitLocalRead.java:286) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.doTestShortCircuitReadLegacy(TestShortCircuitLocalRead.java:235) at org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead.testLocalReadFallback(TestShortCircuitLocalRead.java:327) Results :
          Hide
          stevel@apache.org Steve Loughran added a comment -

          patch 001. Skips the 517 byte read if the length of the buffer is such that this would take this out of bounds

          Show
          stevel@apache.org Steve Loughran added a comment - patch 001. Skips the 517 byte read if the length of the buffer is such that this would take this out of bounds
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 9s trunk passed
          +1 compile 0m 51s trunk passed with JDK v1.8.0_77
          +1 compile 0m 44s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 57s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 57s trunk passed
          +1 javadoc 1m 15s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 57s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 47s the patch passed
          +1 compile 0m 51s the patch passed with JDK v1.8.0_77
          +1 javac 0m 51s the patch passed
          +1 compile 0m 41s the patch passed with JDK v1.7.0_95
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 18s the patch passed
          +1 mvnsite 0m 51s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 14s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95
          -1 unit 113m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 104m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 35s Patch does not generate ASF License warnings.
          245m 30s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.server.namenode.ha.TestEditLogTailer
            hadoop.hdfs.server.blockmanagement.TestBlockManager
            hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.TestSafeMode
            hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.balancer.TestBalancer
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.server.namenode.TestFileTruncate
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799099/HDFS-10291-001.patch
          JIRA Issue HDFS-10291
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7721a2e9ebd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cab9cba
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15179/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15179/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 9s trunk passed +1 compile 0m 51s trunk passed with JDK v1.8.0_77 +1 compile 0m 44s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 57s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 15s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 57s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 47s the patch passed +1 compile 0m 51s the patch passed with JDK v1.8.0_77 +1 javac 0m 51s the patch passed +1 compile 0m 41s the patch passed with JDK v1.7.0_95 +1 javac 0m 41s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 14s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 56s the patch passed with JDK v1.7.0_95 -1 unit 113m 23s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 104m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 35s Patch does not generate ASF License warnings. 245m 30s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestSafeMode   hadoop.hdfs.server.namenode.TestNamenodeCapacityReport   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.balancer.TestBalancer   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799099/HDFS-10291-001.patch JIRA Issue HDFS-10291 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7721a2e9ebd1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cab9cba Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15179/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15179/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15179/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          walter.k.su Walter Su added a comment -

          +1.

          Show
          walter.k.su Walter Su added a comment - +1.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          thanks -patch in

          Show
          stevel@apache.org Steve Loughran added a comment - thanks -patch in
          Hide
          walter.k.su Walter Su added a comment -

          cherry-picked to trunk.

          Show
          walter.k.su Walter Su added a comment - cherry-picked to trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9631/)
          HDFS-10291 TestShortCircuitLocalRead failing (stevel) (waltersu4549: rev 438efc36349fc817d6c56f433b51ac7a45ab6759)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitLocalRead.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9631/ ) HDFS-10291 TestShortCircuitLocalRead failing (stevel) (waltersu4549: rev 438efc36349fc817d6c56f433b51ac7a45ab6759) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/shortcircuit/TestShortCircuitLocalRead.java
          Hide
          stevel@apache.org Steve Loughran added a comment -

          —sorry, thought I had got it into all the branches. Thanks for picking up the trunk patch

          Show
          stevel@apache.org Steve Loughran added a comment - —sorry, thought I had got it into all the branches. Thanks for picking up the trunk patch

            People

            • Assignee:
              stevel@apache.org Steve Loughran
              Reporter:
              stevel@apache.org Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development