Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10265

OEV tool fails to read edit xml file if OP_UPDATE_BLOCKS has no BLOCK tag

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.1, 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tools
    • Labels:
    • Target Version/s:

      Description

      I use OEV tool to convert editlog to xml file, then convert the xml file back to binary editslog file(so that low version NameNode can load edits that generated by higher version NameNode). But when OP_UPDATE_BLOCKS has no BLOCK tag, the OEV tool doesn't handle the case and exits with InvalidXmlException.

      Here is the stack:

      fromXml error decoding opcode null
      {<PATH>{"/tmp/100M3/slive/data/subDir_13/subDir_7/subDir_15/subDir_11/subFile_5"}, <RPC_CALLID>{"-2"}, <RPC_CLIENTID>{},
      <TXID>{"3875711"}}
      Encountered exception. Exiting: no entry found for BLOCK
      org.apache.hadoop.hdfs.util.XMLUtils$InvalidXmlException: no entry found for BLOCK
              at org.apache.hadoop.hdfs.util.XMLUtils$Stanza.getChildren(XMLUtils.java:242)
              at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp$UpdateBlocksOp.fromXml(FSEditLogOp.java:908)
              at org.apache.hadoop.hdfs.server.namenode.FSEditLogOp.decodeXml(FSEditLogOp.java:3942)
              ...
      

      Here is part of the xml file:

      <RECORD>
        <OPCODE>OP_UPDATE_BLOCKS</OPCODE>
        <DATA>
          <TXID>3875711</TXID>
          <PATH>/tmp/100M3/slive/data/subDir_13/subDir_7/subDir_15/subDir_11/subFile_5</PATH>
          <RPC_CLIENTID></RPC_CLIENTID>
          <RPC_CALLID>-2</RPC_CALLID>
        </DATA>
      </RECORD>
      

      I tracked the NN's log and found those operation:

      0. The file /tmp/100M3/slive/data/subDir_13/subDir_7/subDir_15/subDir_11/subFile_5 is very small and contains only one block.
      1. Client ask NN to add block to the file.
      2. Client failed to write to DN and asked NameNode to abandon block.
      3. NN remove the block and write an OP_UPDATE_BLOCKS to editlog

      Finally NN generated a OP_UPDATE_BLOCKS with no BLOCK tags.

      In FSEditLogOp$UpdateBlocksOp.fromXml, we need to handle the case above.

      1. HDFS-10265-001.patch
        1 kB
        Wan Chang
      2. HDFS-10265-002.patch
        2 kB
        Wan Chang

        Issue Links

          Activity

          Hide
          wanchang Wan Chang added a comment -

          FSEditLogOp$UpdateBlocksOp.fromXml:

              void fromXml(Stanza st) throws InvalidXmlException {
                this.path = st.getValue("PATH");
                List<Stanza> blocks = st.getChildren("BLOCK");
                this.blocks = new Block[blocks.size()];
                for (int i = 0; i < blocks.size(); i++) {
                  this.blocks[i] = FSEditLogOp.blockFromXml(blocks.get(i));
                }
                readRpcIdsFromXml(st);
              }
          

          XMLUtils$Stanza.getChildren:

              public List<Stanza> getChildren(String name) throws InvalidXmlException {
                LinkedList <Stanza> children = subtrees.get(name);
                if (children == null) {
                  throw new InvalidXmlException("no entry found for " + name);
                }
                return children;
              }
          

          When OEV tool encountered the OP_UPDATE_BLOCKS operation with no BLOCK tag, it will throw Exception and exits.
          Both 2.4.1 and 2.7.1 have the same problem.

          Show
          wanchang Wan Chang added a comment - FSEditLogOp$UpdateBlocksOp.fromXml: void fromXml(Stanza st) throws InvalidXmlException { this .path = st.getValue( "PATH" ); List<Stanza> blocks = st.getChildren( "BLOCK" ); this .blocks = new Block[blocks.size()]; for ( int i = 0; i < blocks.size(); i++) { this .blocks[i] = FSEditLogOp.blockFromXml(blocks.get(i)); } readRpcIdsFromXml(st); } XMLUtils$Stanza.getChildren: public List<Stanza> getChildren( String name) throws InvalidXmlException { LinkedList <Stanza> children = subtrees.get(name); if (children == null ) { throw new InvalidXmlException( "no entry found for " + name); } return children; } When OEV tool encountered the OP_UPDATE_BLOCKS operation with no BLOCK tag, it will throw Exception and exits. Both 2.4.1 and 2.7.1 have the same problem.
          Hide
          wanchang Wan Chang added a comment -

          submit patch

          Show
          wanchang Wan Chang added a comment - submit patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 8s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 27s trunk passed
          +1 compile 0m 38s trunk passed with JDK v1.8.0_77
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 53s trunk passed
          +1 javadoc 1m 3s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_77
          +1 javac 0m 35s the patch passed
          +1 compile 0m 39s the patch passed with JDK v1.7.0_95
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 1m 0s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_95
          -1 unit 56m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 53m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          134m 30s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797251/HDFS-10265-001.patch
          JIRA Issue HDFS-10265
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fb0c22f2aa42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 21eb428
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15085/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15085/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 27s trunk passed +1 compile 0m 38s trunk passed with JDK v1.8.0_77 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 1m 3s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 44s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 44s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_77 +1 javac 0m 35s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 0s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_95 -1 unit 56m 18s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 53m 44s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 134m 30s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.namenode.TestEditLog JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797251/HDFS-10265-001.patch JIRA Issue HDFS-10265 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fb0c22f2aa42 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 21eb428 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15085/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15085/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15085/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Good find, Wan Chang.

          1016	      List<Stanza> blocks;
          1017	      try {
          1018	        blocks = st.getChildren("BLOCK");
          1019	      } catch (InvalidXmlException ignore) {
          1020	        blocks = new ArrayList<Stanza>();
          1021	      }
          

          Rather than doing catching a generic InvalidXmlException, please check with Stanza#hasChildren before calling Stanza#getChildren. That way we won't catch other invalid XML problems accidentally.

          Can you please add a unit test for this? The other oev tests are in: ./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java It sounds like we have to create an OP_UPDATE_BLOCKS with no blocks in order to test this.

          Show
          cmccabe Colin P. McCabe added a comment - Good find, Wan Chang . 1016 List<Stanza> blocks; 1017 try { 1018 blocks = st.getChildren( "BLOCK" ); 1019 } catch (InvalidXmlException ignore) { 1020 blocks = new ArrayList<Stanza>(); 1021 } Rather than doing catching a generic InvalidXmlException , please check with Stanza#hasChildren before calling Stanza#getChildren . That way we won't catch other invalid XML problems accidentally. Can you please add a unit test for this? The other oev tests are in: ./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/TestOfflineEditsViewer.java It sounds like we have to create an OP_UPDATE_BLOCKS with no blocks in order to test this.
          Hide
          wanchang Wan Chang added a comment -

          Sorry for the late to relay. Thanks for your suggestions, I will update this patch soon.

          Show
          wanchang Wan Chang added a comment - Sorry for the late to relay. Thanks for your suggestions, I will update this patch soon.
          Hide
          wanchang Wan Chang added a comment -

          submit patch

          Show
          wanchang Wan Chang added a comment - submit patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 47s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 0m 40s trunk passed with JDK v1.8.0_77
          +1 compile 0m 40s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 26s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_77
          +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 0m 35s the patch passed with JDK v1.8.0_77
          +1 javac 0m 35s the patch passed
          +1 compile 0m 40s the patch passed with JDK v1.7.0_95
          +1 javac 0m 40s the patch passed
          -1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 314 unchanged - 1 fixed = 315 total (was 315)
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 1m 3s the patch passed with JDK v1.8.0_77
          +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95
          -1 unit 55m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
          -1 unit 51m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          146m 5s



          Reason Tests
          JDK v1.8.0_77 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.TestHFlush
            hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:fbe3e86
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799267/HDFS-10265-002.patch
          JIRA Issue HDFS-10265
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d953e34ca7b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d8b729e
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15184/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15184/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 47s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 0m 40s trunk passed with JDK v1.8.0_77 +1 compile 0m 40s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 26s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_77 +1 javadoc 1m 48s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 0m 35s the patch passed with JDK v1.8.0_77 +1 javac 0m 35s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_95 +1 javac 0m 40s the patch passed -1 checkstyle 0m 23s hadoop-hdfs-project/hadoop-hdfs: patch generated 1 new + 314 unchanged - 1 fixed = 315 total (was 315) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 1m 3s the patch passed with JDK v1.8.0_77 +1 javadoc 1m 45s the patch passed with JDK v1.7.0_95 -1 unit 55m 58s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 51m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 146m 5s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestHFlush   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.server.namenode.TestNamenodeRetryCache   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12799267/HDFS-10265-002.patch JIRA Issue HDFS-10265 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d953e34ca7b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8b729e Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15184/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15184/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15184/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Wan Chang.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Wan Chang .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9628 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9628/)
          HDFS-10265. OEV tool fails to read edit xml file if OP_UPDATE_BLOCKS has (cmccabe: rev cb3ca460efb97be8c031bdb14bb7705cc25f2117)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9628 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9628/ ) HDFS-10265 . OEV tool fails to read edit xml file if OP_UPDATE_BLOCKS has (cmccabe: rev cb3ca460efb97be8c031bdb14bb7705cc25f2117) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogOp.java
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Following two testcases are failing after this in...Even above jenkins report shows this failures... will raise seperate jira to track this...

          FAILED:  org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache.testRetryCacheRebuild
          
          Error Message:
          expected:<25> but was:<26>
          
          Stack Trace:
          java.lang.AssertionError: expected:<25> but was:<26>
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.junit.Assert.failNotEquals(Assert.java:743)
          	at org.junit.Assert.assertEquals(Assert.java:118)
          	at org.junit.Assert.assertEquals(Assert.java:555)
          	at org.junit.Assert.assertEquals(Assert.java:542)
          	at org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache.testRetryCacheRebuild(TestNamenodeRetryCache.java:419)
          
          
          FAILED:  org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA.testRetryCacheOnStandbyNN
          
          Error Message:
          expected:<25> but was:<26>
          
          Stack Trace:
          java.lang.AssertionError: expected:<25> but was:<26>
          	at org.junit.Assert.fail(Assert.java:88)
          	at org.junit.Assert.failNotEquals(Assert.java:743)
          	at org.junit.Assert.assertEquals(Assert.java:118)
          	at org.junit.Assert.assertEquals(Assert.java:555)
          	at org.junit.Assert.assertEquals(Assert.java:542)
          	at org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA.testRetryCacheOnStandbyNN(TestRetryCacheWithHA.java:169)
          
          Show
          brahmareddy Brahma Reddy Battula added a comment - Following two testcases are failing after this in...Even above jenkins report shows this failures... will raise seperate jira to track this... FAILED: org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache.testRetryCacheRebuild Error Message: expected:<25> but was:<26> Stack Trace: java.lang.AssertionError: expected:<25> but was:<26> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache.testRetryCacheRebuild(TestNamenodeRetryCache.java:419) FAILED: org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA.testRetryCacheOnStandbyNN Error Message: expected:<25> but was:<26> Stack Trace: java.lang.AssertionError: expected:<25> but was:<26> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA.testRetryCacheOnStandbyNN(TestRetryCacheWithHA.java:169)
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Brahma Reddy Battula. Yesterday I've raised a jira HDFS-10308 to fix this. Would be great to see your feedback on the proposed patch in that jira.

          Show
          rakeshr Rakesh R added a comment - Thanks Brahma Reddy Battula . Yesterday I've raised a jira HDFS-10308 to fix this. Would be great to see your feedback on the proposed patch in that jira.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Rakesh R and Brahma Reddy Battula. I will take a look at HDFS-10308.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Rakesh R and Brahma Reddy Battula . I will take a look at HDFS-10308 .

            People

            • Assignee:
              wanchang Wan Chang
              Reporter:
              wanchang Wan Chang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development