Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10235

[NN UI] Last contact for Live Nodes should be relative time

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Last contact for Live Nodes should be relative time and we can keep absolute date for Dead Nodes. Relative time will be more convenient to know the last contact , we no need to extra maths here.

      1. HDFS-10235-002.patch
        0.9 kB
        Brahma Reddy Battula
      2. HDFS-10235.patch
        0.9 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Ravi Prakash thanks a lot for review and commit..And thanks to Akira Ajisaka for additional review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Ravi Prakash thanks a lot for review and commit..And thanks to Akira Ajisaka for additional review.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9563 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9563/)
        HDFS-10235. Last contact for Live Nodes should be relative time. (raviprak: rev 0cd320a8463efe19a6228f9fe14693aa37ac8a10)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9563 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9563/ ) HDFS-10235 . Last contact for Live Nodes should be relative time. (raviprak: rev 0cd320a8463efe19a6228f9fe14693aa37ac8a10) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Hide
        raviprak Ravi Prakash added a comment -

        Committed to trunk, branch-2 and branch-2.8

        Show
        raviprak Ravi Prakash added a comment - Committed to trunk, branch-2 and branch-2.8
        Hide
        raviprak Ravi Prakash added a comment -

        Thanks Brahma! LGTM. +1. Committing shortly

        Show
        raviprak Ravi Prakash added a comment - Thanks Brahma! LGTM. +1. Committing shortly
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 16m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        16m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796973/HDFS-10235-002.patch
        JIRA Issue HDFS-10235
        Optional Tests asflicense
        uname Linux d75049bd308b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 818d6b7
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15062/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 16m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 16m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12796973/HDFS-10235-002.patch JIRA Issue HDFS-10235 Optional Tests asflicense uname Linux d75049bd308b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 818d6b7 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15062/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch..Added the time unit(sec) for Live Nodes..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch..Added the time unit(sec) for Live Nodes..
        Hide
        raviprak Ravi Prakash added a comment -

        I too am +1 for relative time for live nodes and absolute time for dead nodes.

        Show
        raviprak Ravi Prakash added a comment - I too am +1 for relative time for live nodes and absolute time for dead nodes.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        lastContact is given as seconds itself from the NameNode. It is being converted to absolute time stamp in UI side.

        Now if we convert that to msec, it will be in multiples of 1000 itself.
        So, its better to be in seconds itself. as this is only for user/admin to see. Not for any metrics.

        Show
        brahmareddy Brahma Reddy Battula added a comment - lastContact is given as seconds itself from the NameNode. It is being converted to absolute time stamp in UI side. Now if we convert that to msec, it will be in multiples of 1000 itself. So, its better to be in seconds itself. as this is only for user/admin to see. Not for any metrics.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        One comment for the patch:

        dfshealth.html
        <table class="table" id="table-datanodes">
          <thead>
            <tr>
              <th>Node</th>
              <th>Last contact</th>
        
        • Would you add a time unit (msec?) to the last contact?
        Show
        ajisakaa Akira Ajisaka added a comment - One comment for the patch: dfshealth.html <table class= "table" id= "table-datanodes" > <thead> <tr> <th>Node</th> <th>Last contact</th> Would you add a time unit (msec?) to the last contact?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Sorry, I missed that. I'm +1 for this change. Relative time for only live nodes is good, but there is an inconsistency between live nodes and dead nodes. However, it is (hopefully) rare case that there are live nodes and dead nodes at the same time, so the inconsistency is acceptable for me. What do you think, Ravi Prakash?

        Show
        ajisakaa Akira Ajisaka added a comment - Sorry, I missed that. I'm +1 for this change. Relative time for only live nodes is good, but there is an inconsistency between live nodes and dead nodes. However, it is (hopefully) rare case that there are live nodes and dead nodes at the same time, so the inconsistency is acceptable for me. What do you think, Ravi Prakash ?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        its only for live nodes. Not for dead nodes.

        Show
        brahmareddy Brahma Reddy Battula added a comment - its only for live nodes. Not for dead nodes.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I'm -1 for the proposal. Absolute time is good for administrators to know when a failure happens without calculation. They are using absolute time for searching the daemon logs.

        Show
        ajisakaa Akira Ajisaka added a comment - I'm -1 for the proposal. Absolute time is good for administrators to know when a failure happens without calculation. They are using absolute time for searching the daemon logs.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch.Kindly review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch.Kindly review.

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development