Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10223

peerFromSocketAndKey performs SASL exchange before setting connection timeouts

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.4
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      peerFromSocketAndKey performs the SASL exchange before setting up connection timeouts. Because of this, the timeout used for setting up SASL connections is the default system-wide TCP timeout, which is usually several hours long.

      1. HDFS-10223.001.patch
        7 kB
        Colin P. McCabe
      2. HDFS-10223.002.patch
        8 kB
        Colin P. McCabe

        Activity

        Hide
        busbey Sean Busbey added a comment -

        +1 non-binding, pending non-surprising buildbot feedback

        Show
        busbey Sean Busbey added a comment - +1 non-binding, pending non-surprising buildbot feedback
        Hide
        cnauroth Chris Nauroth added a comment -

        Thank you, Colin. This is a good catch. In the test, would you please close serverSocket and socket in a finally block, or use try-with-resources?

        Show
        cnauroth Chris Nauroth added a comment - Thank you, Colin. This is a good catch. In the test, would you please close serverSocket and socket in a finally block, or use try-with-resources?
        Hide
        cmccabe Colin P. McCabe added a comment -
        • Add IOUtils#cleanup in the unit test in a finally block
        Show
        cmccabe Colin P. McCabe added a comment - Add IOUtils#cleanup in the unit test in a finally block
        Hide
        cnauroth Chris Nauroth added a comment -

        +1 for patch v002, pending pre-commit. Thank you for making the update.

        Show
        cnauroth Chris Nauroth added a comment - +1 for patch v002, pending pre-commit. Thank you for making the update.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks for the reviews, Chris Nauroth and Sean Busbey.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks for the reviews, Chris Nauroth and Sean Busbey .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 6m 47s trunk passed
        +1 compile 1m 16s trunk passed with JDK v1.8.0_77
        +1 compile 1m 24s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 1m 23s trunk passed
        +1 mvneclipse 0m 25s trunk passed
        +1 findbugs 3m 37s trunk passed
        +1 javadoc 1m 22s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 9s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 16s the patch passed
        +1 compile 1m 10s the patch passed with JDK v1.8.0_77
        +1 javac 1m 10s the patch passed
        +1 compile 1m 19s the patch passed with JDK v1.7.0_95
        -1 javac 3m 53s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 49 unchanged - 1 fixed = 50 total (was 50)
        +1 javac 1m 19s the patch passed
        +1 checkstyle 0m 26s the patch passed
        +1 mvnsite 1m 20s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 4m 0s the patch passed
        +1 javadoc 1m 20s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95
        +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_77.
        -1 unit 55m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95.
        -1 unit 52m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 22s Patch generated 1 ASF License warnings.
        145m 4s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.datanode.TestDataNodeLifeline
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795712/HDFS-10223.002.patch
        JIRA Issue HDFS-10223
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 363c679c2e37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ddfe677
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14991/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14991/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 47s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_77 +1 compile 1m 24s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 31s trunk passed +1 mvnsite 1m 23s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 37s trunk passed +1 javadoc 1m 22s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 9s trunk passed with JDK v1.7.0_95 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 16s the patch passed +1 compile 1m 10s the patch passed with JDK v1.8.0_77 +1 javac 1m 10s the patch passed +1 compile 1m 19s the patch passed with JDK v1.7.0_95 -1 javac 3m 53s hadoop-hdfs-project-jdk1.7.0_95 with JDK v1.7.0_95 generated 1 new + 49 unchanged - 1 fixed = 50 total (was 50) +1 javac 1m 19s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 4m 0s the patch passed +1 javadoc 1m 20s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 7s the patch passed with JDK v1.7.0_95 +1 unit 0m 48s hadoop-hdfs-client in the patch passed with JDK v1.8.0_77. -1 unit 55m 33s hadoop-hdfs in the patch failed with JDK v1.8.0_77. +1 unit 0m 57s hadoop-hdfs-client in the patch passed with JDK v1.7.0_95. -1 unit 52m 28s hadoop-hdfs in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 22s Patch generated 1 ASF License warnings. 145m 4s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.datanode.TestDataNodeLifeline JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795712/HDFS-10223.002.patch JIRA Issue HDFS-10223 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 363c679c2e37 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ddfe677 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 javac hadoop-hdfs-project-jdk1.7.0_95: https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/diff-compile-javac-hadoop-hdfs-project-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14991/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14991/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14991/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Finally got a jenkins run. Committed to 2.8. Thanks, all.

        Show
        cmccabe Colin P. McCabe added a comment - Finally got a jenkins run. Committed to 2.8. Thanks, all.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9528 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9528/)
        HDFS-10223. peerFromSocketAndKey performs SASL exchange before setting (cmccabe: rev 37e23ce45c592f3c9c48a08a52a5f46787f6c0e9)

        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/TestSaslDataTransfer.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
        • hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9528 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9528/ ) HDFS-10223 . peerFromSocketAndKey performs SASL exchange before setting (cmccabe: rev 37e23ce45c592f3c9c48a08a52a5f46787f6c0e9) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/TestSaslDataTransfer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/erasurecode/ErasureCodingWorker.java

          People

          • Assignee:
            cmccabe Colin P. McCabe
            Reporter:
            cmccabe Colin P. McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development