Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10217

show 'blockScheduled' tooltip in datanodes table.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It will more useful for debugging purpose where user can see how many blocks got schduled for DN

      1. HDFS-10217.patch
        2 kB
        Brahma Reddy Battula
      2. HDFS-10217-002.patch
        0.7 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch. Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch. Kindly Review.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        -1 asflicense 0m 18s Patch generated 1 ASF License warnings.
        0m 44s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795509/HDFS-10217.patch
        JIRA Issue HDFS-10217
        Optional Tests asflicense
        uname Linux 7546561d723e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e5ff0ea
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14949/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14949/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. -1 asflicense 0m 18s Patch generated 1 ASF License warnings. 0m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795509/HDFS-10217.patch JIRA Issue HDFS-10217 Optional Tests asflicense uname Linux 7546561d723e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5ff0ea asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14949/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14949/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Patch generated 1 ASF License warnings.

        not related to this patch..This is introduced in HDFS-9005.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Patch generated 1 ASF License warnings. not related to this patch..This is introduced in HDFS-9005 .
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        can anybody review this..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - can anybody review this..?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Ravi Prakash can you review this..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Ravi Prakash can you review this..?
        Hide
        raviprak Ravi Prakash added a comment -

        What is the motivation behind this Brahma? Besides I see this returns (currApproxBlocksScheduled.sum() + prevApproxBlocksScheduled.sum() . If its to check how busy a datanode is at present, a lot factors come into play. e.g. the block sizes of the blocks, the heartbeat frequency, other readers, writers etc.

        Show
        raviprak Ravi Prakash added a comment - What is the motivation behind this Brahma? Besides I see this returns (currApproxBlocksScheduled.sum() + prevApproxBlocksScheduled.sum() . If its to check how busy a datanode is at present, a lot factors come into play. e.g. the block sizes of the blocks, the heartbeat frequency, other readers, writers etc.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        If its to check how busy a datanode is at present, a lot factors come into play. e.g. the block sizes of the blocks, the heartbeat frequency, other readers, writers etc.

        Mainly for debugging purpose..It will be visible to the admins which DN's got scheduled more blocks...Block size can be checked, heabeat frequncy also checked through last contact.

        Show
        brahmareddy Brahma Reddy Battula added a comment - If its to check how busy a datanode is at present, a lot factors come into play. e.g. the block sizes of the blocks, the heartbeat frequency, other readers, writers etc. Mainly for debugging purpose..It will be visible to the admins which DN's got scheduled more blocks...Block size can be checked, heabeat frequncy also checked through last contact.
        Hide
        vinayrpet Vinayakumar B added a comment -

        How about making it scheduled count as a "tooltip" for the "blocks" column, similar to 'old jsp webui' so that extra column need not be added.?

        Show
        vinayrpet Vinayakumar B added a comment - How about making it scheduled count as a "tooltip" for the "blocks" column, similar to 'old jsp webui' so that extra column need not be added.?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        I am ok with making tooltip.. uploaded the patch..Kindly review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - I am ok with making tooltip.. uploaded the patch..Kindly review..
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 12m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 asflicense 0m 25s Patch does not generate ASF License warnings.
        12m 55s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802166/HDFS-10217-002.patch
        JIRA Issue HDFS-10217
        Optional Tests asflicense
        uname Linux 3ae6abe08926 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 355325b
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15358/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 12m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s Patch has no whitespace issues. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 12m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12802166/HDFS-10217-002.patch JIRA Issue HDFS-10217 Optional Tests asflicense uname Linux 3ae6abe08926 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 355325b modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15358/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Tooltip patch looks good. +1
        Ravi Prakash, Can you also take a look?

        I am planning to commit this tomorrow, unless there is something to be addressed, from Ravi.

        Show
        vinayrpet Vinayakumar B added a comment - Tooltip patch looks good. +1 Ravi Prakash , Can you also take a look? I am planning to commit this tomorrow, unless there is something to be addressed, from Ravi.
        Hide
        raviprak Ravi Prakash added a comment -

        I'm fine with exposing the information as a tooltip.

        Show
        raviprak Ravi Prakash added a comment - I'm fine with exposing the information as a tooltip.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk, branch-2 and branch-2.8.

        Thanks Brahma Reddy Battula for the contribution.
        Thanks Ravi Prakash for reviews.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks Brahma Reddy Battula for the contribution. Thanks Ravi Prakash for reviews.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9855/)
        HDFS-10217. show 'blockScheduled' tooltip in datanodes table. (vinayakumarb: rev 2dab64da2ff50bbb7937aad2d376eacd4ed320aa)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9855 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9855/ ) HDFS-10217 . show 'blockScheduled' tooltip in datanodes table. (vinayakumarb: rev 2dab64da2ff50bbb7937aad2d376eacd4ed320aa) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Vinayakumar B thanks for review and commit and thanks to Ravi Prakash for additional review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Vinayakumar B thanks for review and commit and thanks to Ravi Prakash for additional review..

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development