Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: datanode
    • Labels:

      Activity

      Hide
      hanm Michael Han added a comment -
      Show
      hanm Michael Han added a comment - Andrew Wang PTAL
      Hide
      jzhuge John Zhuge added a comment -

      +1 LGTM

      Show
      jzhuge John Zhuge added a comment - +1 LGTM
      Hide
      fabbri Aaron Fabbri added a comment -

      +1

      Show
      fabbri Aaron Fabbri added a comment - +1
      Hide
      andrew.wang Andrew Wang added a comment -

      LGTM to me too, thanks for the find and fix Michael. Will commit when Jenkins comes back.

      Show
      andrew.wang Andrew Wang added a comment - LGTM to me too, thanks for the find and fix Michael. Will commit when Jenkins comes back.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 8s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 6m 39s trunk passed
      +1 compile 0m 41s trunk passed with JDK v1.8.0_74
      +1 compile 0m 42s trunk passed with JDK v1.7.0_95
      +1 checkstyle 0m 20s trunk passed
      +1 mvnsite 0m 52s trunk passed
      +1 mvneclipse 0m 13s trunk passed
      +1 findbugs 1m 57s trunk passed
      +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74
      +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95
      +1 mvninstall 0m 45s the patch passed
      +1 compile 0m 38s the patch passed with JDK v1.8.0_74
      +1 javac 0m 38s the patch passed
      +1 compile 0m 39s the patch passed with JDK v1.7.0_95
      +1 javac 0m 39s the patch passed
      +1 checkstyle 0m 18s the patch passed
      +1 mvnsite 0m 49s the patch passed
      +1 mvneclipse 0m 11s the patch passed
      +1 whitespace 0m 0s Patch has no whitespace issues.
      +1 findbugs 2m 8s the patch passed
      +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74
      +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95
      -1 unit 61m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
      -1 unit 56m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
      +1 asflicense 0m 21s Patch does not generate ASF License warnings.
      143m 13s



      Reason Tests
      JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation
        hadoop.hdfs.TestCrcCorruption
        hadoop.hdfs.TestEncryptionZones
        hadoop.hdfs.server.datanode.TestDataNodeLifeline
      JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:0ca8df7
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793808/HDFS-10173.1.patch
      JIRA Issue HDFS-10173
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 44755bb7d81b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 605fdcb
      Default Java 1.7.0_95
      Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
      findbugs v3.0.0
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
      unit https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
      JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14843/testReport/
      modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14843/console
      Powered by Apache Yetus 0.2.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 39s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_74 +1 compile 0m 42s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 1m 8s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 47s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 38s the patch passed with JDK v1.8.0_74 +1 javac 0m 38s the patch passed +1 compile 0m 39s the patch passed with JDK v1.7.0_95 +1 javac 0m 39s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 4s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 44s the patch passed with JDK v1.7.0_95 -1 unit 61m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 56m 40s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 143m 13s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.server.blockmanagement.TestRBWBlockInvalidation   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDataNodeLifeline JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793808/HDFS-10173.1.patch JIRA Issue HDFS-10173 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 44755bb7d81b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 605fdcb Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14843/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14843/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14843/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
      Hide
      andrew.wang Andrew Wang added a comment -

      Committed to trunk and branch-2, thanks Michael!

      Show
      andrew.wang Andrew Wang added a comment - Committed to trunk and branch-2, thanks Michael!
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #9470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9470/)
      HDFS-10173. Typo in DataXceiverServer. Contributed by Michael Han. (wang: rev 02a250db9f4bc54436cd9900a084215e5e3c8dae)

      • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9470/ ) HDFS-10173 . Typo in DataXceiverServer. Contributed by Michael Han. (wang: rev 02a250db9f4bc54436cd9900a084215e5e3c8dae) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java

        People

        • Assignee:
          hanm Michael Han
          Reporter:
          hanm Michael Han
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development