Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-10172

hdfs erasurecode command should remove the redundant -usage option

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: erasure-coding
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      hdfs erasurecode has two similar options -help and -usage.

      hdfs erasurecode -usage getPolicy
      Usage: hdfs erasurecode [generic options] -getPolicy <path>
      
      hdfs erasurecode -help getPolicy
      -getPolicy <path> :
        Get erasure coding policy information about at specified path
      

      I don't think the -usage option is that useful, because -help option already covers that. No other HDFS commands has the same -usage command.

      1. HDFS-10172.001.patch
        2 kB
        Yuanbo Liu
      2. HDFS-10172.002.patch
        4 kB
        Yuanbo Liu

        Activity

        Hide
        yuanbo Yuanbo Liu added a comment -

        The reason why other hdfs commands do not have -usage command is that those classes of commands override the method "run" when they inherit FsShell, but the class of command "erasurecode" does not override it.

        Show
        yuanbo Yuanbo Liu added a comment - The reason why other hdfs commands do not have -usage command is that those classes of commands override the method "run" when they inherit FsShell, but the class of command "erasurecode" does not override it.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 9m 18s trunk passed
        +1 compile 1m 14s trunk passed with JDK v1.8.0_77
        +1 compile 0m 57s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 2m 22s trunk passed
        +1 javadoc 1m 41s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 27s trunk passed with JDK v1.7.0_95
        +1 mvninstall 1m 5s the patch passed
        +1 compile 1m 8s the patch passed with JDK v1.8.0_77
        +1 javac 1m 8s the patch passed
        +1 compile 0m 53s the patch passed with JDK v1.7.0_95
        +1 javac 0m 53s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 1m 5s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 2m 35s the patch passed
        +1 javadoc 1m 44s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 24s the patch passed with JDK v1.7.0_95
        -1 unit 108m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 133m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 51s Patch does not generate ASF License warnings.
        278m 28s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.TestFileAppend
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.TestSafeModeWithStripedFile
          hadoop.hdfs.TestReconstructStripedFile
          hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.fs.contract.hdfs.TestHDFSContractSeek
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.TestPersistBlocks
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.TestDataTransferKeepalive
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestReconstructStripedFile
          hadoop.hdfs.server.namenode.TestFileTruncate
          hadoop.hdfs.TestEncryptionZones
          hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.fs.contract.hdfs.TestHDFSContractSeek
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797672/HDFS-10172.001.patch
        JIRA Issue HDFS-10172
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux f1a5e8fb7d89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1b78b2b
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15130/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15130/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 18s trunk passed +1 compile 1m 14s trunk passed with JDK v1.8.0_77 +1 compile 0m 57s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 8s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 22s trunk passed +1 javadoc 1m 41s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 27s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 5s the patch passed +1 compile 1m 8s the patch passed with JDK v1.8.0_77 +1 javac 1m 8s the patch passed +1 compile 0m 53s the patch passed with JDK v1.7.0_95 +1 javac 0m 53s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 5s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 35s the patch passed +1 javadoc 1m 44s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 24s the patch passed with JDK v1.7.0_95 -1 unit 108m 55s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 133m 55s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 51s Patch does not generate ASF License warnings. 278m 28s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.fs.contract.hdfs.TestHDFSContractSeek JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.namenode.TestNameNodeMetadataConsistency   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.TestPersistBlocks   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.server.namenode.TestFileTruncate   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaRecovery   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.fs.contract.hdfs.TestHDFSContractSeek JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12797672/HDFS-10172.001.patch JIRA Issue HDFS-10172 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f1a5e8fb7d89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1b78b2b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15130/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15130/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15130/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 11m 52s trunk passed
        +1 compile 1m 48s trunk passed with JDK v1.8.0_77
        +1 compile 1m 11s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 1m 28s trunk passed
        +1 mvneclipse 0m 21s trunk passed
        +1 findbugs 2m 58s trunk passed
        +1 javadoc 2m 20s trunk passed with JDK v1.8.0_77
        +1 javadoc 3m 18s trunk passed with JDK v1.7.0_95
        +1 mvninstall 1m 18s the patch passed
        +1 compile 1m 37s the patch passed with JDK v1.8.0_77
        +1 javac 1m 37s the patch passed
        +1 compile 1m 13s the patch passed with JDK v1.7.0_95
        +1 javac 1m 13s the patch passed
        +1 checkstyle 0m 30s the patch passed
        +1 mvnsite 1m 28s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 3m 14s the patch passed
        +1 javadoc 1m 55s the patch passed with JDK v1.8.0_77
        +1 javadoc 3m 8s the patch passed with JDK v1.7.0_95
        -1 unit 142m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 83m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 49s Patch does not generate ASF License warnings.
        271m 56s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.fs.TestSymlinkHdfsFileContext
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
          hadoop.hdfs.tools.TestDFSAdminWithHA
          hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
          org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
        JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager
          hadoop.hdfs.TestSafeMode
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.hdfs.server.namenode.ha.TestEditLogTailer
          hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
          hadoop.hdfs.TestPread
          hadoop.hdfs.web.TestFSMainOperationsWebHdfs
          hadoop.hdfs.TestSafeModeWithStripedFile
          hadoop.hdfs.TestDataTransferKeepalive
          hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
          org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
          org.apache.hadoop.hdfs.server.datanode.TestDiskError
          org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798279/HDFS-10172.001.patch
        JIRA Issue HDFS-10172
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 68bdf55f99d8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 437e9d6
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15140/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15140/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 52s trunk passed +1 compile 1m 48s trunk passed with JDK v1.8.0_77 +1 compile 1m 11s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 28s trunk passed +1 mvneclipse 0m 21s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 2m 20s trunk passed with JDK v1.8.0_77 +1 javadoc 3m 18s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 18s the patch passed +1 compile 1m 37s the patch passed with JDK v1.8.0_77 +1 javac 1m 37s the patch passed +1 compile 1m 13s the patch passed with JDK v1.7.0_95 +1 javac 1m 13s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 1m 28s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 14s the patch passed +1 javadoc 1m 55s the patch passed with JDK v1.8.0_77 +1 javadoc 3m 8s the patch passed with JDK v1.7.0_95 -1 unit 142m 22s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 83m 19s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 49s Patch does not generate ASF License warnings. 271m 56s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.fs.TestSymlinkHdfsFileContext   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot   hadoop.hdfs.tools.TestDFSAdminWithHA   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.namenode.TestFSImageWithSnapshot   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestBlockManager   hadoop.hdfs.TestSafeMode   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.ha.TestEditLogTailer   hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.TestPread   hadoop.hdfs.web.TestFSMainOperationsWebHdfs   hadoop.hdfs.TestSafeModeWithStripedFile   hadoop.hdfs.TestDataTransferKeepalive   hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics   org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement   org.apache.hadoop.hdfs.server.datanode.TestDiskError   org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12798279/HDFS-10172.001.patch JIRA Issue HDFS-10172 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 68bdf55f99d8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 437e9d6 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15140/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15140/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15140/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Wei-Chiu for reporting the issue and Yuanbo for the fix.

        Looks like we should override FsShell#init? Since that's the place adding the usage option.

        Show
        zhz Zhe Zhang added a comment - Thanks Wei-Chiu for reporting the issue and Yuanbo for the fix. Looks like we should override FsShell#init ? Since that's the place adding the usage option.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Thanks for your review. I agree with you that it's more reasonable to override FsShell#init, but there will be two problems here if we override it:
        1. Help is a protected class of FsShell, we can't use it outside the package.
        2. There is a private variable in FsShell#init, if we override init, we have to move it out.
        So I think it's easier and less risk to reset commandFactory in registerCommands

        Show
        yuanbo Yuanbo Liu added a comment - Thanks for your review. I agree with you that it's more reasonable to override FsShell#init , but there will be two problems here if we override it: 1. Help is a protected class of FsShell , we can't use it outside the package. 2. There is a private variable in FsShell#init , if we override init , we have to move it out. So I think it's easier and less risk to reset commandFactory in registerCommands
        Hide
        yuanbo Yuanbo Liu added a comment -

        These are my local test results of the failed test cases.
        jdk1.7
        Running org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
        Tests run: 11, Failures: 0, Errors: 0, Skipped: 11, Time elapsed: 0.424 sec - in org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
        Running org.apache.hadoop.hdfs.TestSafeMode
        Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.559 sec - in org.apache.hadoop.hdfs.TestSafeMode
        Running org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
        Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.659 sec - in org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
        Running org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
        Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.608 sec - in org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
        Running org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager
        Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.51 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager
        Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
        Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.267 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics
        Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.02 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        Running org.apache.hadoop.hdfs.server.datanode.TestDiskError
        Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.955 sec - in org.apache.hadoop.hdfs.server.datanode.TestDiskError
        Running org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
        Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.874 sec - in org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
        Running org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
        Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.611 sec - in org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports
        Running org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.536 sec - in org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        Running org.apache.hadoop.hdfs.TestDataTransferKeepalive
        Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.264 sec - in org.apache.hadoop.hdfs.TestDataTransferKeepalive
        Running org.apache.hadoop.hdfs.TestPread
        Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 109.372 sec - in org.apache.hadoop.hdfs.TestPread
        Running org.apache.hadoop.hdfs.TestSafeModeWithStripedFile
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.766 sec - in org.apache.hadoop.hdfs.TestSafeModeWithStripedFile
        Running org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks
        Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.233 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks
        Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.724 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

        jdk1.8
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.fs.TestSymlinkHdfsFileContext
        Tests run: 71, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.692 sec - in org.apache.hadoop.fs.TestSymlinkHdfsFileContext
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
        Tests run: 11, Failures: 0, Errors: 0, Skipped: 11, Time elapsed: 0.262 sec - in org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA
        Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.443 sec - in org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
        Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.566 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
        Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.069 sec - in org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.93 sec - in org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
        Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.999 sec - in org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.343 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.433 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeUUID
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.005 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeUUID
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.473 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
        Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.029 sec - in org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.312 sec - in org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks
        Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.171 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.TestWriteReadStripedFile
        Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 124.776 sec - in org.apache.hadoop.hdfs.TestWriteReadStripedFile
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0
        Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
        Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 117.961 sec - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

        Show
        yuanbo Yuanbo Liu added a comment - These are my local test results of the failed test cases. jdk1.7 Running org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead Tests run: 11, Failures: 0, Errors: 0, Skipped: 11, Time elapsed: 0.424 sec - in org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead Running org.apache.hadoop.hdfs.TestSafeMode Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.559 sec - in org.apache.hadoop.hdfs.TestSafeMode Running org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs Tests run: 52, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.659 sec - in org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs Running org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.608 sec - in org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer Running org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.51 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestBlockManager Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 44.267 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.02 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Running org.apache.hadoop.hdfs.server.datanode.TestDiskError Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.955 sec - in org.apache.hadoop.hdfs.server.datanode.TestDiskError Running org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 27.874 sec - in org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement Running org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.611 sec - in org.apache.hadoop.hdfs.server.datanode.TestIncrementalBlockReports Running org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.536 sec - in org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser Running org.apache.hadoop.hdfs.TestDataTransferKeepalive Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.264 sec - in org.apache.hadoop.hdfs.TestDataTransferKeepalive Running org.apache.hadoop.hdfs.TestPread Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 109.372 sec - in org.apache.hadoop.hdfs.TestPread Running org.apache.hadoop.hdfs.TestSafeModeWithStripedFile Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.766 sec - in org.apache.hadoop.hdfs.TestSafeModeWithStripedFile Running org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 42.233 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.724 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl jdk1.8 Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.fs.TestSymlinkHdfsFileContext Tests run: 71, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.692 sec - in org.apache.hadoop.fs.TestSymlinkHdfsFileContext Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead Tests run: 11, Failures: 0, Errors: 0, Skipped: 11, Time elapsed: 0.262 sec - in org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.443 sec - in org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.566 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.069 sec - in org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogTailer Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 65.93 sec - in org.apache.hadoop.hdfs.server.namenode.snapshot.TestOpenFilesWithSnapshot Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 51.999 sec - in org.apache.hadoop.hdfs.server.namenode.TestFSImageWithSnapshot Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.343 sec - in org.apache.hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 34.433 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.datanode.TestDataNodeUUID Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.005 sec - in org.apache.hadoop.hdfs.server.datanode.TestDataNodeUUID Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.473 sec - in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.029 sec - in org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.312 sec - in org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 43.171 sec - in org.apache.hadoop.hdfs.TestReadStripedFileWithMissingBlocks Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestWriteReadStripedFile Tests run: 17, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 124.776 sec - in org.apache.hadoop.hdfs.TestWriteReadStripedFile Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=768m; support was removed in 8.0 Running org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 117.961 sec - in org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
        Hide
        yuanbo Yuanbo Liu added a comment -

        Zhe Zhang would you please help me review my comments and patch?
        Thanks in advance.

        Show
        yuanbo Yuanbo Liu added a comment - Zhe Zhang would you please help me review my comments and patch? Thanks in advance.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks for checking all Jenkins test failures Yuanbo. Yes I believe none is related to this EC Cli change.

        How about making the following changes so we can override FsShell#init?

        1. Make FsShell#tracer final and assign the value at declaration. private final tracer = new Tracer.Builderxxx
        2. Create a protected method createHelp() which calls new Help().

        I still think this is better than overriding registerCommands, since the logic is a little more clear.

        Show
        zhz Zhe Zhang added a comment - Thanks for checking all Jenkins test failures Yuanbo. Yes I believe none is related to this EC Cli change. How about making the following changes so we can override FsShell#init ? Make FsShell#tracer final and assign the value at declaration. private final tracer = new Tracer.Builderxxx Create a protected method createHelp() which calls new Help() . I still think this is better than overriding registerCommands , since the logic is a little more clear.
        Hide
        yuanbo Yuanbo Liu added a comment -

        Zhe Zhang Thanks for your comment

        Make FsShell#tracer final and assign the value at declaration. private final tracer = new Tracer.Builderxxx

        Before instancing {{ FsShell#tracer}}, there is a sentence to set configuration, and tracer seems depending on the configuration. See the details as below

        getConf().setQuietMode(true);
        ......
        this.tracer = new Tracer.Builder("FsShell").
                conf(TraceUtils.wrapHadoopConf(SHELL_HTRACE_PREFIX, getConf())).
                build();
        

        So I think it's better to move tracer to run method and make it as a local variable. What's your opinion ?

        Show
        yuanbo Yuanbo Liu added a comment - Zhe Zhang Thanks for your comment Make FsShell#tracer final and assign the value at declaration. private final tracer = new Tracer.Builderxxx Before instancing {{ FsShell#tracer}}, there is a sentence to set configuration, and tracer seems depending on the configuration. See the details as below getConf().setQuietMode( true ); ...... this .tracer = new Tracer.Builder( "FsShell" ). conf(TraceUtils.wrapHadoopConf(SHELL_HTRACE_PREFIX, getConf())). build(); So I think it's better to move tracer to run method and make it as a local variable. What's your opinion ?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 15s Maven dependency ordering for branch
        +1 mvninstall 6m 30s trunk passed
        +1 compile 5m 40s trunk passed with JDK v1.8.0_77
        +1 compile 6m 33s trunk passed with JDK v1.7.0_95
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 1m 46s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 3m 26s trunk passed
        +1 javadoc 1m 54s trunk passed with JDK v1.8.0_77
        +1 javadoc 2m 46s trunk passed with JDK v1.7.0_95
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 25s the patch passed
        +1 compile 5m 39s the patch passed with JDK v1.8.0_77
        +1 javac 5m 39s the patch passed
        +1 compile 6m 37s the patch passed with JDK v1.7.0_95
        +1 javac 6m 37s the patch passed
        +1 checkstyle 1m 4s the patch passed
        +1 mvnsite 1m 47s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        +1 findbugs 3m 58s the patch passed
        +1 javadoc 1m 58s the patch passed with JDK v1.8.0_77
        +1 javadoc 2m 48s the patch passed with JDK v1.7.0_95
        +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.8.0_77.
        -1 unit 68m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77.
        -1 unit 9m 8s hadoop-common in the patch failed with JDK v1.7.0_95.
        -1 unit 66m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
        +1 asflicense 0m 28s Patch does not generate ASF License warnings.
        210m 59s



        Reason Tests
        JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestDFSShell
          hadoop.hdfs.shortcircuit.TestShortCircuitCache
          hadoop.hdfs.server.namenode.TestEditLog
          hadoop.hdfs.TestFileAppend
        JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
        JDK v1.7.0_95 Failed junit tests hadoop.ha.TestZKFailoverController
          hadoop.hdfs.TestDFSShell
          hadoop.hdfs.TestHFlush
          hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800462/HDFS-10172.002.patch
        JIRA Issue HDFS-10172
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux c2f384e15caf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / c282a08
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15269/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15269/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 15s Maven dependency ordering for branch +1 mvninstall 6m 30s trunk passed +1 compile 5m 40s trunk passed with JDK v1.8.0_77 +1 compile 6m 33s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 3s trunk passed +1 mvnsite 1m 46s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 54s trunk passed with JDK v1.8.0_77 +1 javadoc 2m 46s trunk passed with JDK v1.7.0_95 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 5m 39s the patch passed with JDK v1.8.0_77 +1 javac 5m 39s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 1m 4s the patch passed +1 mvnsite 1m 47s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 0s The patch has no ill-formed XML file. +1 findbugs 3m 58s the patch passed +1 javadoc 1m 58s the patch passed with JDK v1.8.0_77 +1 javadoc 2m 48s the patch passed with JDK v1.7.0_95 +1 unit 7m 20s hadoop-common in the patch passed with JDK v1.8.0_77. -1 unit 68m 21s hadoop-hdfs in the patch failed with JDK v1.8.0_77. -1 unit 9m 8s hadoop-common in the patch failed with JDK v1.7.0_95. -1 unit 66m 47s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 210m 59s Reason Tests JDK v1.8.0_77 Failed junit tests hadoop.hdfs.TestDFSShell   hadoop.hdfs.shortcircuit.TestShortCircuitCache   hadoop.hdfs.server.namenode.TestEditLog   hadoop.hdfs.TestFileAppend JDK v1.8.0_77 Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2 JDK v1.7.0_95 Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.hdfs.TestDFSShell   hadoop.hdfs.TestHFlush   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800462/HDFS-10172.002.patch JIRA Issue HDFS-10172 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c2f384e15caf 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c282a08 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_77.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15269/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15269/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15269/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        yuanbo Yuanbo Liu added a comment -

        The failures are not related to the patch.
        Zhe Zhang please take a look if it's convenient for you. Thanks in advance.

        Show
        yuanbo Yuanbo Liu added a comment - The failures are not related to the patch. Zhe Zhang please take a look if it's convenient for you. Thanks in advance.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Yuanbo Liu! Patch 02 LGTM, +1 and I'm committing to trunk shortly.

        Show
        zhz Zhe Zhang added a comment - Thanks Yuanbo Liu ! Patch 02 LGTM, +1 and I'm committing to trunk shortly.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Yuanbo for the contribution and Wei-Chiu for reporting the task.

        Show
        zhz Zhe Zhang added a comment - Thanks Yuanbo for the contribution and Wei-Chiu for reporting the task.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9742 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9742/)
        HDFS-10172. hdfs erasurecode command should remove the redundant -usage (zhz: rev 307db61aac9f4b51301ab9d4e74be7632c42d62f)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/erasurecode/ECCli.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9742 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9742/ ) HDFS-10172 . hdfs erasurecode command should remove the redundant -usage (zhz: rev 307db61aac9f4b51301ab9d4e74be7632c42d62f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-hdfs-project/hadoop-hdfs/src/test/resources/testErasureCodingConf.xml hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/erasurecode/ECCli.java

          People

          • Assignee:
            yuanbo Yuanbo Liu
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development