Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1017

browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the JSP for browsing the file system calls getRemoteUser(), which doesn't correctly auth the user on the web, causing failures when trying to browse the web. It should call the utility method JspHelper.getUGI instead.

      1. HDFS-1017.3.patch
        4 kB
        Jitendra Nath Pandey
      2. HDFS-1017.2.patch
        4 kB
        Jitendra Nath Pandey
      3. HDFS-1017-Y20-2.patch
        3 kB
        Jakob Homan
      4. HDFS-1017-Y20.patch
        3 kB
        Jakob Homan

        Activity

        Hide
        Jakob Homan added a comment -

        Patch for Y20 distribution, not to be committed. Trunk to follow soon. Before patch, exception with servlet not recognizing user, after patch succesfsully execute servlet with delegation token.

        Show
        Jakob Homan added a comment - Patch for Y20 distribution, not to be committed. Trunk to follow soon. Before patch, exception with servlet not recognizing user, after patch succesfsully execute servlet with delegation token.
        Hide
        Jakob Homan added a comment -

        Had forgotten to commit changes for last patch. New file.

        Show
        Jakob Homan added a comment - Had forgotten to commit changes for last patch. New file.
        Hide
        Owen O'Malley added a comment -

        +1

        Show
        Owen O'Malley added a comment - +1
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for trunk.

        Show
        Jitendra Nath Pandey added a comment - Patch for trunk.
        Hide
        Jitendra Nath Pandey added a comment -

        Fixed a findbugs warning.

        Show
        Jitendra Nath Pandey added a comment - Fixed a findbugs warning.
        Hide
        Jitendra Nath Pandey added a comment -

        test patch restults

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jitendra Nath Pandey added a comment - test patch restults [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Boris Shkolnik added a comment -

        +1

        Show
        Boris Shkolnik added a comment - +1
        Hide
        Jitendra Nath Pandey added a comment -

        ant test was run manually. All tests pass except TestHDFSTrash, which is unrelated and also fails without this patch.

        Show
        Jitendra Nath Pandey added a comment - ant test was run manually. All tests pass except TestHDFSTrash, which is unrelated and also fails without this patch.
        Hide
        Boris Shkolnik added a comment -

        Committed to trunk. Thanks Jitendra and Jacob.

        Show
        Boris Shkolnik added a comment - Committed to trunk. Thanks Jitendra and Jacob.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #318 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/318/)
        HDFS-1017. browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #318 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/318/ ) HDFS-1017 . browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development