Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1017

browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the JSP for browsing the file system calls getRemoteUser(), which doesn't correctly auth the user on the web, causing failures when trying to browse the web. It should call the utility method JspHelper.getUGI instead.

      1. HDFS-1017-Y20-2.patch
        3 kB
        Jakob Homan
      2. HDFS-1017-Y20.patch
        3 kB
        Jakob Homan
      3. HDFS-1017.3.patch
        4 kB
        Jitendra Nath Pandey
      4. HDFS-1017.2.patch
        4 kB
        Jitendra Nath Pandey

        Activity

        Jakob Homan created issue -
        Hide
        Jakob Homan added a comment -

        Patch for Y20 distribution, not to be committed. Trunk to follow soon. Before patch, exception with servlet not recognizing user, after patch succesfsully execute servlet with delegation token.

        Show
        Jakob Homan added a comment - Patch for Y20 distribution, not to be committed. Trunk to follow soon. Before patch, exception with servlet not recognizing user, after patch succesfsully execute servlet with delegation token.
        Jakob Homan made changes -
        Field Original Value New Value
        Attachment HDFS-1017-Y20.patch [ 12437678 ]
        Hide
        Jakob Homan added a comment -

        Had forgotten to commit changes for last patch. New file.

        Show
        Jakob Homan added a comment - Had forgotten to commit changes for last patch. New file.
        Jakob Homan made changes -
        Attachment HDFS-1017-Y20-2.patch [ 12437683 ]
        Hide
        Owen O'Malley added a comment -

        +1

        Show
        Owen O'Malley added a comment - +1
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for trunk.

        Show
        Jitendra Nath Pandey added a comment - Patch for trunk.
        Jitendra Nath Pandey made changes -
        Attachment HDFS-1017.2.patch [ 12447868 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Jitendra Nath Pandey made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jitendra Nath Pandey added a comment -

        Fixed a findbugs warning.

        Show
        Jitendra Nath Pandey added a comment - Fixed a findbugs warning.
        Jitendra Nath Pandey made changes -
        Attachment HDFS-1017.3.patch [ 12447882 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jitendra Nath Pandey added a comment -

        test patch restults

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jitendra Nath Pandey added a comment - test patch restults [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Boris Shkolnik added a comment -

        +1

        Show
        Boris Shkolnik added a comment - +1
        Boris Shkolnik made changes -
        Hadoop Flags [Reviewed]
        Hide
        Jitendra Nath Pandey added a comment -

        ant test was run manually. All tests pass except TestHDFSTrash, which is unrelated and also fails without this patch.

        Show
        Jitendra Nath Pandey added a comment - ant test was run manually. All tests pass except TestHDFSTrash, which is unrelated and also fails without this patch.
        Hide
        Boris Shkolnik added a comment -

        Committed to trunk. Thanks Jitendra and Jacob.

        Show
        Boris Shkolnik added a comment - Committed to trunk. Thanks Jitendra and Jacob.
        Boris Shkolnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #318 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/318/)
        HDFS-1017. browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #318 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/318/ ) HDFS-1017 . browsedfs jsp should call JspHelper.getUGI rather than using createRemoteUser()
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        2h 4m 1 Jitendra Nath Pandey 23/Jun/10 20:52
        Open Open Patch Available Patch Available
        112d 13h 53m 2 Jitendra Nath Pandey 23/Jun/10 20:58
        Patch Available Patch Available Resolved Resolved
        1h 18m 1 Boris Shkolnik 23/Jun/10 22:17
        Resolved Resolved Closed Closed
        536d 8h 1m 1 Konstantin Shvachko 12/Dec/11 06:19

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development