Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1013

Miscellaneous improvements to HTML markup for web UIs

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 2.0.0-alpha
    • Fix Version/s: 0.20.3, 2.0.2-alpha
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      The Web UIs have various bits of bad markup (eg missing <head> sections, some pages missing CSS links, inconsistent td vs th for table headings). We should fix this up.

      1. HDFS-1013.patch
        13 kB
        Eugene Koontz
      2. HDFS-1013.patch
        13 kB
        Eugene Koontz

        Issue Links

          Activity

          Hide
          Eugene Koontz added a comment -

          hadoop.css is missing from src/webapps/static as also described in this related bug.

          Show
          Eugene Koontz added a comment - hadoop.css is missing from src/webapps/static as also described in this related bug.
          Hide
          Eugene Koontz added a comment -

          -add missing <head> around <link> and <title>.
          -add missing src/webapps/static/hadoop.css file
          -use <th> rather than (wrong) <td id="col1"> (wrong because id="col1" occurs
          -make dfstable a CSS class, not an id.
          -make col1 a class (td.col1), not an id (td#col1) since it repeats.
          -add 'report' as a generic div class for dfshealth.jsp.
          -more use and refinement of div class='report'
          -use <div>s rather than <br>s
          -use <li>s for "browse fs" and "namenode logs"

          Show
          Eugene Koontz added a comment - -add missing <head> around <link> and <title>. -add missing src/webapps/static/hadoop.css file -use <th> rather than (wrong) <td id="col1"> (wrong because id="col1" occurs -make dfstable a CSS class, not an id. -make col1 a class (td.col1), not an id (td#col1) since it repeats. -add 'report' as a generic div class for dfshealth.jsp. -more use and refinement of div class='report' -use <div>s rather than <br>s -use <li>s for "browse fs" and "namenode logs"
          Hide
          Eugene Koontz added a comment -

          -add missing <head> around <link> and <title>.
          -add missing src/webapps/static/hadoop.css file
          -use <th> rather than (wrong) <td id="col1"> (wrong because id="col1" occurs
          -make dfstable a CSS class, not an id.
          -make col1 a class (td.col1), not an id (td#col1) since it repeats.
          -add 'report' as a generic div class for dfshealth.jsp.
          -more use and refinement of div class='report'
          -use <div>s rather than <br>s
          -use <li>s for "browse fs" and "namenode logs"

          Show
          Eugene Koontz added a comment - -add missing <head> around <link> and <title>. -add missing src/webapps/static/hadoop.css file -use <th> rather than (wrong) <td id="col1"> (wrong because id="col1" occurs -make dfstable a CSS class, not an id. -make col1 a class (td.col1), not an id (td#col1) since it repeats. -add 'report' as a generic div class for dfshealth.jsp. -more use and refinement of div class='report' -use <div>s rather than <br>s -use <li>s for "browse fs" and "namenode logs"
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/754/
          -----------------------------------------------------------

          Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz.

          Summary
          -------

          Uploading Eugene's patch https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for easier review

          This addresses bug HDFS-1013.
          https://issues.apache.org/jira/browse/HDFS-1013

          Diffs


          trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java 1124363
          trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java 1124363
          trunk/src/webapps/hdfs/dfshealth.jsp 1124363
          trunk/src/webapps/static/hadoop.css PRE-CREATION

          Diff: https://reviews.apache.org/r/754/diff

          Testing
          -------

          Thanks,

          Todd

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/754/ ----------------------------------------------------------- Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz. Summary ------- Uploading Eugene's patch https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for easier review This addresses bug HDFS-1013 . https://issues.apache.org/jira/browse/HDFS-1013 Diffs trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java 1124363 trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java 1124363 trunk/src/webapps/hdfs/dfshealth.jsp 1124363 trunk/src/webapps/static/hadoop.css PRE-CREATION Diff: https://reviews.apache.org/r/754/diff Testing ------- Thanks, Todd
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/754/#review682
          -----------------------------------------------------------

          a few preliminary comments. I also want to load this up and see how it looks

          trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          <https://reviews.apache.org/r/754/#comment1362>

          these lines are missing </td> and </tr> still

          trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          <https://reviews.apache.org/r/754/#comment1363>

          missing </td></tr> on this line and lines below

          trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          <https://reviews.apache.org/r/754/#comment1364>

          do we need warning class on both the div and the a?

          trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          <https://reviews.apache.org/r/754/#comment1365>

          can we kill off these table attributes and use CSS styles to style all the tables consistently?

          • Todd

          On 2011-05-18 19:17:02, Todd Lipcon wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/754/

          -----------------------------------------------------------

          (Updated 2011-05-18 19:17:02)

          Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz.

          Summary

          -------

          Uploading Eugene's patch https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for easier review

          This addresses bug HDFS-1013.

          https://issues.apache.org/jira/browse/HDFS-1013

          Diffs

          -----

          trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java 1124363

          trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java 1124363

          trunk/src/webapps/hdfs/dfshealth.jsp 1124363

          trunk/src/webapps/static/hadoop.css PRE-CREATION

          Diff: https://reviews.apache.org/r/754/diff

          Testing

          -------

          Thanks,

          Todd

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/754/#review682 ----------------------------------------------------------- a few preliminary comments. I also want to load this up and see how it looks trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java < https://reviews.apache.org/r/754/#comment1362 > these lines are missing </td> and </tr> still trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java < https://reviews.apache.org/r/754/#comment1363 > missing </td></tr> on this line and lines below trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java < https://reviews.apache.org/r/754/#comment1364 > do we need warning class on both the div and the a? trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java < https://reviews.apache.org/r/754/#comment1365 > can we kill off these table attributes and use CSS styles to style all the tables consistently? Todd On 2011-05-18 19:17:02, Todd Lipcon wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/754/ ----------------------------------------------------------- (Updated 2011-05-18 19:17:02) Review request for hadoop-hdfs, Todd Lipcon and Eugene Koontz. Summary ------- Uploading Eugene's patch https://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch for easier review This addresses bug HDFS-1013 . https://issues.apache.org/jira/browse/HDFS-1013 Diffs ----- trunk/src/java/org/apache/hadoop/hdfs/server/common/JspHelper.java 1124363 trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java 1124363 trunk/src/webapps/hdfs/dfshealth.jsp 1124363 trunk/src/webapps/static/hadoop.css PRE-CREATION Diff: https://reviews.apache.org/r/754/diff Testing ------- Thanks, Todd
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch
          against trunk revision 1124364.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479631/HDFS-1013.patch against trunk revision 1124364. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/558//console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Hey Eugene,
          Plan to address Todd's feedback and update the patch for trunk?

          Show
          Eli Collins added a comment - Hey Eugene, Plan to address Todd's feedback and update the patch for trunk?
          Hide
          Eugene Koontz added a comment -

          Will do it this week. Thanks for the reminder and sorry for the long delay.

          Show
          Eugene Koontz added a comment - Will do it this week. Thanks for the reminder and sorry for the long delay.
          Hide
          Eli Collins added a comment -

          Thanks!

          Show
          Eli Collins added a comment - Thanks!
          Hide
          Eugene Koontz added a comment -

          -Adds hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css (resembles hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css with some additions for this patch)

          -Replaces ids with classes where necessary (e.g. <td id="col1"> => <td class="col1">)

          -Replaces occurrences of "<br>..</br>" with "<div>..</div>"

          Show
          Eugene Koontz added a comment - -Adds hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css (resembles hadoop-common-project/hadoop-common/src/main/webapps/static/hadoop.css with some additions for this patch) -Replaces ids with classes where necessary (e.g. <td id="col1"> => <td class="col1">) -Replaces occurrences of "<br>..</br>" with "<div>..</div>"
          Hide
          Todd Lipcon added a comment -

          +1 pending jenkins. I built this locally and verified the CSS is taking effect in the web UI, seems to look fine in chrome.

          Show
          Todd Lipcon added a comment - +1 pending jenkins. I built this locally and verified the CSS is taking effect in the web UI, seems to look fine in chrome.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12528362/HDFS-1013.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2501//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2501//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12528362/HDFS-1013.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2501//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2501//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2360 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2360/)
          HDFS-1013. Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2360 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2360/ ) HDFS-1013 . Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2287 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2287/)
          HDFS-1013. Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102)

          Result = SUCCESS
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2287 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2287/ ) HDFS-1013 . Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102) Result = SUCCESS todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2305/)
          HDFS-1013. Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102)

          Result = FAILURE
          todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102
          Files :

          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static
          • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2305 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2305/ ) HDFS-1013 . Miscellaneous improvements to HTML markup for web UIs. Contributed by Eugene Koontz. (Revision 1342102) Result = FAILURE todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1342102 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/JspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/hadoop.css

            People

            • Assignee:
              Eugene Koontz
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development