Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1011

Improve Logging in HDFSProxy to include cluster name associated with the request

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: contrib/hdfsproxy
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Improve Logging in HDFSProxy to include cluster name associated with the request

      1. HDFS-1011-bp-y20.patch
        5 kB
        Srikanth Sundarrajan
      2. HDFS-1011-bp-y20s.patch
        7 kB
        Srikanth Sundarrajan
      3. HDFS-1011.patch
        6 kB
        Srikanth Sundarrajan
      4. HDFS-1011.patch
        12 kB
        Srikanth Sundarrajan
      5. HDFS-1011.patch
        6 kB
        Srikanth Sundarrajan
      6. HDFS-1011-bp-y20s.patch
        7 kB
        Srikanth Sundarrajan

        Activity

        Hide
        Srikanth Sundarrajan added a comment -

        Setting the thread name to be the name of the request context path. Extended logger pattern to include thread name. This will ensure that all logged message will include the context path.

        Patches for HDFS-481, HDFS-1010 need to be applied before this patch can be applied

        Backport patches to y20 included. Not for commit.

        Show
        Srikanth Sundarrajan added a comment - Setting the thread name to be the name of the request context path. Extended logger pattern to include thread name. This will ensure that all logged message will include the context path. Patches for HDFS-481 , HDFS-1010 need to be applied before this patch can be applied Backport patches to y20 included. Not for commit.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12439444/HDFS-1011.patch
        against trunk revision 925509.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/277/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12439444/HDFS-1011.patch against trunk revision 925509. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/277/console This message is automatically generated.
        Hide
        Srikanth Sundarrajan added a comment -

        Output from test-patch and test-contrib

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        test:

        BUILD SUCCESSFUL
        Total time: 4 minutes 34 seconds

        ----------

        No new tests included with this patch. This patch has been tested manually. log4j.xml under tomcat_home/lib folder has been modified to include [%t] in the pattern layout for file and console appender. War file for hdfsproxy deployed under tomcat webapp with context name cluster1. The logs generated by the webapp includes [cluster1] in the logs.

        Show
        Srikanth Sundarrajan added a comment - Output from test-patch and test-contrib [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. test: BUILD SUCCESSFUL Total time: 4 minutes 34 seconds ---------- No new tests included with this patch. This patch has been tested manually. log4j.xml under tomcat_home/lib folder has been modified to include [%t] in the pattern layout for file and console appender. War file for hdfsproxy deployed under tomcat webapp with context name cluster1. The logs generated by the webapp includes [cluster1] in the logs.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1
        I also like the changes in hdfsproxy/build.xml.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 I also like the changes in hdfsproxy/build.xml.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Hi Srikanth, the patch file has some problem. Could you fix it?

        Show
        Tsz Wo Nicholas Sze added a comment - Hi Srikanth, the patch file has some problem. Could you fix it?
        Hide
        Srikanth Sundarrajan added a comment -

        Revising patch. Earlier patch was incorrect.

        Show
        Srikanth Sundarrajan added a comment - Revising patch. Earlier patch was incorrect.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Srikanth!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Srikanth!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/233/)
        . hdfsproxy: Improve log messages by restoring the previous thread name. Contributed by Srikanth Sundarrajan

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #233 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/233/ ) . hdfsproxy: Improve log messages by restoring the previous thread name. Contributed by Srikanth Sundarrajan
        Hide
        Srikanth Sundarrajan added a comment -

        Revised backport patch in sync with trunk patch for yhadoop20s.

        Show
        Srikanth Sundarrajan added a comment - Revised backport patch in sync with trunk patch for yhadoop20s.

          People

          • Assignee:
            Ramesh Sekaran
            Reporter:
            Srikanth Sundarrajan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development