Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira tracks implementation of security for Fsck. Fsck should make an authenticated connection to the namenode.

      1. h1005-02.patch
        3 kB
        Kan Zhang
      2. HDFS-1005-BP20.patch
        6 kB
        Boris Shkolnik
      3. HDFS-1005-BP20-1.patch
        1 kB
        Devaraj Das
      4. HDFS-1005-y20.1.patch
        2 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Boris Shkolnik added a comment -

        tested in both secure and insecure modes.

        Show
        Boris Shkolnik added a comment - tested in both secure and insecure modes.
        Hide
        Devaraj Das added a comment -

        Looks fine

        Show
        Devaraj Das added a comment - Looks fine
        Hide
        Boris Shkolnik added a comment -

        HDFS-1005-BP20.patch for previous version of Hadoop. Not for commit.

        Show
        Boris Shkolnik added a comment - HDFS-1005 -BP20.patch for previous version of Hadoop. Not for commit.
        Hide
        Devaraj Das added a comment -

        Bugfix on top of the earlier Y20 patch.

        Show
        Devaraj Das added a comment - Bugfix on top of the earlier Y20 patch.
        Hide
        Kan Zhang added a comment -

        A straight-forward port for trunk.

        Show
        Kan Zhang added a comment - A straight-forward port for trunk.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12448845/h1005-02.patch
        against trunk revision 960949.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448845/h1005-02.patch against trunk revision 960949. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/210/console This message is automatically generated.
        Hide
        Kan Zhang added a comment -

        Re-submit to trigger Hudson.

        Show
        Kan Zhang added a comment - Re-submit to trigger Hudson.
        Hide
        Jakob Homan added a comment -

        +1. Forward port looks good. Tests have been failing recently. Fastest way to verify it's unrelated is to re-run just the Hudson-failed tests locally and verify they pass on your local box (which has been what's been happening for me).

        Show
        Jakob Homan added a comment - +1. Forward port looks good. Tests have been failing recently. Fastest way to verify it's unrelated is to re-run just the Hudson-failed tests locally and verify they pass on your local box (which has been what's been happening for me).
        Hide
        Kan Zhang added a comment -

        Re-ran failed tests manually for multiple times each. TestFileAppend4 fails occasionally. Others were successful. None of the failed tests seem to be related to this patch.

        This patch adds a Kerberos feature and no automated tests are possible at this time. However, I did manually verify the feature on a single node cluster.

        Show
        Kan Zhang added a comment - Re-ran failed tests manually for multiple times each. TestFileAppend4 fails occasionally. Others were successful. None of the failed tests seem to be related to this patch. This patch adds a Kerberos feature and no automated tests are possible at this time. However, I did manually verify the feature on a single node cluster.
        Hide
        Jakob Homan added a comment -

        I've committed this. Resolving as fixed. Thanks, uhm, everybody.

        Show
        Jakob Homan added a comment - I've committed this. Resolving as fixed. Thanks, uhm, everybody.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #333 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/333/)
        HDFS-1005. Fsck security. Contributed by Boris Shkolnik and Kan Zhang.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #333 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/333/ ) HDFS-1005 . Fsck security. Contributed by Boris Shkolnik and Kan Zhang.

          People

          • Assignee:
            Boris Shkolnik
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development