[HDDS-9952] Simplify assertions

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Done
• Fix Version/s: 2.0.0
• Component/s: test
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 18/Dec/23 15:13
• Updated: 08/Jan/24 20:10
• Resolved: 08/Jan/24 20:10

Description

Assertions in the form:

assertTrue(<x> == <y>)
assertEquals(null, <x>) or assertTrue(<x> == null)
assertTrue(<x> != null)
assertEquals(<boolean>, <x>)

can be simplified to:

assertEquals(<x>, <y>)
assertNull(<x>)
assertNotNull(<x>)
assertTrue/assertFalse(<x>)

Not only are these simpler, some of them also provide more information in case of failure.

Issue Links

• is a child of: HDDS-9931 Improve unit/integration tests